Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Expose apps/widgets #12071

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Conversation

charlynguyen
Copy link
Contributor

@charlynguyen charlynguyen commented Dec 19, 2023

This PR exposes the apps/widgets of a room via ProxiedModuleApi. It allows to:

  • getApps – Gets the apps for a given room.
  • getAppAvatarUrl – Gets the avatar URL for an app.
  • isAppInContainer – Checks if an app is in a container for a given room.
  • moveAppToContainer – Moves apps to containers for a given room.

Is blocked by matrix-org/matrix-react-sdk-module-api#30.

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

✨ Features

@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements labels Dec 19, 2023
@charlynguyen charlynguyen force-pushed the charlynguyen/expose-widgets branch 2 times, most recently from 949e645 to cd90699 Compare December 19, 2023 20:37
@charlynguyen charlynguyen marked this pull request as ready for review December 20, 2023 09:14
@charlynguyen charlynguyen requested review from a team as code owners December 20, 2023 09:14
@charlynguyen charlynguyen marked this pull request as draft December 22, 2023 10:09
Charly Nguyen added 2 commits January 10, 2024 16:10
Signed-off-by: Charly Nguyen <charly.nguyen@nordeck.net>
Signed-off-by: Charly Nguyen <charly.nguyen@nordeck.net>
@charlynguyen
Copy link
Contributor Author

@t3chguy @robintown friendly reminder 🤗

@t3chguy
Copy link
Member

t3chguy commented Jan 17, 2024

@charlynguyen it isn't passing CI.

@charlynguyen
Copy link
Contributor Author

charlynguyen commented Jan 17, 2024

@t3chguy I merge develop into this branch and the CI for E2E Tests fail with

║ Looks like Playwright Test or Playwright was just installed or updated. ║
║ Please run the following command to download new browsers:              ║
yarn playwright install

What do I miss?

@t3chguy
Copy link
Member

t3chguy commented Jan 17, 2024

@charlynguyen its a caching issue with github actions, I purged the cache, now it is fine

@t3chguy t3chguy added this pull request to the merge queue Jan 22, 2024
Merged via the queue into matrix-org:develop with commit 11096b2 Jan 22, 2024
23 checks passed
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Feb 3, 2024
Weirdly, there is no 1.11.56, so it apparently was skipped?

Changes in [1.11.57](https://github.com/element-hq/element-web/releases/tag/v1.11.57) (2024-01-31)
==================================================================================================
## 🦖 Deprecations

* Deprecate welcome bot `welcome_user_id` support ([#26885](element-hq/element-web#26885)). Contributed by @t3chguy.

## ✨ Features

* Expose apps/widgets ([#12071](matrix-org/matrix-react-sdk#12071)). Contributed by @charlynguyen.
* Enable the rust-crypto labs button ([#12114](matrix-org/matrix-react-sdk#12114)). Contributed by @richvdh.
* Show a progress bar while migrating from legacy crypto ([#12104](matrix-org/matrix-react-sdk#12104)). Contributed by @richvdh.
* Update Twemoji to Jdecked v15.0.3 ([#12147](matrix-org/matrix-react-sdk#12147)). Contributed by @t3chguy.
* Change Quick Settings icon ([#12141](matrix-org/matrix-react-sdk#12141)). Contributed by @florianduros.
* Use Compound tooltips more widely ([#12128](matrix-org/matrix-react-sdk#12128)). Contributed by @t3chguy.

## 🐛 Bug Fixes

* Fix OIDC bugs due to amnesiac stores forgetting OIDC issuer \& other data ([#12166](matrix-org/matrix-react-sdk#12166)). Contributed by @t3chguy.
* Fix account management link for delegated auth OIDC setups ([#12144](matrix-org/matrix-react-sdk#12144)). Contributed by @t3chguy.
* Fix Safari IME support ([#11016](matrix-org/matrix-react-sdk#11016)). Contributed by @SuperKenVery.
* Fix Stickerpicker layout crossing multiple CSS stacking contexts ([#12127](matrix-org/matrix-react-sdk#12127)).
* Fix Stickerpicker layout crossing multiple CSS stacking contexts ([#12126](matrix-org/matrix-react-sdk#12126)). Contributed by @t3chguy.
* Fix 1F97A and 1F979 in Twemoji COLR font ([#12177](matrix-org/matrix-react-sdk#12177)).
## ✨ Features

* Expose apps/widgets ([#12071](matrix-org/matrix-react-sdk#12071)). Contributed by @charlynguyen.
* Enable the rust-crypto labs button ([#12114](matrix-org/matrix-react-sdk#12114)). Contributed by @richvdh.
* Show a progress bar while migrating from legacy crypto ([#12104](matrix-org/matrix-react-sdk#12104)). Contributed by @richvdh.
* Update Twemoji to Jdecked v15.0.3 ([#12147](matrix-org/matrix-react-sdk#12147)). Contributed by @t3chguy.
* Change Quick Settings icon ([#12141](matrix-org/matrix-react-sdk#12141)). Contributed by @florianduros.
* Use Compound tooltips more widely ([#12128](matrix-org/matrix-react-sdk#12128)). Contributed by @t3chguy.

## 🐛 Bug Fixes

* Fix OIDC bugs due to amnesiac stores forgetting OIDC issuer \& other data ([#12166](matrix-org/matrix-react-sdk#12166)). Contributed by @t3chguy.
* Fix account management link for delegated auth OIDC setups ([#12144](matrix-org/matrix-react-sdk#12144)). Contributed by @t3chguy.
* Fix Safari IME support ([#11016](matrix-org/matrix-react-sdk#11016)). Contributed by @SuperKenVery.
* Fix Stickerpicker layout crossing multiple CSS stacking contexts ([#12127](matrix-org/matrix-react-sdk#12127)).
* Fix Stickerpicker layout crossing multiple CSS stacking contexts ([#12126](matrix-org/matrix-react-sdk#12126)). Contributed by @t3chguy.
* Fix 1F97A and 1F979 in Twemoji COLR font ([#12177](matrix-org/matrix-react-sdk#12177)).
## ✨ Features

* Use jitsi-lobby in video channel (video rooms) ([#26879](element-hq/element-web#26879)). Contributed by @toger5.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants