This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Show a progress bar while migrating from legacy crypto #12104

Merged

richvdh merged 4 commits into develop from rav/element-r/migration/progress

Jan 17, 2024

Member

richvdh commented Jan 3, 2024 •

edited by github-actions bot

Loading

Fixes element-hq/element-web#26773.
Requires matrix-org/matrix-js-sdk#3982

Screenshot:

Here's what your changelog entry will look like:

✨ Features

Show a progress bar while migrating from legacy crypto (#12104). Fixes Element-R: Progress display for migration to Rust crypto element-hq/element-web#26773.

richvdh added the T-Enhancement label

richvdh force-pushed the rav/element-r/migration/progress branch from 6a24076 to 835fc53 Compare

January 3, 2024 16:51

Base automatically changed from rav/login_splash_screen to develop

January 4, 2024 18:35

pmaier1 commented Jan 5, 2024 •

edited

Loading

Proposal
Hang tight. We are updating Element to optimise your experience.

I think this should make it clear that it's a one-off.

richvdh force-pushed the rav/element-r/migration/progress branch 3 times, most recently from d3b7d88 to 3abfd00 Compare

January 5, 2024 11:15

github-actions bot deployed to Netlify

January 8, 2024 14:55

View deployment

github-actions bot deployed to EndToEndTests

January 8, 2024 15:13

View deployment

pmaier1 commented Jan 8, 2024 •

edited

Loading

Proposal2
Hang tight. We are updating Element to make encryption faster and more reliable.

Member Author

richvdh commented Jan 10, 2024

Proposal2 Hang tight. We are updating Element to make encryption faster and more reliable.

Now updated

github-actions bot deployed to Netlify

January 10, 2024 17:17

View deployment


          Show a progress bar during migration of crypto data

e43032c

richvdh force-pushed the rav/element-r/migration/progress branch from c45fe14 to afd52ca Compare

January 10, 2024 17:20

github-actions bot deployed to Netlify

January 10, 2024 17:24

View deployment


          playwright: add new pageWithCredentials fixture

4b83a28

richvdh force-pushed the rav/element-r/migration/progress branch from afd52ca to 9b29ee9 Compare

January 10, 2024 17:34

github-actions bot deployed to Netlify

January 10, 2024 17:37

View deployment


          Add a playwright test for migration progress

6155a2b

richvdh force-pushed the rav/element-r/migration/progress branch from 9b29ee9 to 6155a2b Compare

January 10, 2024 17:41

github-actions bot deployed to Netlify

January 10, 2024 17:45

View deployment

richvdh mentioned this pull request

Enable the rust-crypto labs button #12114

Merged

richvdh requested a review from a team

January 10, 2024 17:52

richvdh marked this pull request as ready for review

January 10, 2024 17:52

richvdh requested a review from a team as a code owner

January 10, 2024 17:52

richvdh requested review from MidhunSureshR and robintown

January 10, 2024 17:52

github-actions bot deployed to EndToEndTests

January 10, 2024 18:06

View deployment

richvdh requested review from a team and removed request for a team

January 16, 2024 14:06

richvdh requested review from andybalaam and uhoreg

January 16, 2024 14:07

andybalaam approved these changes

View reviewed changes

Contributor

andybalaam left a comment

Looks good - a few minor comments and questions.

playwright/e2e/crypto/test_indexeddb_cryptostore_dump/load.js

+              function getPickleAdditionalData(userId, deviceId) {
+                  const additionalData = new Uint8Array(userId.length + deviceId.length + 1);
+                  for (let i = 0; i < userId.length; i++) {
+                      additionalData[i] = userId.charCodeAt(i);

Contributor

andybalaam Jan 16, 2024

Is all the data ASCII? We appear to be looping through UTF-16 code units and inserting them into 8-bit character data.

Member Author

richvdh Jan 16, 2024

For what it's worth, this whole method was a c&p from BasePlatform.ts. To answer this specific point: hopefully!

The data in question are a user ID and a device ID. The user ID is effectively made up by playwright; currently it is always @user:localhost. (Also, https://spec.matrix.org/v1.9/appendices/#user-identifiers mandates ascii for user IDs.)

The device ID is made up by the homeserver being used for the tests. They lack a grammar (matrix-org/matrix-spec#174), but Synapse always uses ASCII IDs.

Contributor

andybalaam Jan 17, 2024

Sounds OK then, but maybe worth a comment.

playwright/e2e/crypto/test_indexeddb_cryptostore_dump/load.js

+                  for (let i = 0; i < userId.length; i++) {
+                      additionalData[i] = userId.charCodeAt(i);
+                  }
+                  additionalData[userId.length] = 124; // "|"

Contributor

andybalaam Jan 16, 2024

I think I'd marginally prefer "|".charCodeAt(0) but OK with this.

playwright/e2e/crypto/test_indexeddb_cryptostore_dump/load.js

+                  }
+                  additionalData[userId.length] = 124; // "|"
+                  for (let i = 0; i < deviceId.length; i++) {
+                      additionalData[userId.length + 1 + i] = deviceId.charCodeAt(i);

Contributor

andybalaam Jan 16, 2024

Would it be easier to concatenate the strings and then loop through one string?

Member Author

richvdh Jan 16, 2024

Yes, you'd think. I can only say again: this was cargo-culted.

playwright/e2e/crypto/test_indexeddb_cryptostore_dump/load.js Show resolved Hide resolved

playwright/e2e/crypto/test_indexeddb_cryptostore_dump/load.js

+                          yield decoded.charCodeAt(i);
+                      }
+                  };
+                  const decoded = Uint8Array.from(itFunc());

Contributor

andybalaam Jan 16, 2024

Same question about UTF-16 code units going into an 8-bit array.

Contributor

andybalaam Jan 16, 2024

Hmm, but I guess these are from a base64-encoded string, so they are guaranteed ASCII.

Member Author

richvdh Jan 16, 2024

yes. this bit was cargo-culted from decodeBase64 in the js-sdk.

playwright/e2e/crypto/test_indexeddb_cryptostore_dump/load.js Show resolved Hide resolved


          Add documentation for idbSave

97a4526

github-actions bot deployed to Netlify

January 16, 2024 17:49

View deployment

github-actions bot deployed to EndToEndTests

January 16, 2024 18:09

View deployment

richvdh added this pull request to the merge queue

Merged via the queue into develop with commit 993a702

22 checks passed

richvdh deleted the rav/element-r/migration/progress branch

January 17, 2024 07:37

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request


          Update chat/element-web to 1.11.57

372f5c1

Weirdly, there is no 1.11.56, so it apparently was skipped?

Changes in [1.11.57](https://github.com/element-hq/element-web/releases/tag/v1.11.57) (2024-01-31)
==================================================================================================
## 🦖 Deprecations

* Deprecate welcome bot `welcome_user_id` support ([#26885](element-hq/element-web#26885)). Contributed by @t3chguy.

## ✨ Features

* Expose apps/widgets ([#12071](matrix-org/matrix-react-sdk#12071)). Contributed by @charlynguyen.
* Enable the rust-crypto labs button ([#12114](matrix-org/matrix-react-sdk#12114)). Contributed by @richvdh.
* Show a progress bar while migrating from legacy crypto ([#12104](matrix-org/matrix-react-sdk#12104)). Contributed by @richvdh.
* Update Twemoji to Jdecked v15.0.3 ([#12147](matrix-org/matrix-react-sdk#12147)). Contributed by @t3chguy.
* Change Quick Settings icon ([#12141](matrix-org/matrix-react-sdk#12141)). Contributed by @florianduros.
* Use Compound tooltips more widely ([#12128](matrix-org/matrix-react-sdk#12128)). Contributed by @t3chguy.

## 🐛 Bug Fixes

* Fix OIDC bugs due to amnesiac stores forgetting OIDC issuer \& other data ([#12166](matrix-org/matrix-react-sdk#12166)). Contributed by @t3chguy.
* Fix account management link for delegated auth OIDC setups ([#12144](matrix-org/matrix-react-sdk#12144)). Contributed by @t3chguy.
* Fix Safari IME support ([#11016](matrix-org/matrix-react-sdk#11016)). Contributed by @SuperKenVery.
* Fix Stickerpicker layout crossing multiple CSS stacking contexts ([#12127](matrix-org/matrix-react-sdk#12127)).
* Fix Stickerpicker layout crossing multiple CSS stacking contexts ([#12126](matrix-org/matrix-react-sdk#12126)). Contributed by @t3chguy.
* Fix 1F97A and 1F979 in Twemoji COLR font ([#12177](matrix-org/matrix-react-sdk#12177)).
## ✨ Features

* Expose apps/widgets ([#12071](matrix-org/matrix-react-sdk#12071)). Contributed by @charlynguyen.
* Enable the rust-crypto labs button ([#12114](matrix-org/matrix-react-sdk#12114)). Contributed by @richvdh.
* Show a progress bar while migrating from legacy crypto ([#12104](matrix-org/matrix-react-sdk#12104)). Contributed by @richvdh.
* Update Twemoji to Jdecked v15.0.3 ([#12147](matrix-org/matrix-react-sdk#12147)). Contributed by @t3chguy.
* Change Quick Settings icon ([#12141](matrix-org/matrix-react-sdk#12141)). Contributed by @florianduros.
* Use Compound tooltips more widely ([#12128](matrix-org/matrix-react-sdk#12128)). Contributed by @t3chguy.

## 🐛 Bug Fixes

* Fix OIDC bugs due to amnesiac stores forgetting OIDC issuer \& other data ([#12166](matrix-org/matrix-react-sdk#12166)). Contributed by @t3chguy.
* Fix account management link for delegated auth OIDC setups ([#12144](matrix-org/matrix-react-sdk#12144)). Contributed by @t3chguy.
* Fix Safari IME support ([#11016](matrix-org/matrix-react-sdk#11016)). Contributed by @SuperKenVery.
* Fix Stickerpicker layout crossing multiple CSS stacking contexts ([#12127](matrix-org/matrix-react-sdk#12127)).
* Fix Stickerpicker layout crossing multiple CSS stacking contexts ([#12126](matrix-org/matrix-react-sdk#12126)). Contributed by @t3chguy.
* Fix 1F97A and 1F979 in Twemoji COLR font ([#12177](matrix-org/matrix-react-sdk#12177)).
## ✨ Features

* Use jitsi-lobby in video channel (video rooms) ([#26879](element-hq/element-web#26879)). Contributed by @toger5.

estellecomment mentioned this pull request

Upgrade to 1.11.58 : without enabling of rust crypto by default tchapgouv/tchap-web-v4#905

Closed

richvdh mentioned this pull request

"migrating_crypto" translation should use "%(brand)s" instead of "Element" element-hq/element-web#27021

Closed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

andybalaam andybalaam approved these changes

MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from matrix-org/element-web-reviewers

robintown Awaiting requested review from robintown robintown is a code owner automatically assigned from matrix-org/element-web-reviewers

uhoreg Awaiting requested review from uhoreg uhoreg was automatically assigned from matrix-org/element-crypto-web-reviewers

Labels