Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Make the timeline less noisy for screen readers (mk II) #3019

Merged
merged 7 commits into from
May 23, 2019
Merged

Make the timeline less noisy for screen readers (mk II) #3019

merged 7 commits into from
May 23, 2019

Commits on May 22, 2019

  1. Hide flair from screen readers 

    To have less noise when they run over the sender profile.

See element-hq/element-web#9747
    @turt2live
    turt2live committed May 22, 2019
    Configuration menu
    Copy the full SHA
    85a0241 View commit details
    Browse the repository at this point in the history

  2. Mute avatars and read receipts on event tiles 

    This reduces overall noise from the screen reader. It was reading the alt attribute from the sender avatar, which was just a mxid. The read receipts were just nonsensical noise.

Fixes element-hq/element-web#2716
Fixes element-hq/element-web#5697
See element-hq/element-web#9747
    @turt2live
    turt2live committed May 22, 2019
    Configuration menu
    Copy the full SHA
    6edf760 View commit details
    Browse the repository at this point in the history

  3. Mute timestamps for irrelevant updates 

    Other fix for element-hq/element-web#5697

See element-hq/element-web#9747
    @turt2live
    turt2live committed May 22, 2019
    Configuration menu
    Copy the full SHA
    8f6884e View commit details
    Browse the repository at this point in the history

  4. Always mute timestamp from screen readers 

    The short time is still read out (eg: 15:24), however by ignoring the anchor we prevent the reader from saying the title of the containing span. This prevents readers saying "Wed May 22, 2019 at 15:24 15:24".

See element-hq/element-web#9747
    @turt2live
    turt2live committed May 22, 2019
    Configuration menu
    Copy the full SHA
    c55f083 View commit details
    Browse the repository at this point in the history

  5. Fix events not being spoken in the most complicated way possible 

    There's details in the comment body of this diff.

See element-hq/element-web#9747
    @turt2live
    turt2live committed May 22, 2019
    Configuration menu
    Copy the full SHA
    09d195b View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review 

    Co-Authored-By: J. Ryan Stinnett <jryans@gmail.com>
    @turt2live @jryans
    turt2live and jryans authored May 22, 2019
    Configuration menu
    Copy the full SHA
    d571709 View commit details
    Browse the repository at this point in the history

  7. Convert ternary to multiple if statements for clarity

    @turt2live
    turt2live committed May 22, 2019
    Configuration menu
    Copy the full SHA
    a7d2309 View commit details
    Browse the repository at this point in the history