This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Send read marker updates immediately after moving visually #4755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `TimelinePanel` uses two timers to coordinate read marker and read receipt updates. When the read receipt timer fires, we advance the receipt and send the latest state of both your receipt and marker to the server. When the read marker timer fires, we advance the marker visually, but do not send anything to the server: we were relying on the slightly different schedule of the read receipt to actually send the updated read marker. This means there's a time window where it's possible to visually advance the read marker without ever sending it to the server (if you change rooms before the receipt timer fires again). To simplify the behaviour here and ensure we always commit the updated marker when we move it, this change sends an update to the server at the same time as moving the marker. It's possible this may improve some of the behaviour reported in element-hq/element-web#12338.
jryans
force-pushed
the
jryans/send-read-marker-immed
branch
from
a97b6b0
to
39c28e2
Compare
t3chguy
approved these changes
Jun 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TimelinePaneluses two timers to coordinate read marker and read receiptupdates. When the read receipt timer fires, we advance the receipt and send the
latest state of both your receipt and marker to the server. When the read marker
timer fires, we advance the marker visually, but do not send anything to the
server: we were relying on the slightly different schedule of the read receipt
to actually send the updated read marker. This means there's a time window where
it's possible to visually advance the read marker without ever sending it to the
server (if you change rooms before the receipt timer fires again).
To simplify the behaviour here and ensure we always commit the updated marker
when we move it, this change sends an update to the server at the same time as
moving the marker.
It's possible this may improve some of the behaviour reported in element-hq/element-web#12338.