Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Send read marker updates immediately after moving visually #4755

Merged
merged 1 commit into from
Jun 12, 2020

Commits on Jun 12, 2020

  1. Send read marker updates immediately after moving visually

    The `TimelinePanel` uses two timers to coordinate read marker and read receipt
    updates. When the read receipt timer fires, we advance the receipt and send the
    latest state of both your receipt and marker to the server. When the read marker
    timer fires, we advance the marker visually, but do not send anything to the
    server: we were relying on the slightly different schedule of the read receipt
    to actually send the updated read marker. This means there's a time window where
    it's possible to visually advance the read marker without ever sending it to the
    server (if you change rooms before the receipt timer fires again).
    
    To simplify the behaviour here and ensure we always commit the updated marker
    when we move it, this change sends an update to the server at the same time as
    moving the marker.
    
    It's possible this may improve some of the behaviour reported in
    element-hq/element-web#12338.
    jryans committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    39c28e2 View commit details
    Browse the repository at this point in the history