Fix new URL previews #5666
Fix new URL previews #5666
Conversation
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
|
/me missed the Draft label and got over-excited :D |
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
|
as the guy who introduced the thing that nobody liked, i agree this is a much more graceful way of accomplishing what i wanted to do 😄 |
|
after checking this out in action using the netlify deployment, i think it could handle even more restrictive use-case... specifically if the url ends in a known image mimetype (.jpg, .jpeg, .png, .gif). i say this because the issues with blurb text wrapping that raised some complaints is still in place with the narrower div for a lot of url previews that do supply an image rather than an element. the more compact horizontal url preview should probably be used more frequently, only depending on a larger image preview if it's specifically an image link. |
SimonBrandner
added
the
T-Defect
|
Closing as this PR is probably quite outdated by now Related issues: element-hq/element-web#7897 and element-hq/element-meta#1583 |
Description
Fixes #16479
Image
Non-image
Additional info
This is going to need some input from the Design team