This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create room threads list view #6904
Create room threads list view #6904
Changes from all commits
2de3716
8808886
3e5e444
81c3c6a
f77a33e
282c011
45095bb
15b7853
bed9262
498ebf4
a39e8d9
c1de0e3
05e7c17
e7cecf9
5774385
f1d0545
e78cbbf
2e920ae
8b61277
8329b29
bb99972
f74355b
eaa6b6b
cd4b107
8193674
0cce2f2
b1fa8d8
577d623
f355a45
ad92419
f57bc21
51ebe68
9940cb8
9fee5f4
82aebbc
eb1bcd8
baf048d
3fa416a
eb3bc79
ef69749
a54a69f
c5166c0
757e30c
d4e08e5
9823ffd
3b8c5e8
ea8970d
21fc950
c2ec71f
ab756db
96874ff
357dd39
3a1b919
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More a personal opinion/preference, but I usually try to stay away from writing this.
It might be slightly shorter to write, but forces one to look up to figure out how the classname will be computed, but more importantly breaks the codebase searchability giving less us confidence to delete things in the long term
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not doing it to shorten things up, but to couple it together - I agree that it makes things hard to search for, but makes it a lot easier to look at context of that specific class in scss file, which in this particular case really does help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably live within the contextual menu component.
None of it is inherently tied to threads and I could see this new design declination spread throughout the codebase.
The current naming and where the code lives might prevent that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is inherently tied to threads though. If it's not then we should create a normalized components for contextual menu items that should always be used there.
This is out of scope of this issue.