Create room threads list view #6904
Conversation
Palid
force-pushed
the
feature/palid/18957
branch
from
df25b38 to
c670d95
Compare
|
I'm assuming this isn't meant to be in the review queue just yet. |
* origin/develop: (27 commits) Fix room list skeleton ui for narrow room list Reset matrix-js-sdk back to develop branch Resetting package fields for development v3.32.1 Prepare changelog for v3.32.1 Upgrade matrix-js-sdk to 14.0.1 Remove semicolon from notifications panel Resetting package fields for development v3.32.0 Prepare changelog for v3.32.0 Upgrade matrix-js-sdk to 14.0.0 Hide Skeleton UI if you have Suggested Rooms Tweak skeleton UI height to be more reasonable Iterate invite your teammates to Space view Make thread button always visible (#6903) Prevent backdrop image from being selected v3.32.0-rc.2 Prepare changelog for v3.32.0-rc.2 Upgrade matrix-js-sdk to 14.0.0-rc.2 Simplify and improve useRoomHierarchy hook ...
There was a problem hiding this comment.
That looks much better to me!
I'd like to hear your plan of attack regarding the Set<Thread>/EventTimelineSet stuff before I give my approve here but it looks much better
Found a small UI defect to do when the timestamp when hovering the EventTile but besides that it works pretty well
Also appears that we're missing an "empty" state for that panel, @janogarcia should be able to help us here. We can make that happen in a different PR if there's going a bit of lead time on the design side
Yeah, it's on my list! Haven't finished working on it and its spec, which touches slightly different scenarios (no threads at all in room, no threads when filtering for threads you've participated in, or when switching to display only unread threads... but that one is out scope for now). |
* origin/develop: Fix missing snapshot serializer&enzyme init (#6932) Allow editing of /rainbow and /rainbowme Fix EditorModel clone to actually be useful Improve typing Inhibit `Unable to get validated threepid` error during UIA
There was a problem hiding this comment.
It looks now that the order of the events in the thread's list has been inverted.
The oldest event is at the bottom, when usually this newest event is at the bottom.
This was a follow up on a discussion with @janogarcia where he mentioned he recommends inverting the order of that list as well as the notification panel and the file panel.
But it's not as simple as reversing the order of the array, as the TimelinePanel does a lot of scroll jump when a new item is added to the list and we need to properly cater for that. This component is now running under the assumption that newest is always at the bottom.
Let's revert that change and create a separate task to build that experience up
Partially deals with element-hq/element-web#18957 (missing the empty list design)
This PR currently has no changelog labels, so will not be included in changelogs.
A reviewer can add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is, or addType: [enhancement/defect/task]to the description and I'll add them for you.Preview: https://61683093f95e3b00ba0ae9c7--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.