This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add a basic PR checklist for all PRs #9046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It'll be mildly annoying for core developers who have to constantly remove or edit this, but it'll also serve as a good reminder to do these things. Note that signoff is not required for core developers.
turt2live
added
the
T-Task
weeman1337
reviewed
Jul 11, 2022
| Notes: | ||
| * [ ] Tests written for new code (and old code if feasible) | ||
| * [ ] Linter and other CI checks pass | ||
| * [ ] Sign-off given on the changes (see [CONTRIBUTING.md](https://github.com/matrix-org/matrix-react-sdk/blob/develop/CONTRIBUTING.md)) |
There was a problem hiding this comment.
Should we ask for before/after screenshots for frontend affecting changes?
There was a problem hiding this comment.
Yes, but not in the checklist. That's a contributing guidelines thing.
weeman1337
approved these changes
Jul 11, 2022
|
I don't know why sonarcloud isn't running on this PR, but I don't think it matters. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It'll be mildly annoying for core developers who have to constantly remove or edit this, but it'll also serve as a good reminder to do these things.
Note that signoff is not required for core developers.
See element-hq/element-web#22812
This change is marked as an internal change (Task), so will not be included in the changelog.