Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add a basic PR checklist for all PRs #9046

Merged
merged 2 commits into from
Jul 11, 2022
Merged

Add a basic PR checklist for all PRs #9046

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
362b6cb
Add a basic PR checklist for all PRs
turt2live Jul 11, 2022
256a522
*ahem*
turt2live Jul 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,21 @@
<!-- Please read https://github.com/matrix-org/matrix-js-sdk/blob/develop/CONTRIBUTING.md before submitting your pull request -->
<!-- Thanks for submitting a PR! Please ensure the following requirements are met in order for us to review your PR -->

<!-- Include a Sign-Off as described in https://github.com/matrix-org/matrix-js-sdk/blob/develop/CONTRIBUTING.md#sign-off -->
## Checklist

<!-- To specify text for the changelog entry (otherwise the PR title will be used):
Notes:
* [ ] Tests written for new code (and old code if feasible)
* [ ] Linter and other CI checks pass
* [ ] Sign-off given on the changes (see [CONTRIBUTING.md](https://github.com/matrix-org/matrix-react-sdk/blob/develop/CONTRIBUTING.md))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we ask for before/after screenshots for frontend affecting changes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but not in the checklist. That's a contributing guidelines thing.


Changes in this project generate changelog entries in element-web by default.
To suppress this:
<!--
If you would like to specify text for the changelog entry other than your PR title, add the following:

Notes: Add super cool feature

Changes in this project also generate changelogs in Element Web. To disable this, use the following:

element-web notes: none

...or to specify different notes:
element-web notes: <notes>
or specify alternative text:

element-web notes: Add super cool feature
-->