-
Notifications
You must be signed in to change notification settings - Fork 367
feat(threads): filter out notifications from threads we haven't subscribed to #5461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…eturn something more precise than unknown when fetching a subscription
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5461 +/- ##
==========================================
+ Coverage 88.89% 88.90% +0.01%
==========================================
Files 333 333
Lines 92121 92325 +204
Branches 92121 92325 +204
==========================================
+ Hits 81893 82084 +191
+ Misses 6393 6390 -3
- Partials 3835 3851 +16 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #5461 will not alter performanceComparing Summary
|
|
Closing: we don't need this, since the evaluation of push rules does it for us (duh! but now I know better about push rules). The only remaining interesting things have been / will be extracted to other PRs:
|
Based on #5455, this makes it possible to filter out notifications for a thread we haven't subscribed to.
The rules are the following:
Part of #4869.