Skip to content

Conversation

@bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Jul 29, 2025

Based on #5455, this makes it possible to filter out notifications for a thread we haven't subscribed to.

The rules are the following:

  • if the thread is subscribed to: keep the notification
  • if the thread has no subscription status:
    • if the new event would cause a subscription: keep the notification
    • if the new event wouldn't cause a subscription: dismiss the notification
  • if the thread is unsubscribed from: dismiss the notification

Part of #4869.

@codecov
Copy link

codecov bot commented Jul 29, 2025

Codecov Report

❌ Patch coverage is 88.18898% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.90%. Comparing base (1be8b42) to head (8f1177f).
⚠️ Report is 52 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/matrix-sdk-ui/src/notification_client.rs 82.14% 8 Missing and 7 partials ⚠️
crates/matrix-sdk-sqlite/src/state_store.rs 77.55% 2 Missing and 9 partials ⚠️
crates/matrix-sdk/src/room/mod.rs 88.46% 0 Missing and 3 partials ⚠️
crates/matrix-sdk-base/src/store/mod.rs 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5461      +/-   ##
==========================================
+ Coverage   88.89%   88.90%   +0.01%     
==========================================
  Files         333      333              
  Lines       92121    92325     +204     
  Branches    92121    92325     +204     
==========================================
+ Hits        81893    82084     +191     
+ Misses       6393     6390       -3     
- Partials     3835     3851      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 29, 2025

CodSpeed Performance Report

Merging #5461 will not alter performance

Comparing bnjbvr/client-mode-thread-subs (8f1177f) with main (8091094)

Summary

✅ 6 untouched benchmarks

@bnjbvr
Copy link
Member Author

bnjbvr commented Aug 6, 2025

Closing: we don't need this, since the evaluation of push rules does it for us (duh! but now I know better about push rules).

The only remaining interesting things have been / will be extracted to other PRs:

@bnjbvr bnjbvr closed this Aug 6, 2025
@bnjbvr bnjbvr deleted the bnjbvr/client-mode-thread-subs branch August 6, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants