Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC3282: Expose enable_set_displayname in capabilities response #3282

Closed
wants to merge 5 commits into from
Closed

MSC3282: Expose enable_set_displayname in capabilities response #3282

wants to merge 5 commits into from

Conversation

JonasKress
Copy link
Contributor

JonasKress and others added 4 commits July 13, 2021 12:12
@JonasKress
Create 3278-enable_set_displayname-capabilities.md
e04ae30
@JonasKress @KitsuneRal
Apply suggestions from code review
0fd7c94 
Co-authored-by: Alexey Rusakov <Kitsune-Ral@users.sf.net>
@JonasKress @KitsuneRal
Apply suggestions from code review
c711706 
Co-authored-by: Alexey Rusakov <Kitsune-Ral@users.sf.net>
@JonasKress
Update and rename 3278-enable_set_displayname-capabilities.md to 3279…
7291992 
…-enable_set_displayname-capabilities.md
@JonasKress JonasKress mentioned this pull request Jul 13, 2021
Closed
@JonasKress JonasKress added client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff proposal A matrix spec change proposal labels Jul 13, 2021
uhoreg
uhoreg reviewed Jul 13, 2021
View reviewed changes
proposals/3279-enable_set_displayname-capabilities.md Outdated
@@ -0,0 +1,25 @@
# MSC3279: Expose enable_set_displayname in capabilities response
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But now this is MSC3282

@JonasKress JonasKress closed this Jul 13, 2021
@JonasKress JonasKress deleted the JonasKress/msc3279 branch July 13, 2021 17:33
@turt2live turt2live added the obsolete A proposal which has been overtaken by other proposals label Jul 13, 2021
@turt2live turt2live changed the title MSC3279: Expose enable_set_displayname in capabilities response MSC3282: Expose enable_set_displayname in capabilities response Jul 13, 2021
bmarty
bmarty reviewed Jul 19, 2021
View reviewed changes
proposals/3282-enable_set_displayname-capabilities.md
```javascript
{
"capabilities": {
"m.enable_set_displayname": false,
Copy link

@bmarty bmarty Jul 19, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, I think that can_set_displayname is a better name from a client point of view.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is not up to date. The current PR is: #3283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dklimpel dklimpel dklimpel left review comments

@bmarty bmarty bmarty left review comments

@uhoreg uhoreg uhoreg left review comments

Assignees
No one assigned
Labels
client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff obsolete A proposal which has been overtaken by other proposals proposal A matrix spec change proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JonasKress @uhoreg @bmarty @dklimpel @turt2live