Remove aliases
from /publicRooms
response
#3624
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is pointing at the Spaces branch to have a readable diff. This will be changed tomain
prior to merging, which is dependent on #3610Fixes #3056
Through attempting to land Synapse#11667 it was found that Synapse doesn't return the
aliases
property on/publicRooms
as it was removed by a tracking issue referencing MSC2432 as its base. Though MSC2432 does not make mention of this, the document the MSC is based upon makes deliberate effort to mention the endpoint and the removal ofaliases
. Thus, it is determined as a likely accidental omission from the formal MSC and therefore the formal spec.This has been corrected here by amending the MSC (per the process) and removing the field, basing itself off of the spec PR for spaces for diff clarity.
Preview: https://pr3624--matrix-org-previews.netlify.app