Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove aliases from /publicRooms response #3624

Merged
merged 2 commits into from
Jan 18, 2022
Merged

Remove aliases from /publicRooms response #3624

merged 2 commits into from
Jan 18, 2022

Commits on Jan 17, 2022

  1. Remove aliases from /publicRooms response 

    Through attempting to land [Synapse#11667](matrix-org/synapse#11667) it was found that Synapse doesn't return the `aliases` property on `/publicRooms` as it was [removed](matrix-org/synapse#6970) by a [tracking issue](matrix-org/synapse#6898) referencing [MSC2432](#2432) as its base. Though MSC2432 does not make mention of this, the [document](https://docs.google.com/document/d/1NNDkobiFLeUkJtyj0H6qvKIedgvIkZnFKo78-03cGEk/edit) the MSC is based upon makes deliberate effort to mention the endpoint and the removal of `aliases`. Thus, it is determined as a likely accidental omission from the formal MSC and therefore the formal spec.

This has been corrected here by amending the MSC (per the process) and removing the field, basing itself off of the [spec PR for spaces](#3610) for diff clarity.
    @turt2live
    turt2live committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    e5509f5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into travis/remove-aliases-publicrooms

    @turt2live
    turt2live committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    3d083cb View commit details
    Browse the repository at this point in the history