Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC3980: Dotted Field Consistency #3980

Merged
merged 2 commits into from
Apr 2, 2023
Merged

MSC3980: Dotted Field Consistency #3980

merged 2 commits into from
Apr 2, 2023

Conversation

clokep
Copy link
Member

@clokep clokep commented Mar 15, 2023 •
edited
Loading

@clokep clokep mentioned this pull request Mar 15, 2023
Merged
@clokep clokep marked this pull request as ready for review March 15, 2023 18:15
@turt2live turt2live added push proposal A matrix spec change proposal client-server Client-Server API kind:maintenance MSC which clarifies/updates existing spec needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. and removed needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Mar 15, 2023
@turt2live
Copy link
Member

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Mar 15, 2023 •
edited by richvdh
Loading

Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people:

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. disposition-merge labels Mar 15, 2023
@clokep @turt2live
Update proposals/3980-dotted-fields-consistency.md
59a8077 
Co-authored-by: Travis Ralston <travisr@matrix.org>
anoadragon453
anoadragon453 approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After having a quick browse through the spec, I see no other inconsistencies with backslash handling :)

@mscbot
Copy link
Collaborator

mscbot commented Mar 28, 2023

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Mar 28, 2023
@mscbot
Copy link
Collaborator

mscbot commented Apr 2, 2023

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Apr 2, 2023
@uhoreg uhoreg merged commit bf8a50c into main Apr 2, 2023
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Apr 2, 2023
@turt2live
Copy link
Member

Spec PR: matrix-org/matrix-spec#1464

@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Apr 3, 2023
@turt2live
Copy link
Member

Merged 🎉

@turt2live turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Apr 4, 2023
This was referenced Apr 7, 2023
Merged
Closed
@turt2live
Copy link
Member

Better late than never: we didn't require an implemention on this because the MSC is effectively self-referencing. That's to say it's so trivial that a formal PR/deployment with the MSC's behaviour wouldn't prove anything we don't already know, so the MSC simply existing acts as "implementation".

We talked about it in a public room somewhere (#matrix-spec I think?) stating this.

@clokep clokep mentioned this pull request May 16, 2023
Merged
@clokep clokep deleted the clokep/dotted-consistency branch May 17, 2023 12:18
@S7evinK S7evinK mentioned this pull request Oct 2, 2023
Open
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live left review comments

@anoadragon453 anoadragon453 anoadragon453 approved these changes

Assignees

@clokep clokep

Labels
client-server Client-Server API kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal push
Projects
Spec Core Team Backlog
Status: Done to some definition
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@clokep @turt2live @mscbot @anoadragon453 @uhoreg