Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document MSC3758, MSC3966, MSC3873, and MSC3980. #1464

Merged
merged 11 commits into from
Apr 4, 2023

Conversation

clokep
Copy link
Member

@clokep clokep commented Mar 14, 2023

This documents the new push rule conditions:

As well as the dotted-path escape rules from MSC3873 and MSC3980.

Based on #1461.

Preview: https://pr1464--matrix-spec-previews.netlify.app

@clokep clokep force-pushed the clokep/more-push-rule-conditions branch from 8ed2b79 to 4cd7faf Compare March 14, 2023 15:05
@clokep clokep marked this pull request as ready for review March 14, 2023 15:05
@clokep clokep requested a review from a team as a code owner March 14, 2023 15:05
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, and I appreciate your clear wording.

A few bits and bobs to fix up, and a leading question.

content/client-server-api/modules/push.md Outdated Show resolved Hide resolved
content/client-server-api/modules/push.md Outdated Show resolved Hide resolved
content/appendices.md Outdated Show resolved Hide resolved
content/appendices.md Outdated Show resolved Hide resolved
content/appendices.md Outdated Show resolved Hide resolved
changelogs/client_server/newsfragments/1464.clarification Outdated Show resolved Hide resolved
data/api/client-server/definitions/sync_filter.yaml Outdated Show resolved Hide resolved
clokep and others added 5 commits March 14, 2023 12:36
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
@clokep clokep changed the title Document MSC3758, MSC3966, and MSC3873. Document MSC3758, MSC3966, MSC3873, and MSC3980. Mar 28, 2023
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes LGTM. Thanks!

@turt2live
Copy link
Member

/me performs ceremony to merge

@turt2live turt2live merged commit d222fc6 into matrix-org:main Apr 4, 2023
clokep added a commit to clokep/matrix-spec that referenced this pull request May 3, 2023
* Add information on MSC3758: event_property_is.

* Add information on MSC3966: event_property_contains.

* Add information on MSC3873 dotted-path escape rules.

* Newsfragment

* Update sync filter with ref to appendix.

* Escape example key.

* Fix typos.

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>

* Fix links.

* Clarify the appendix a bit.

* Clarify support values.

* Add MSC3980 to changelog.

---------

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
@clokep clokep deleted the clokep/more-push-rule-conditions branch June 12, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants