Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[panctl] fails to accept passwords with spaces #138

Closed
rmNULL opened this issue Sep 18, 2022 · 1 comment
Closed

[panctl] fails to accept passwords with spaces #138

rmNULL opened this issue Sep 18, 2022 · 1 comment

Comments

@rmNULL
Copy link

rmNULL commented Sep 18, 2022

Describe the bug
When Passing passphrase to import-keys only the first
word is taken. This also happens with export-keys
passphrase.

To Reproduce
Steps to reproduce the behavior:

  • panctl
  • import-keys username /tmp/path-to-key a lengthy password

Error: unrecognized arguments: lengthy password' (see help)

Expected behavior
The whole password should be considered.
It doesn't work with quotes too.

Screenshots
#1663490039-scap

Desktop (please complete the following information):

  • OS: GNU/Linux 5.18.9_1
  • Browser: N/A
  • Version: panctl 0.10.4

Smartphone (please complete the following information):

  • Device: N/A
  • OS: N/A
  • Browser N/A
  • Version N/A

Additional context
I suspect this issue is caused by result.split() before passing the line to parser.
I was thinking maybe we could handle quoted input like shell
does and perform split based on that rather than just
spaces. I'm willing to perform these changes, but wanted
to get a go signal before taking up this task.

chookity-pokk added a commit that referenced this issue Dec 5, 2024
Issue #138: Using shlex.split instead str.split
@chookity-pokk
Copy link
Collaborator

This is fixed with #185

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants