Issue #138: Using shlex.split instead str.split #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NevroHelios Thanks for this PR! Though quickly looking at the shlex documentation we probably want it to have |
|
Yes, setting posix=False when using shlex.split can help ensure compatibility with non-POSIX shells like Fish. So should I create a new pull request? |
No need to make a new PR, just push a commit to this one and it should be good to go. |
|
@chookity-pokk , I made the change and updated the PR. |
|
@NevroHelios Thanks for the PR! It has been merged now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have used the shlex.split function which correctly handles quoted strings, ensuring that the entire passphrase is treated as a single argument.