Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DINUM] Validate client_secret parameter according to the spec #245

Merged
merged 2 commits into from
Jan 24, 2020
Merged

[DINUM] Validate client_secret parameter according to the spec #245

merged 2 commits into from
Jan 24, 2020

Conversation

anoadragon453
Copy link
Member

@anoadragon453 anoadragon453 commented Jan 22, 2020 •
edited
Loading

According to the spec, client_secret should follow the regex [0-9a-zA-Z.=_-].

This PR asserts that.

CI is expected to fail as unit tests nor matrix-is-tester are on the dinsic branch yet :/

@anoadragon453 anoadragon453 requested a review from a team January 22, 2020 17:12
@anoadragon453 anoadragon453 self-assigned this Jan 22, 2020
@anoadragon453 anoadragon453 removed the request for review from a team January 22, 2020 17:12
@anoadragon453 anoadragon453 mentioned this pull request Jan 22, 2020
Merged
@anoadragon453 anoadragon453 changed the title Validate client_secret parameter according to the spec [DINUM] Validate client_secret parameter according to the spec Jan 22, 2020
@anoadragon453 anoadragon453 requested a review from a team January 23, 2020 13:46
erikjohnston
erikjohnston approved these changes Jan 24, 2020
View reviewed changes
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming we're happy that dinum clients are doing the right thing?

@anoadragon453
Copy link
Member Author

I'm assuming we're happy that dinum clients are doing the right thing?

Tchap seems to use the same algorithm as Riot, aka using UUIDs (abcde-fghijk-...).

@anoadragon453 anoadragon453 merged commit b1148b4 into dinsic Jan 24, 2020
@anoadragon453 anoadragon453 deleted the anoa/client_secret_regex branch January 24, 2020 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikjohnston erikjohnston erikjohnston approved these changes

Assignees

@anoadragon453 anoadragon453

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anoadragon453 @erikjohnston