Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate client_secret parameter according to spec #246

Merged
merged 2 commits into from
Jan 24, 2020
Merged

Validate client_secret parameter according to spec #246

merged 2 commits into from
Jan 24, 2020

Conversation

anoadragon453
Copy link
Member

@anoadragon453 anoadragon453 commented Jan 22, 2020 •
edited
Loading

According to the spec, client_secret should follow the regex [0-9a-zA-Z.=_-].

This PR asserts that, with the exception of adding the : character. See #246 for details.

This is a port of #245 to mainline.

@anoadragon453 anoadragon453 requested a review from a team January 22, 2020 17:26
@anoadragon453 anoadragon453 self-assigned this Jan 22, 2020
@anoadragon453 anoadragon453 mentioned this pull request Jan 22, 2020
Closed
erikjohnston
erikjohnston reviewed Jan 24, 2020
View reviewed changes
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to also support : for fluffy chat?

@anoadragon453
Copy link
Member Author

Don't we need to also support : for fluffy chat?

Yes... yes it does.

@anoadragon453 anoadragon453 merged commit 7a49644 into master Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikjohnston erikjohnston erikjohnston approved these changes

Assignees

@anoadragon453 anoadragon453

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anoadragon453 @erikjohnston