Convert ConfigParser object to dict and prevent #287 #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 17, 2021
added 8 commits
September 20, 2021 16:00
SydentConfigParser is needed as previously only 2 of the config
options did not get interpolated (i.e. people could have been running
sydent with a config who's options referenced other options)
Using a dict means that knowledge of Python's configparser library's
get() method is no longer needed (which has a second argument which
is not the fallback).
The next step is to make having an option set to an empty string
the same as not setting it.
If the config has: option1 = then get(option1) or None would be None rather than "". So to preserve the meaning of "fallback" from ConfigParser it should be get(option1, None)
Azrenbeth
force-pushed
the
azren/dict_not_configparser
branch
from
8cacad3
to
2526e86
Compare
added 2 commits
September 20, 2021 16:15
|
Note that since @Azrenbeth has finished his internship with us it's likely someone else will have to take this over. |
|
Removing review since this depends on #401. If we want to merge this we'll need to dust that off first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #401. Followed by #404
Convert ConfigParser object to dict and prevent #287. Things no longer go into [DEFAULT] when the config file is generated (this is applying the fix mentioned in #314). Note that since the user's file is read after the CONFIG_DEFAULTS dict is looked at, placing them in [DEFAULT] or not has no affect on the running of the code, it only affects the generated config file.
SydentConfigParser is needed as previously only 2 of the config
options did not get interpolated (i.e. people could have been running
sydent with a config who's options referenced other options)
Using a dict means that knowledge of Python's configparser library's
get() method is no longer needed (which has a second argument which
is not the fallback).