-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generate-config script and document config options #404
Open
Azrenbeth
wants to merge
16
commits into
azren/dict_not_configparser
Choose a base branch
from
azren/gnerate_config_and_document
base: azren/dict_not_configparser
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add generate-config script and document config options #404
Azrenbeth
wants to merge
16
commits into
azren/dict_not_configparser
from
azren/gnerate_config_and_document
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 20, 2021
prevents circular import
Azrenbeth
force-pushed
the
azren/gnerate_config_and_document
branch
from
September 20, 2021 15:07
d47be64
to
7d29f6c
Compare
Note that since @Azrenbeth has finished his internship with us it's likely someone else will have to take this over. |
I'm removing review on this since it depends on #402, which is a sizeable PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #402. Fixes #101.
Stop using CONFIG_DEFAULTS dictionary
config.get(option, default_value)
docs/configuration.md
)Stop generating config file on first run of Sydent. For reasons brought up in #401. This will not affect people with existing config files, only new installers.
generate-config
script that creates a minimal config.docs/example_config.conf
)Not sure if I did the correct thing:
--pid-file
argument) with the environment variables taking precedence. But if the user's config file does not have a value set, then the environment variable is used.An alternative would have been to require those values to be set by the config file.