Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tox settings for easier use & better performance #193

Merged
merged 7 commits into from
Apr 1, 2021

Conversation

aitorres
Copy link
Contributor

What's changed

This PR updates Tox's settings in order to:

CONTRIBUTING.md was also updated to remove references to the lint.sh script, which was removed, and replace its usage with tox in order to achieve the same effects.

Two entries were added to the changelog, for doc and misc changes.

Solved issues

Closes #189 if merged.
Closes #191 if merged.

Signed-off-by: Andrés Ignacio Torres <andresitorresm@gmail.com>
…trix-org#191)

Signed-off-by: Andrés Ignacio Torres <andresitorresm@gmail.com>
…rix-org#191)

Signed-off-by: Andrés Ignacio Torres <andresitorresm@gmail.com>
Signed-off-by: Andrés Ignacio Torres <andresitorresm@gmail.com>
Signed-off-by: Andrés Ignacio Torres <andresitorresm@gmail.com>
@clokep clokep requested a review from a team March 30, 2021 10:59
Copy link
Contributor

@callahad callahad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for the contribution! Two very small nits and then it should be good to merge.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
…checking

Signed-off-by: Andrés Ignacio Torres <andresitorresm@gmail.com>
@aitorres
Copy link
Contributor Author

aitorres commented Mar 30, 2021

All done! Those two things flew past my radar 😅 fixed now.

By the way, not sure if this is the most appropriate place for this: I would like to start contributing to Matrix in general with some frequency, but don't know what's the best way to start. Is there any public, central hub / channel for contributors to communicate?

Edit: Found the rooms on Matrix :-)

@aitorres aitorres requested a review from callahad March 30, 2021 16:08
CONTRIBUTING.md Outdated Show resolved Hide resolved
@callahad
Copy link
Contributor

By the way, not sure if this is the most appropriate place for this: I would like to start contributing to Matrix in general with some frequency, but don't know what's the best way to start. Is there any public, central hub / channel for contributors to communicate?

Edit: Found the rooms on Matrix :-)

Oh yay! Please do poke around, get a feel for how Matrix works as a platform, etc. and feel free to ask us any questions you might have. I'm usually in the Synapse Dev and Sygnal rooms.

Signed-off-by: Andrés Ignacio Torres <andresitorresm@gmail.com>
@aitorres aitorres requested a review from callahad April 1, 2021 04:39
Copy link
Contributor

@callahad callahad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray! Thank you so much.

@callahad callahad merged commit ae797c7 into matrix-org:master Apr 1, 2021
@aitorres aitorres deleted the feature/tox-improvements branch April 1, 2021 05:32
awesome-michael added a commit to Awesome-Technologies/sygnal that referenced this pull request May 6, 2021
Sygnal 0.9.3 (2021-04-22)
=========================

Features
--------

- Prevent the push key from being rejected for temporary errors and oversized payloads, add TTL logging, and support `events_only` push data flag. ([\matrix-org#212](matrix-org#212))
- WebPush: add support for Urgency and Topic header ([\matrix-org#213](matrix-org#213))

Bugfixes
--------

- Fix a long-standing bug where invalid JSON would be accepted over the HTTP interfaces. ([\matrix-org#216](matrix-org#216))
- Limit the size of requests received from HTTP clients. ([\matrix-org#220](matrix-org#220))

Updates to the Docker image
---------------------------

- Remove manually added GeoTrust Root CA certificate from docker image as Apple is no longer using it. ([\matrix-org#208](matrix-org#208))

Improved Documentation
----------------------

- Make `CONTIBUTING.md` more explicit about how to get tests passing. ([\matrix-org#188](matrix-org#188))
- Update `CONTRIBUTING.md` to specify how to run code style and type checks with Tox, and add formatting to code block samples. ([\matrix-org#193](matrix-org#193))
- Document how to work around pip installation timeout errors. Contributed by Omar Mohamed. ([\matrix-org#215](matrix-org#215))

Internal Changes
----------------

- Update Tox to run in the installed version of Python (instead of specifying Python 3.7) and to consider specific paths and folders while running checks, instead of the whole repository (potentially including unwanted files and folders, e.g. the virtual environment). ([\matrix-org#193](matrix-org#193))
- Make development dependencies available as extras. Contributed by Hillery Shay. ([\matrix-org#194](matrix-org#194))
- Update `setup.py` to specify that a minimum version of Python greater or equal to 3.7 is required. Contributed by Tawanda Moyo. ([\matrix-org#207](matrix-org#207))
- Port CI checks to Github Actions. ([\matrix-org#210](matrix-org#210), [\matrix-org#219](matrix-org#219))
- Upgrade development dependencies. Contributed by Omar Mohamed ([\matrix-org#214](matrix-org#214))
- Set up `coverage.py` to run in tox environment, and add html reports ([\matrix-org#217](matrix-org#217))

Change-Id: I14ae821ff2a1562e91fd87ce25f73baaa0b9430b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants