Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade development dependencies #199 #214

Merged
merged 6 commits into from
Apr 9, 2021
Merged

Upgrade development dependencies #199 #214

merged 6 commits into from
Apr 9, 2021

Conversation

kibablu
Copy link
Contributor

@kibablu kibablu commented Apr 9, 2021

Upgrade development dependencies (#199)

upgrade dependencies in setup.py

fixes #199

upgrade black to the latest version

fixes #199

Signed-off-by: Omar Mohamed <kibablu16@gmail.com>
upgrade flake8 to the latest version

fixes #199

Signed-off-by: Omar Mohamed <kibablu16@gmail.com>
upgrade mypy to the latest version

fixes #199

Signed-off-by: Omar Mohamed <kibablu16@gmail.com>
upgrade mypy-zope to the latest version

fixes #199

Signed-off-by: Omar Mohamed <kibablu16@gmail.com>
Signed-off-by: Omar Mohamed <kibablu16@gmail.com>
@clokep clokep requested review from a team and removed request for a team April 9, 2021 13:00
Copy link
Contributor

@callahad callahad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we also need to run black on the tests/ directory (see logs at https://buildkite.com/matrix-dot-org/sygnal/builds/548#1770db00-bf3e-4c60-b9ef-72f0b8418ace/133-150 for more info)

fixes codestyle by running black on tests/ directory

fixes #199

Signed-off-by: Omar Mohamed <kibablu16@gmail.com>
@callahad
Copy link
Contributor

callahad commented Apr 9, 2021

Looks good! Thank you for doing this :)

@callahad
Copy link
Contributor

callahad commented Apr 9, 2021

(I honestly expected black to make more changes than it did 😆)

@callahad callahad merged commit 75ee260 into matrix-org:master Apr 9, 2021
@kibablu
Copy link
Contributor Author

kibablu commented Apr 9, 2021

Looks good! Thank you for doing this :)

Thank you also, learning a lot here 😃

@kibablu kibablu deleted the upgrade_dependencies branch April 9, 2021 15:04
@kibablu kibablu restored the upgrade_dependencies branch April 9, 2021 15:06
@kibablu kibablu deleted the upgrade_dependencies branch April 12, 2021 12:24
awesome-michael added a commit to Awesome-Technologies/sygnal that referenced this pull request May 6, 2021
Sygnal 0.9.3 (2021-04-22)
=========================

Features
--------

- Prevent the push key from being rejected for temporary errors and oversized payloads, add TTL logging, and support `events_only` push data flag. ([\matrix-org#212](matrix-org#212))
- WebPush: add support for Urgency and Topic header ([\matrix-org#213](matrix-org#213))

Bugfixes
--------

- Fix a long-standing bug where invalid JSON would be accepted over the HTTP interfaces. ([\matrix-org#216](matrix-org#216))
- Limit the size of requests received from HTTP clients. ([\matrix-org#220](matrix-org#220))

Updates to the Docker image
---------------------------

- Remove manually added GeoTrust Root CA certificate from docker image as Apple is no longer using it. ([\matrix-org#208](matrix-org#208))

Improved Documentation
----------------------

- Make `CONTIBUTING.md` more explicit about how to get tests passing. ([\matrix-org#188](matrix-org#188))
- Update `CONTRIBUTING.md` to specify how to run code style and type checks with Tox, and add formatting to code block samples. ([\matrix-org#193](matrix-org#193))
- Document how to work around pip installation timeout errors. Contributed by Omar Mohamed. ([\matrix-org#215](matrix-org#215))

Internal Changes
----------------

- Update Tox to run in the installed version of Python (instead of specifying Python 3.7) and to consider specific paths and folders while running checks, instead of the whole repository (potentially including unwanted files and folders, e.g. the virtual environment). ([\matrix-org#193](matrix-org#193))
- Make development dependencies available as extras. Contributed by Hillery Shay. ([\matrix-org#194](matrix-org#194))
- Update `setup.py` to specify that a minimum version of Python greater or equal to 3.7 is required. Contributed by Tawanda Moyo. ([\matrix-org#207](matrix-org#207))
- Port CI checks to Github Actions. ([\matrix-org#210](matrix-org#210), [\matrix-org#219](matrix-org#219))
- Upgrade development dependencies. Contributed by Omar Mohamed ([\matrix-org#214](matrix-org#214))
- Set up `coverage.py` to run in tox environment, and add html reports ([\matrix-org#217](matrix-org#217))

Change-Id: I14ae821ff2a1562e91fd87ce25f73baaa0b9430b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade development dependencies
2 participants