This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fix specifying cache factors via env vars with * in name. #7580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mostly applise to `*stateGroupCache*` and co. Broke in #6391.
anoadragon453
suggested changes
May 27, 2020
There was a problem hiding this comment.
Good catch, thanks. I think we may want to update the config comment to explain how cache names are normalised.
synapse/synapse/config/cache.py
Line 127 in d18245b
…erikj/canonical_cache_name
anoadragon453
approved these changes
May 27, 2020
| # alphanumeric or underscores. These caches can be named with or | ||
| # without the special characters stripped. For example, to specify | ||
| # the cache factor for `*stateGroupCache*` via an environment | ||
| # variable would be `SYNAPSE_CACHE_FACTOR_STATEGROUPCACHE=2`. |
There was a problem hiding this comment.
I may put a 2.0 here instead to keep it in line with the other example, but up to you.
clokep
reviewed
May 27, 2020
|
|
||
| Since we specify cache names in config and environment variables we need to | ||
| ignore case and special characters. For example, some caches have asterisks | ||
| in their name to donate that they're not attached to a particular database |
There was a problem hiding this comment.
Suggested change
| in their name to donate that they're not attached to a particular database | |
| in their name to denote that they're not attached to a particular database |
There was a problem hiding this comment.
Whoops, didn't see this before merge. I fixed it directly.
babolivier
added a commit
that referenced
this pull request
May 27, 2020
Synapse 1.14.0rc2 (2020-05-27) ============================== Bugfixes -------- - Fix cache config to not apply cache factor to event cache. Regression in v1.14.0rc1. ([\#7578](#7578)) - Fix bug where `ReplicationStreamer` was not always started when replication was enabled. Bug introduced in v1.14.0rc1. ([\#7579](#7579)) - Fix specifying individual cache factors for caches with special characters in their name. Regression in v1.14.0rc1. ([\#7580](#7580)) Improved Documentation ---------------------- - Fix the OIDC `client_auth_method` value in the sample config. ([\#7581](#7581))
phil-flex
pushed a commit
to phil-flex/synapse
that referenced
this pull request
Jun 16, 2020
…#7580) This mostly applise to `*stateGroupCache*` and co. Broke in matrix-org#6391.
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
…dinsic-release-v1.14.x * 'release-v1.14.0' of github.com:matrix-org/synapse: (108 commits) Fix typo in PR link Update debian changelog 1.14.0 Improve changelog wording 1.14.0rc2 Fix sample config docs error (#7581) Fix up comments Fix specifying cache factors via env vars with * in name. (#7580) Don't apply cache factor to event cache. (#7578) Ensure ReplicationStreamer is always started when replication enabled. (#7579) Remove the changes to the debian changelog Not full release yet, this is rc1 Merge event persistence move changelog entries More changelog fix Changelog fixes 1.14.0 Replace device_27_unique_idx bg update with a fg one (#7562) Fix incorrect exception handling in KeyUploadServlet.on_POST (#7563) Fix recording of federation stream token (#7564) Simplify reap_monthly_active_users (#7558) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly applise to
*stateGroupCache*and co.Broke in #6391.