Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Ensure ReplicationStreamer is always started when replication enabled. #7579

Merged
merged 2 commits into from
May 27, 2020
Merged

Ensure ReplicationStreamer is always started when replication enabled. #7579

merged 2 commits into from
May 27, 2020

Conversation

erikjohnston
Copy link
Member

Fixes #7566.

@erikjohnston erikjohnston requested a review from a team May 27, 2020 09:40
anoadragon453
anoadragon453 approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's slightly confusing that redis replication is started by ...replication/tcp/handler.py. I first thought you put this in the wrong file :)

@erikjohnston erikjohnston merged commit 9bac5d6 into release-v1.14.0 May 27, 2020
@erikjohnston erikjohnston deleted the erikj/dont_require_listener branch May 27, 2020 10:44
@clokep clokep mentioned this pull request May 27, 2020
Closed
babolivier added a commit that referenced this pull request May 27, 2020
@babolivier
Merge tag 'v1.14.0rc2' into develop
5af572a 
Synapse 1.14.0rc2 (2020-05-27)
==============================

Bugfixes
--------

- Fix cache config to not apply cache factor to event cache. Regression in v1.14.0rc1. ([\#7578](#7578))
- Fix bug where `ReplicationStreamer` was not always started when replication was enabled. Bug introduced in v1.14.0rc1. ([\#7579](#7579))
- Fix specifying individual cache factors for caches with special characters in their name. Regression in v1.14.0rc1. ([\#7580](#7580))

Improved Documentation
----------------------

- Fix the OIDC `client_auth_method` value in the sample config. ([\#7581](#7581))
phil-flex pushed a commit to phil-flex/synapse that referenced this pull request Jun 16, 2020
@erikjohnston @phil-flex
Ensure ReplicationStreamer is always started when replication enabled. (
8edacc9 
matrix-org#7579)

Fixes matrix-org#7566.
babolivier pushed a commit that referenced this pull request Sep 1, 2021
@anoadragon453
Merge branch 'release-v1.14.0' of github.com:matrix-org/synapse into …
cde3bda 
…dinsic-release-v1.14.x

* 'release-v1.14.0' of github.com:matrix-org/synapse: (108 commits)
  Fix typo in PR link
  Update debian changelog
  1.14.0
  Improve changelog wording
  1.14.0rc2
  Fix sample config docs error (#7581)
  Fix up comments
  Fix specifying cache factors via env vars with * in name. (#7580)
  Don't apply cache factor to event cache. (#7578)
  Ensure ReplicationStreamer is always started when replication enabled. (#7579)
  Remove the changes to the debian changelog
  Not full release yet, this is rc1
  Merge event persistence move changelog entries
  More changelog fix
  Changelog fixes
  1.14.0
  Replace device_27_unique_idx bg update with a fg one (#7562)
  Fix incorrect exception handling in KeyUploadServlet.on_POST (#7563)
  Fix recording of federation stream token (#7564)
  Simplify reap_monthly_active_users (#7558)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anoadragon453 anoadragon453 anoadragon453 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikjohnston @anoadragon453