Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

master doesn't send replication traffic unless you have a TCP replication listener #7566

Closed
richvdh opened this issue May 23, 2020 · 1 comment
Closed

master doesn't send replication traffic unless you have a TCP replication listener #7566

richvdh opened this issue May 23, 2020 · 1 comment
Assignees
@erikjohnston
Labels
z-bug (Deprecated Label)

Comments

@richvdh
Copy link
Member

richvdh commented May 23, 2020

the TCP replication listener is unused if you have redis, so you'd expect to be able to remove it (indeed, the docs say that you can). But if you do that, nothing builds the ReplicationStreamer, so no replication traffic ever gets sent.
@anoadragon453 anoadragon453 added z-bug (Deprecated Label) p1 labels May 26, 2020
erikjohnston added a commit that referenced this issue May 27, 2020
@erikjohnston
Ensure ReplicationStreamer is always started when replication enabled.
85363fd 
Fixes #7566.
@erikjohnston erikjohnston mentioned this issue May 27, 2020
Merged
erikjohnston added a commit that referenced this issue May 27, 2020
@erikjohnston
Ensure ReplicationStreamer is always started when replication enabled. (
9bac5d6 
#7579)

Fixes #7566.
@clokep
Copy link
Member

clokep commented May 27, 2020

Looks like this will be fixed for 1.14 from #7579. Closing this.

@clokep clokep closed this as completed May 27, 2020
phil-flex pushed a commit to phil-flex/synapse that referenced this issue Jun 16, 2020
@erikjohnston @phil-flex
Ensure ReplicationStreamer is always started when replication enabled. (
8edacc9 
matrix-org#7579)

Fixes matrix-org#7566.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@erikjohnston erikjohnston

Labels
z-bug (Deprecated Label)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@clokep @anoadragon453 @richvdh @erikjohnston