Can paginate public room list is flaky

[richvdh]

https://github.com/matrix-org/synapse/pull/9981/checks?check_run_id=2582973111

[richvdh]

and https://buildkite.com/matrix-dot-org/synapse/builds/17339#650a0408-a6ac-4d1b-8823-b26e43d0a379

[clokep]

And https://github.com/matrix-org/synapse/pull/10574/checks?check_run_id=3293529951

[richvdh]

and https://github.com/matrix-org/sytest/pull/1149/checks?check_run_id=3817819072

[DMRobertson]

and https://github.com/matrix-org/synapse/runs/3826760651?check_suite_focus=true

[DMRobertson]

Reproducing it locally with

docker run --rm -v /home/dmr/workspace/synapse:/src:ro -v /home/dmr/workspace/sytest/:/sytest -v /tmp/logs:/logs -e POSTGRES=1 -e WORKERS=1 -e MULTI_POSTGRES=1 matrixdotorg/sytest-synapse:testing --torture-replication 100 -s tests/30rooms/70publicroomslist.pl

[DMRobertson]

This showed up twice today.

https://github.com/matrix-org/sytest/runs/4091934326?check_suite_focus=true
https://github.com/matrix-org/sytest/runs/4091934326?check_suite_focus=true

both in #1116. I couldn't see any changes there or in the linked Synapse branch which would explain this.

[ShadowJonathan]

Another run in https://github.com/matrix-org/synapse/runs/4447433909?check_suite_focus=true

[clokep]

Seen again: https://github.com/matrix-org/synapse/runs/4805751717

[clokep]

https://github.com/matrix-org/synapse/runs/5160171515?check_suite_focus=true

[clokep]

https://github.com/matrix-org/synapse/runs/5199772896?check_suite_focus=true

[DMRobertson]

https://github.com/matrix-org/synapse/runs/6076311915?check_suite_focus=true

[DMRobertson]

https://github.com/matrix-org/synapse/runs/6193058369?check_suite_focus=true

[clokep]

And https://github.com/matrix-org/synapse/runs/6287201691?check_suite_focus=true

[DMRobertson]

https://github.com/matrix-org/synapse/runs/6346842207?check_suite_focus=true

[DMRobertson]

https://github.com/matrix-org/synapse/runs/6739724836?check_suite_focus=true

[DMRobertson]

https://github.com/matrix-org/synapse/runs/6899135826?check_suite_focus=true

[richvdh]

https://github.com/matrix-org/synapse/runs/6932637886?check_suite_focus=true

[richvdh]

Pretty sure this is just timing out. It creates 10 rooms, which takes 10 seconds, which is the default test timeout.

See also matrix-org/synapse#6068