-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check that master key is returned when querying device for first time #1166
Conversation
There seem to be a mix of tabs vs. spaces going on here. |
WHY WOULD YOU DO THIS TO ME VIM WHY 😭 |
lib/SyTest/Homeserver.pm
Outdated
@@ -241,7 +241,7 @@ sub configure_logger | |||
|
|||
loggers => { | |||
synapse => { | |||
level => "INFO" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this just for temporary debugging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh blast, I carefully didn't add this, and then clearly did a git commit -a
.
https://github.com/matrix-org/sytest/runs/4091934296?check_suite_focus=true Looks like #1164. Edit: yes, it does. Bugger. https://github.com/matrix-org/sytest/runs/4091934438?check_suite_focus=true failed to install dendrite. |
/me waits to see how else he has messed up this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable; one question
assert_json_keys( $content->{master_keys}, $user2_id ); | ||
assert_json_keys( $content->{master_keys}->{$user2_id}, "keys"); | ||
assert_json_keys( $content->{master_keys}->{$user2_id}{keys}, | ||
"ed25519:nqOvzeuGWT/sRx3h7+MHoInYj3Uk2LD/unI9kDYcHwk"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also expect to see this in the second call to matrix_get_e2e_keys on +685?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we should. I suppose its worth checking that its still there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
See matrix-org/synapse#11234