Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming to CSP where appropriate, and other related things #75

Merged
merged 11 commits into from
Oct 29, 2024
Merged

Renaming to CSP where appropriate, and other related things #75

merged 11 commits into from
Oct 29, 2024

Conversation

matsen
Copy link
Contributor

@matsen matsen commented Oct 29, 2024 •
edited
Loading

  • calling CSPs CSPs
  • specifying if something is nt_ or codon_

@matsen matsen marked this pull request as draft October 29, 2024 18:36
@matsen matsen linked an issue Oct 29, 2024 that may be closed by this pull request
clean up, clarify, consistent-ize, and document #18
Closed
2 tasks
@matsen matsen marked this pull request as ready for review October 29, 2024 19:47
@matsen matsen requested a review from willdumm October 29, 2024 19:48
willdumm
willdumm approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@willdumm willdumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, huge refactor! Looks great.

@matsen matsen merged commit 544f04a into main Oct 29, 2024
1 check passed
@matsen matsen deleted the 18-csp branch October 29, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willdumm willdumm willdumm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clean up, clarify, consistent-ize, and document
2 participants
@matsen @willdumm