feat: Prepopulate tstorage for the new version of EvmGasManager #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hedgar2017
previously approved these changes
Aug 26, 2024
hedgar2017
force-pushed
the
vv-prepopulate-tstorage-for-evmgasmanager
branch
from
7306db6 to
74478bf
Compare
|
@0xVolosnikov please don't update this branch! |
Hi guys, The issue is related to the case when we have a fork repository, and we would like to merge its other branch (not This resulted in the not rebased fork I pushed a fix and am testing it now. I revert everything back when completed. |
antonbaliasnikov
force-pushed
the
vv-prepopulate-tstorage-for-evmgasmanager
branch
2 times, most recently
from
7921362 to
74478bf
Compare
|
@0xVolosnikov , @hedgar2017 , CI is updated, all looks good to me now. |
hedgar2017
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Required for matter-labs/era-contracts#738
The logic of prepopulating storage is left for compatibility with the previous version of the contract
Why ❔
Checklist
cargo fmtand checked withcargo clippy.