Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(en): Integrate snapshots recovery into EN #1032

Merged
merged 29 commits into from
Feb 16, 2024
Merged

feat(en): Integrate snapshots recovery into EN #1032

merged 29 commits into from
Feb 16, 2024

Conversation

tomg10
Copy link
Contributor

@tomg10 tomg10 commented Feb 8, 2024 •
edited by slowli
Loading

What ❔

  • Integrates snapshot recovery logic into EN.
  • Tests recovering an EN from a snapshot in integration tests.

Why ❔

This is the final step to implement snapshot recovery (still needs to be thoroughly tested, of course).

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

tomg10 added 2 commits February 8, 2024 17:26
@tomg10
EN integration
7dd53e1 
Signed-off-by: tomg10 <lemures64@gmail.com>
@tomg10
zk fmt
b72a50d 
Signed-off-by: tomg10 <lemures64@gmail.com>
@tomg10 tomg10 changed the title Snapshots recovery en integration fat: Snapshots recovery EN integration Feb 8, 2024
@tomg10 tomg10 changed the title fat: Snapshots recovery EN integration feat: Snapshots recovery EN integration Feb 8, 2024
@tomg10 tomg10 requested a review from slowli February 8, 2024 20:47
@tomg10 tomg10 requested a review from a team as a code owner February 13, 2024 15:02
@slowli slowli force-pushed the snapshots-recovery-en-integration branch from 816848e to 572bf2a Compare February 13, 2024 16:35
@slowli slowli changed the title feat: Snapshots recovery EN integration feat(en): Integrate snapshots recovery into EN Feb 14, 2024
popzxc
popzxc reviewed Feb 14, 2024
View reviewed changes
core/bin/external_node/src/init.rs Outdated Show resolved Hide resolved
core/bin/external_node/src/init.rs Show resolved Hide resolved
core/lib/config/src/configs/object_store.rs Show resolved Hide resolved
infrastructure/zk/src/config.ts Show resolved Hide resolved
RomanBrodetski
RomanBrodetski previously approved these changes Feb 14, 2024
View reviewed changes
@slowli slowli added this pull request to the merge queue Feb 16, 2024
Merged via the queue into main with commit c7cfaf9 Feb 16, 2024
38 checks passed
@slowli slowli deleted the snapshots-recovery-en-integration branch February 16, 2024 09:56
@zksync-era-bot zksync-era-bot mentioned this pull request Feb 16, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Mar 5, 2024
@zksync-era-bot
chore(main): release prover 12.0.0 (#970)
7b54689 
🤖 I have created a release *beep* *boop*
---


##
[12.0.0](prover-v11.0.0...prover-v12.0.0)
(2024-03-04)


### ⚠ BREAKING CHANGES

* **prover:** Add EIP4844 support for provers subsystem
([#1200](#1200))
* Set 21 as latest protocol version
([#1262](#1262))

### Features

* Adding ability to generate 4844 setup key and refactor
([#1143](#1143))
([975f54b](975f54b))
* **api:** Remove unused and obsolete token info
([#1071](#1071))
([e920897](e920897))
* **dal:** `zksync_types::Transaction` to use protobuf for wire encoding
(BFT-407)
([#1047](#1047))
([ee94bee](ee94bee))
* **db:** Soft-remove `storage` table
([#982](#982))
([601f893](601f893))
* **en:** Integrate snapshots recovery into EN
([#1032](#1032))
([c7cfaf9](c7cfaf9))
* **healthcheck:** Various healthcheck improvements
([#1166](#1166))
([1e34148](1e34148))
* improving verification key generation
([#1050](#1050))
([6f715c8](6f715c8))
* Prover interface and L1 interface crates
([#959](#959))
([4f7e107](4f7e107))
* **prover:** Add EIP4844 support for provers subsystem
([#1200](#1200))
([6953e89](6953e89))
* **prover:** Added --recompute-if-missing option to key generator
([#1151](#1151))
([cad7278](cad7278))
* **prover:** Added 4844 circuit to verification keys
([#1141](#1141))
([8b0cc4a](8b0cc4a))
* **prover:** Adding first support for 4844 circuit
([#1155](#1155))
([6f63c53](6f63c53))
* **prover:** adding keystore object to handle reading and writing of
prover keys
([#1132](#1132))
([1471615](1471615))
* **prover:** merging key generation into a single binary
([#1101](#1101))
([6de8b84](6de8b84))
* **prover:** Moved setup key generation logic to test harness
([#1113](#1113))
([469ab06](469ab06))
* **prover:** Use new shivini function for 4844 circuits
([#1205](#1205))
([376c09e](376c09e))
* Set 21 as latest protocol version
([#1262](#1262))
([30579ef](30579ef))
* **vlog:** Remove env getters from vlog
([#1077](#1077))
([00d3429](00d3429))


### Bug Fixes

* fix link
([#1007](#1007))
([f1424ce](f1424ce))
* make `zk status prover` use the new prover table
([#1044](#1044))
([9b21d7f](9b21d7f))
* **prover:** Decouple core/ prover database management
([#1029](#1029))
([37674fd](37674fd))
* **prover:** Fix initial prover migration
([#1083](#1083))
([6d54010](6d54010))
* **prover:** QoL socket utilization
([#1020](#1020))
([13a6816](13a6816))
* update harness to include fix to new boojum OOM
([#1053](#1053))
([4976941](4976941))


### Performance Improvements

* bump harness version
([#1003](#1003))
([1cbb4c9](1cbb4c9))
* reduce memory consumption of witness generation
([#696](#696))
([dea6768](dea6768))
* upgrade harness version to improve witness generation memory spike
([#1034](#1034))
([09bbb84](09bbb84))
* use jemalloc in witness generator
([#1014](#1014))
([917b2dc](917b2dc))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slowli slowli slowli left review comments

@artmakh artmakh artmakh approved these changes

@popzxc popzxc popzxc approved these changes

@RomanBrodetski RomanBrodetski RomanBrodetski approved these changes

@yorik yorik Awaiting requested review from yorik yorik is a code owner automatically assigned from matter-labs/devops

@alexandrst88 alexandrst88 Awaiting requested review from alexandrst88 alexandrst88 is a code owner automatically assigned from matter-labs/devops

@hatemosphere hatemosphere Awaiting requested review from hatemosphere hatemosphere is a code owner automatically assigned from matter-labs/devops

@onyxet onyxet Awaiting requested review from onyxet onyxet is a code owner automatically assigned from matter-labs/devops

@otani88 otani88 Awaiting requested review from otani88 otani88 is a code owner automatically assigned from matter-labs/devops

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tomg10 @RomanBrodetski @slowli @popzxc @artmakh