Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(db): Soft-remove storage table #982

Merged
merged 13 commits into from
Feb 6, 2024
Merged

feat(db): Soft-remove storage table #982

merged 13 commits into from
Feb 6, 2024

Conversation

slowli
Copy link
Contributor

@slowli slowli commented Jan 31, 2024 •
edited
Loading

What ❔

Soft-removes the storage table, so that it's not referenced in any DB queries. The table itself will be dropped separately after this code change is deployed on all envs.

Why ❔

Faster miniblock sealing; less data in Postgres. Also simplifies snapshot recovery.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

@slowli slowli marked this pull request as ready for review February 1, 2024 08:48
popzxc
popzxc previously approved these changes Feb 1, 2024
View reviewed changes
core/lib/dal/src/storage_dal.rs Show resolved Hide resolved
popzxc
popzxc previously approved these changes Feb 1, 2024
View reviewed changes
RomanBrodetski
RomanBrodetski previously approved these changes Feb 2, 2024
View reviewed changes
core/lib/zksync_core/src/state_keeper/io/seal_logic.rs Outdated Show resolved Hide resolved
@slowli slowli dismissed stale reviews from RomanBrodetski and popzxc via 822e58c February 2, 2024 11:54
slowli added 2 commits February 5, 2024 17:51
@slowli
Write to storage table
590f196 
...so that it's possible to roll back its soft-removal
@slowli
Update from upstream
117551f
@slowli slowli added this pull request to the merge queue Feb 6, 2024
Merged via the queue into main with commit 601f893 Feb 6, 2024
37 checks passed
@slowli slowli deleted the aov-pla-745-get-rid-of-storage-table branch February 6, 2024 09:32
This was referenced Feb 6, 2024
Merged
Merged
github-merge-queue bot pushed a commit that referenced this pull request Feb 8, 2024
@zksync-era-bot
chore(main): release core 20.6.0 (#1011)
689d38c 
🤖 I have created a release *beep* *boop*
---


##
[20.6.0](core-v20.5.2...core-v20.6.0)
(2024-02-08)


### Features

* **api:** Start API server after first L1 batch
([#1026](#1026))
([86e189c](86e189c))
* **db:** Instrument DB connection lifecycle
([#1027](#1027))
([636fcfd](636fcfd))
* **db:** Soft-remove `storage` table
([#982](#982))
([601f893](601f893))
* **en:** Make state keeper work with pruned data
([#900](#900))
([f1913ae](f1913ae))
* export fee model for the test node
([#1030](#1030))
([d1e4774](d1e4774))
* Time-limit health checks and log them
([#993](#993))
([f3c190d](f3c190d))
* **types:** Added KZG info needed for 4844 blobs
([#894](#894))
([758f487](758f487))


### Bug Fixes

* fix link
([#1007](#1007))
([f1424ce](f1424ce))
* **metrics:** Use latest block for non pos ethereum as safe
([#1022](#1022))
([49ec843](49ec843))
* Revert "preparation for shared bridge migration (server)"
([#1010](#1010))
([d4c984a](d4c984a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
github-merge-queue bot pushed a commit that referenced this pull request Mar 5, 2024
@zksync-era-bot
chore(main): release prover 12.0.0 (#970)
7b54689 
🤖 I have created a release *beep* *boop*
---


##
[12.0.0](prover-v11.0.0...prover-v12.0.0)
(2024-03-04)


### ⚠ BREAKING CHANGES

* **prover:** Add EIP4844 support for provers subsystem
([#1200](#1200))
* Set 21 as latest protocol version
([#1262](#1262))

### Features

* Adding ability to generate 4844 setup key and refactor
([#1143](#1143))
([975f54b](975f54b))
* **api:** Remove unused and obsolete token info
([#1071](#1071))
([e920897](e920897))
* **dal:** `zksync_types::Transaction` to use protobuf for wire encoding
(BFT-407)
([#1047](#1047))
([ee94bee](ee94bee))
* **db:** Soft-remove `storage` table
([#982](#982))
([601f893](601f893))
* **en:** Integrate snapshots recovery into EN
([#1032](#1032))
([c7cfaf9](c7cfaf9))
* **healthcheck:** Various healthcheck improvements
([#1166](#1166))
([1e34148](1e34148))
* improving verification key generation
([#1050](#1050))
([6f715c8](6f715c8))
* Prover interface and L1 interface crates
([#959](#959))
([4f7e107](4f7e107))
* **prover:** Add EIP4844 support for provers subsystem
([#1200](#1200))
([6953e89](6953e89))
* **prover:** Added --recompute-if-missing option to key generator
([#1151](#1151))
([cad7278](cad7278))
* **prover:** Added 4844 circuit to verification keys
([#1141](#1141))
([8b0cc4a](8b0cc4a))
* **prover:** Adding first support for 4844 circuit
([#1155](#1155))
([6f63c53](6f63c53))
* **prover:** adding keystore object to handle reading and writing of
prover keys
([#1132](#1132))
([1471615](1471615))
* **prover:** merging key generation into a single binary
([#1101](#1101))
([6de8b84](6de8b84))
* **prover:** Moved setup key generation logic to test harness
([#1113](#1113))
([469ab06](469ab06))
* **prover:** Use new shivini function for 4844 circuits
([#1205](#1205))
([376c09e](376c09e))
* Set 21 as latest protocol version
([#1262](#1262))
([30579ef](30579ef))
* **vlog:** Remove env getters from vlog
([#1077](#1077))
([00d3429](00d3429))


### Bug Fixes

* fix link
([#1007](#1007))
([f1424ce](f1424ce))
* make `zk status prover` use the new prover table
([#1044](#1044))
([9b21d7f](9b21d7f))
* **prover:** Decouple core/ prover database management
([#1029](#1029))
([37674fd](37674fd))
* **prover:** Fix initial prover migration
([#1083](#1083))
([6d54010](6d54010))
* **prover:** QoL socket utilization
([#1020](#1020))
([13a6816](13a6816))
* update harness to include fix to new boojum OOM
([#1053](#1053))
([4976941](4976941))


### Performance Improvements

* bump harness version
([#1003](#1003))
([1cbb4c9](1cbb4c9))
* reduce memory consumption of witness generation
([#696](#696))
([dea6768](dea6768))
* upgrade harness version to improve witness generation memory spike
([#1034](#1034))
([09bbb84](09bbb84))
* use jemalloc in witness generator
([#1014](#1014))
([917b2dc](917b2dc))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@popzxc popzxc popzxc approved these changes

@tomg10 tomg10 Awaiting requested review from tomg10

@RomanBrodetski RomanBrodetski Awaiting requested review from RomanBrodetski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slowli @RomanBrodetski @popzxc