-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Time-limit health checks and log them #993
Merged
slowli
merged 2 commits into
main
from
aov-pla-781-improve-health-checking-time-limits-and-logging
Feb 5, 2024
Merged
feat: Time-limit health checks and log them #993
slowli
merged 2 commits into
main
from
aov-pla-781-improve-health-checking-time-limits-and-logging
Feb 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slowli
force-pushed
the
aov-pla-781-improve-health-checking-time-limits-and-logging
branch
from
February 1, 2024 16:27
3686caa
to
f454764
Compare
RomanBrodetski
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice, thanks for this chagne!
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 2, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 2, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 2, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 5, 2024
slowli
deleted the
aov-pla-781-improve-health-checking-time-limits-and-logging
branch
February 5, 2024 11:53
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 8, 2024
🤖 I have created a release *beep* *boop* --- ## [20.6.0](core-v20.5.2...core-v20.6.0) (2024-02-08) ### Features * **api:** Start API server after first L1 batch ([#1026](#1026)) ([86e189c](86e189c)) * **db:** Instrument DB connection lifecycle ([#1027](#1027)) ([636fcfd](636fcfd)) * **db:** Soft-remove `storage` table ([#982](#982)) ([601f893](601f893)) * **en:** Make state keeper work with pruned data ([#900](#900)) ([f1913ae](f1913ae)) * export fee model for the test node ([#1030](#1030)) ([d1e4774](d1e4774)) * Time-limit health checks and log them ([#993](#993)) ([f3c190d](f3c190d)) * **types:** Added KZG info needed for 4844 blobs ([#894](#894)) ([758f487](758f487)) ### Bug Fixes * fix link ([#1007](#1007)) ([f1424ce](f1424ce)) * **metrics:** Use latest block for non pos ethereum as safe ([#1022](#1022)) ([49ec843](49ec843)) * Revert "preparation for shared bridge migration (server)" ([#1010](#1010)) ([d4c984a](d4c984a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
/health
endpoint doesn't time out w/o returning data.Why ❔
Our ENs periodically fail health checks by timing out requests to the
/health
endpoint.Checklist
zk fmt
andzk lint
.zk spellcheck
.zk linkcheck
.