feat(db): Instrument DB connection lifecycle #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slowli
commented
Feb 7, 2024
There was a problem hiding this comment.
An example of a connection timeout error with enabled connection tracing:
called `Result::unwrap()` on an `Err` value: acquire_connection_retried()
Caused by:
Run out of retries getting a DB connection (requested by `state_keeper` at core/lib/zksync_core/src/state_keeper/io/fee_address_migration.rs:98), last error: pool timed out while waiting for an open connection
Alive connections: {
[2024-02-07 10:12:02.526407167 UTC - requested by `state_keeper` at core/lib/zksync_core/src/state_keeper/io/fee_address_migration.rs:74],
}
slowli
changed the title
RomanBrodetski
approved these changes
Feb 7, 2024
popzxc
approved these changes
Feb 8, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 8, 2024
🤖 I have created a release *beep* *boop* --- ## [20.6.0](core-v20.5.2...core-v20.6.0) (2024-02-08) ### Features * **api:** Start API server after first L1 batch ([#1026](#1026)) ([86e189c](86e189c)) * **db:** Instrument DB connection lifecycle ([#1027](#1027)) ([636fcfd](636fcfd)) * **db:** Soft-remove `storage` table ([#982](#982)) ([601f893](601f893)) * **en:** Make state keeper work with pruned data ([#900](#900)) ([f1913ae](f1913ae)) * export fee model for the test node ([#1030](#1030)) ([d1e4774](d1e4774)) * Time-limit health checks and log them ([#993](#993)) ([f3c190d](f3c190d)) * **types:** Added KZG info needed for 4844 blobs ([#894](#894)) ([758f487](758f487)) ### Bug Fixes * fix link ([#1007](#1007)) ([f1424ce](f1424ce)) * **metrics:** Use latest block for non pos ethereum as safe ([#1022](#1022)) ([49ec843](49ec843)) * Revert "preparation for shared bridge migration (server)" ([#1010](#1010)) ([d4c984a](d4c984a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Instruments DB connection lifecycle (acquiring connection call sites, long-living connections). Traces connections for test pools and allows to configure test pool size.
Why ❔
Checklist
zk fmtandzk lint.zk spellcheck.zk linkcheck.