fix(block-reverter): Fix reverting snapshot files #2064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slowli
commented
May 28, 2024
popzxc
approved these changes
May 29, 2024
RomanBrodetski
approved these changes
Jun 3, 2024
This was referenced Jun 3, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 3, 2024
🤖 I have created a release *beep* *boop* --- ## [24.7.0](core-v24.6.0...core-v24.7.0) (2024-06-03) ### Features * **node-framework:** Add reorg detector ([#1551](#1551)) ([7c7d352](7c7d352)) ### Bug Fixes * **block-reverter:** Fix reverting snapshot files ([#2064](#2064)) ([17a7e78](17a7e78)) * **env:** Do not print stacktrace for locate workspace ([#2111](#2111)) ([5f2677f](5f2677f)) * **eth-watch:** make assert less strict ([#2129](#2129)) ([e9bab95](e9bab95)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <zksync-era-bot@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 4, 2024
🤖 I have created a release *beep* *boop* --- ## [14.5.0](prover-v14.4.0...prover-v14.5.0) (2024-06-04) ### Features * update VKs and bump cargo.lock ([#2112](#2112)) ([6510317](6510317)) * use semver for metrics, move constants to prover workspace ([#2098](#2098)) ([7a50a9f](7a50a9f)) ### Bug Fixes * **block-reverter:** Fix reverting snapshot files ([#2064](#2064)) ([17a7e78](17a7e78)) * **house-keeper:** Fix queue size queries ([#2106](#2106)) ([183502a](183502a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
vivijj
pushed a commit
to CortexFoundation/zksync-era
that referenced
this pull request
Jun 7, 2024
## What ❔ - Does not retry "not found" errors when removing objects. - Makes rolling back snapshot files optional. ## Why ❔ The current implementation leads to very slow reverts because of retries. ## Checklist - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Tests for the changes have been added / updated. - [x] Documentation comments have been added / updated. - [x] Code has been formatted via `zk fmt` and `zk lint`. - [x] Spellcheck has been run via `zk spellcheck`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
The current implementation leads to very slow reverts because of retries.
Checklist
zk fmtandzk lint.zk spellcheck.