fix(env): Do not print stacktrace for locate workspace #2111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomg10
previously approved these changes
May 31, 2024
Signed-off-by: Danil <deniallugo@gmail.com>
Deniallugo
force-pushed
the
deniallugo-change-stack-trace-for-locate-workspace
branch
from
d1af439 to
09d1e48
Compare
tomg10
approved these changes
May 31, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 3, 2024
🤖 I have created a release *beep* *boop* --- ## [24.7.0](core-v24.6.0...core-v24.7.0) (2024-06-03) ### Features * **node-framework:** Add reorg detector ([#1551](#1551)) ([7c7d352](7c7d352)) ### Bug Fixes * **block-reverter:** Fix reverting snapshot files ([#2064](#2064)) ([17a7e78](17a7e78)) * **env:** Do not print stacktrace for locate workspace ([#2111](#2111)) ([5f2677f](5f2677f)) * **eth-watch:** make assert less strict ([#2129](#2129)) ([e9bab95](e9bab95)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <zksync-era-bot@users.noreply.github.com>
vivijj
added a commit
to CortexFoundation/zksync-era
that referenced
this pull request
Jun 7, 2024
) ## What ❔ Do not throw stack trace for already compiled binaries ## Why ❔ Confusing for users ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zk fmt` and `zk lint`. - [ ] Spellcheck has been run via `zk spellcheck`. Signed-off-by: Danil <deniallugo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Do not throw stack trace for already compiled binaries
Why ❔
Confusing for users
Checklist
zk fmtandzk lint.zk spellcheck.