Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-535] Add non-breaking space before 'show description button' #604

Closed
wants to merge 8 commits into from
Closed

[GH-535] Add non-breaking space before 'show description button' #604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2fbdf80
Add non-breaking space before 'show description button'
lunaticmonk Jun 19, 2021
6367163
Use css to add space
lunaticmonk Jul 11, 2021
08ac3c2
Merge branch 'main' into space-fix
lunaticmonk Jul 11, 2021
8d970bd
Merge branch 'main' into space-fix
sbishel Jul 29, 2021
10173cd
Merge branch 'main' into space-fix
sbishel Aug 4, 2021
00018cb
Merge branch 'main' into space-fix
sbishel Aug 19, 2021
ed5f241
Merge branch 'main' into space-fix
sbishel Aug 20, 2021
c189647
Merge branch 'main' into space-fix
sbishel Aug 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions webapp/src/components/viewTitle.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,8 @@
>.description>* {
flex-grow: 1;
}

.non-breaking-space {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not what I was expecting, I was thinking more in something like changing the already existing .add-buttons .Icon class and add there the margin-right: 0.5em, that way you don't need the span element at all, and you also fix the same problem with the Hide and Emoji icons.

margin-right: 10px;
}
}
1 change: 1 addition & 0 deletions webapp/src/components/viewTitle.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ const ViewTitle = React.memo((props: Props) => {
onClick={onShowDescription}
icon={<ShowIcon/>}
>
<span className="non-breaking-space"></span>
<FormattedMessage
id='ViewTitle.show-description'
defaultMessage='show description'
Expand Down