[GH-535] Add non-breaking space before 'show description button' #604
Conversation
lunaticmonk
changed the title
|
@chenilim I have signed the CLA but I don't know how to re-trigger the workflows to let the cla/mattermost workflow pass. Can you please help me out? |
|
/check-cla |
|
@chenilim Can you please review?
|
webapp/src/components/viewTitle.tsx
Outdated
| @@ -64,6 +64,7 @@ const ViewTitle = React.memo((props: Props) => { | |||
| }} | |||
| icon={<ShowIcon/>} | |||
| > | |||
| | |||
There was a problem hiding this comment.
I don't love the use of here, it remove certain control of the styling, do you mind to add a .ViewTitle .add-buttons .Icon css that add a margin-right, that way we can make more fine grain styling of this.
There was a problem hiding this comment.
by the way, the right place would be the file webapp/src/components/viewTitle.scss
|
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
|
@lunaticmonk just checking in if you have any update on this? |
|
@harshilsharma63 @jespino Pushed the css changes. Please review once. |
| @@ -38,4 +38,8 @@ | |||
| > .description > * { | |||
| flex-grow: 1; | |||
| } | |||
|
|
|||
| .non-breaking-space { | |||
There was a problem hiding this comment.
This is not what I was expecting, I was thinking more in something like changing the already existing .add-buttons .Icon class and add there the margin-right: 0.5em, that way you don't need the span element at all, and you also fix the same problem with the Hide and Emoji icons.
|
@lunaticmonk Just checking in if you are still working on this. |
|
@sbishel Yes, will update this PR soon, was a bit busy from few days at work! |
|
@sbishel I accidently logged out of my account on my local setup and can't remember the password. Is there a way to reset the password via some hack? I need to test these changes once. I also tried signing up again but getting:
Can you help me in this? |
|
@lunaticmonk Sorry, I missed this message. No, we don't have a hack for that. You could hack the change password code (ie, don't require old password) and run via ChangePassword API. I'm not sure why you can't register a new user are you seeing any other errors? If you want to push it up this PR, I'm happy to test. |
|
@sbishel I tried doing few hacks but the page gets redirected to login and I cannot reset password. Looks like I will need your help in testing this and merging it. Meanwhile, I will set up the repo again from scratch to solve the auth issue. |
|
@lunaticmonk Sure, merge your changes to this PR and I'll test. The only hack would be if your running source code to put a break point in where login fails and go around it. |
|
@sbishel Didn't get you? Which PR should I merge my changes to? Is there any other branch you have where I should merge these? |
|
@lunaticmonk This one. I thought you had additional updates to this PR based on Jesus feedback. |
|
@sbishel These are the only changes I believe. You can test this branch. |
|
Fixed by #765 |
Summary
Adds a space between the "show description" description and the icon on a board.
Ticket Link
#535