Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gh 744 - Improving UI for share board popup and improving buttons #765

Merged
merged 5 commits into from
Jul 22, 2021
Merged

Gh 744 - Improving UI for share board popup and improving buttons #765

merged 5 commits into from
Jul 22, 2021

Conversation

asaadmahmood
Copy link
Contributor

@asaadmahmood asaadmahmood commented Jul 22, 2021 •
edited
Loading

Summary

Gh 744 - Improving UI for share board popup and improving buttons

Ticket Link

#744

Screenshots

Screenshot 2021-07-22 at 1 06 44 PM

Screenshot 2021-07-22 at 1 06 50 PM

@asaadmahmood asaadmahmood requested a review from chenilim July 22, 2021 08:08
@asaadmahmood asaadmahmood requested a review from a team as a code owner July 22, 2021 08:08
@asaadmahmood asaadmahmood requested review from harshilsharma63 and removed request for a team July 22, 2021 08:08
@asaadmahmood asaadmahmood added the 2: Dev Review Requires review by a core committer label Jul 22, 2021
@asaadmahmood asaadmahmood mentioned this pull request Jul 22, 2021
Merged
harshilsharma63
harshilsharma63 approved these changes Jul 22, 2021
View reviewed changes
Copy link
Member

@harshilsharma63 harshilsharma63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harshilsharma63
Copy link
Member

One of the Jest test is failing though. Probably needs a snapshot update.

@harshilsharma63 harshilsharma63 removed the 2: Dev Review Requires review by a core committer label Jul 22, 2021
@asaadmahmood asaadmahmood merged commit c2519d4 into main Jul 22, 2021
@asaadmahmood asaadmahmood deleted the GH-744 branch July 22, 2021 14:36
@sbishel sbishel mentioned this pull request Sep 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshilsharma63 harshilsharma63 harshilsharma63 approved these changes

@chenilim chenilim Awaiting requested review from chenilim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asaadmahmood @harshilsharma63