Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.2.2 #127

Closed
wants to merge 6 commits into from
Closed

Release v2.2.2 #127

wants to merge 6 commits into from

Conversation

hanzei
Copy link
Contributor

@hanzei hanzei commented Dec 2, 2022

Summary

First release to the Marketplace

Open Tickets

Ticket Link

Part of #126

@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester Do Not Merge Should not be merged until this label is removed labels Dec 2, 2022
@hanzei hanzei added this to the v2.2.2 milestone Dec 2, 2022
@hanzei hanzei changed the title Bump version to 2.2.2 Release v2.2.2 Dec 2, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 58.52% // Head: 58.52% // No change to project coverage 👍

Coverage data is based on head (62eec09) compared to base (5facc95).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #127   +/-   ##
=======================================
  Coverage   58.52%   58.52%           
=======================================
  Files          15       15           
  Lines        1883     1883           
=======================================
  Hits         1102     1102           
  Misses        698      698           
  Partials       83       83           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Dec 5, 2022
@hanzei hanzei removed the request for review from avas27JTG December 5, 2022 11:50
@hanzei hanzei mentioned this pull request Feb 15, 2023
3 tasks
@mickmister
Copy link
Contributor

@hanzei Should this PR be converted to release v3 instead of v2, or closed in favor of a new PR?

Also I notice that the master branch currently shows that the current version is 3.1.1. @raghavaggarwal2308 We want to make sure we only bump the version on master when we're making an actual release of the plugin.

@mickmister
Copy link
Contributor

Also, if we are releasing v3, should the version number be 3.1.1 or 3.0.0? Interally, it may provide value to label it as 3.1.1 to pinpoint the point of the project we're releasing. Since it hasn't been released or battle tested, I would normally advocate for 0.1.0, though this project has gone through quite a few review cycles on different large changes.

@mickmister
Copy link
Contributor

Made a PR to bump to 3.2.0 #153

@hanzei hanzei removed this from the v2.2.2 milestone Apr 6, 2023
@hanzei hanzei closed this Apr 6, 2023
@hanzei hanzei added Duplicate This issue or pull request already exists and removed 3: QA Review Requires review by a QA tester Do Not Merge Should not be merged until this label is removed labels Apr 6, 2023
@hanzei hanzei deleted the release_v2.2.2 branch April 6, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants