Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release to Marketplace #128

Closed
wants to merge 232 commits into from
Closed

Release to Marketplace #128

wants to merge 232 commits into from

Conversation

hanzei
Copy link
Contributor

@hanzei hanzei commented Dec 2, 2022 •
edited
Loading

The sole purpose of this PR is to allow a review of the codebase of the plugin. It contains all changes that have been made since the repo was forked from https://github.com/mattermost/mattermost-plugin-starter-template.

The PR should not get merged. Once every party has approved the PR, #127 will include the required changes for a release.

Security review ticket: https://mattermost.atlassian.net/browse/SEC-2367.
Security review ticket for Phase 3: https://mattermost.atlassian.net/browse/SEC-3075.

avas27JTG and others added 30 commits July 25, 2022 14:37
@avas27JTG
[MI-1846]: Base setup with bot and help command (#1)
8066d68 
* [MI-1846]: Added nvmrc file

* Modular folder structure

* Modular folder structure

* [MI-1846]: Base setup

* [MI-1846]: Refactored server base setup

* [MI-1846]: Review fixes

* [MI-1846]: Review fixes

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
@avas27JTG
[MI-1854]: Implement OAuth to access Azure DevOps services (#2)
2a1e24a 
* [MI-1846]: Added nvmrc file

* Modular folder structure

* Modular folder structure

* [MI-1846]: Base setup

* [MI-1846]: Refactored server base setup

* [MI-1854]: Implement OAuth to access Azure DevOps services

* [MI-1846]: Review fixes

* [MI-1846]: Review fixes

* [MI-1854]: Review fixes

* [MI-1854]: Removed unused config

* [MI-1854]: Added logic to verify state

* [MI-1854]: Removed unused configs

* [MI-1854]: Review fixes

* [MI-1854]: Review fixes

* [MI-1854]: Review fixes

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
@ayusht2810 @avas27JTG
[MI-1931] Add API to get projects and get tasks (#3)
a52039a 
* [MI-1846]: Added nvmrc file

* Modular folder structure

* Modular folder structure

* [MI-1846]: Base setup

* [MI-1846]: Refactored server base setup

* [MI-1854]: Implement OAuth to access Azure DevOps services

* [MI-1931] Add API to get projects and get tasks

* [MI-1931] Self review fixes

* [MI-1931] Review fixes 1

* [MI-1931] Self review fix

* [MI-1846]: Review fixes

* [MI-1931] Review fixes 2

* [MI-1931] Add json error handling

* [MI-1931] Add comment to the code

* [MI-1931] Add error check

* [MI-1846]: Review fixes

* [MI-1854]: Review fixes

* [MI-1854]: Removed unused config

* [MI-1854]: Added logic to verify state

* [MI-1931] Run fmt

* [MI-1854]: Removed unused configs

* [MI-1854]: Review fixes

* [MI-1931] Remove unused code

* [MI-1931] Correct spelling error

* [MI-1931] Correct formatting

Co-authored-by: Abhishek Verma <abhishek.verma@joshtechnologygroup.com>
Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
@ayusht2810 @avas27JTG
[MI-1945] Add function to make protected routes (#4)
42f9cf1 
* [MI-1846]: Added nvmrc file

* Modular folder structure

* Modular folder structure

* [MI-1846]: Base setup

* [MI-1846]: Refactored server base setup

* [MI-1854]: Implement OAuth to access Azure DevOps services

* [MI-1931] Add API to get projects and get tasks

* [MI-1931] Self review fixes

* [MI-1931] Review fixes 1

* [MI-1931] Self review fix

* [MI-1945] Add function to make protected routes

* [MI-1846]: Review fixes

* [MI-1931] Review fixes 2

* [MI-1931] Add json error handling

* [MI-1931] Add comment to the code

* [MI-1931] Add error check

* [MI-1945] Review fix

* [MI-1846]: Review fixes

* [MI-1854]: Review fixes

* [MI-1854]: Removed unused config

* [MI-1854]: Added logic to verify state

* [MI-1931] Run fmt

* [MI-1945] Review fix 2

* [MI-1854]: Removed unused configs

* [MI-1854]: Review fixes

* [MI-1931] Remove unused code

* [MI-1931] Correct spelling error

Co-authored-by: Abhishek Verma <abhishek.verma@joshtechnologygroup.com>
Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
@ayusht2810 @avas27JTG
[MI-1948] Add API to create task (#5)
d22b29b 
* [MI-1846]: Added nvmrc file

* Modular folder structure

* Modular folder structure

* [MI-1846]: Base setup

* [MI-1846]: Refactored server base setup

* [MI-1854]: Implement OAuth to access Azure DevOps services

* [MI-1931] Add API to get projects and get tasks

* [MI-1931] Self review fixes

* [MI-1931] Review fixes 1

* [MI-1931] Self review fix

* [MI-1945] Add function to make protected routes

* [MI-1846]: Review fixes

* [MI-1931] Review fixes 2

* [MI-1948] Add API to create task

* [MI-1931] Add json error handling

* [MI-1948] Add error in json format

* [MI-1931] Add comment to the code

* [MI-1931] Add error check

* [MI-1945] Review fix

* [MI-1948] Review fixes 1

* [MI-1846]: Review fixes

* [MI-1854]: Review fixes

* [MI-1854]: Removed unused config

* [MI-1854]: Added logic to verify state

* [MI-1931] Run fmt

* [MI-1945] Review fix 2

* [MI-1948] Self review fix

* [MI-1854]: Removed unused configs

* [MI-1854]: Review fixes

* [MI-1948] Return status code from client

* [MI-1931] Remove unused code

* [MI-1931] Correct spelling error

* [MI-1948] Add wrapper for application/json-patch+json content type

* [MI-1948] Correct error handling

* [MI-1948] Correct serializer name and add a method

* [MI-1948] Correct constants

Co-authored-by: Abhishek Verma <abhishek.verma@joshtechnologygroup.com>
Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
@avas27JTG @ayusht2810
Epic changes (all code merged here are already reviewed) (#24)
adf462f 
* [MI-1846]: Added nvmrc file

* Modular folder structure

* Modular folder structure

* [MI-1846]: Base setup

* [MI-1846]: Refactored server base setup

* [MI-1854]: Implement OAuth to access Azure DevOps services

* working

* [MI-1846]: Review fixes

* [MI-1931] Add API to get projects and get tasks

* [MI-1931] Self review fixes

* [MI-1931] Review fixes 1

* [MI-1931] Self review fix

* [MI-1945] Add function to make protected routes

* [MI-1948] Add API to create task

* [MI-1931] Review fixes 2

* [MI-1931] Add json error handling

* [MI-1948] Add error in json format

* [MI-1948_1] Resolve build error

* [MI-1964]: Make changes to make POST API request from the webapp.

* [MI-1846]: Review fixes

* [MI-1854]: Review fixes

* [MI-1854]: Removed unused config

* [MI-1854]: Added logic to verify state

* [MI-1953] Add create task modal (#6)

* [MI-1953] Add create task modal

* [MI-1953] Run fmt

* [MI-1953] Correct validations

* [MI-1953] Send new work item link in DM

* [MI-1953] Correct error handling and reusable components

* [MI-1953] Correct operator in modal footer

* [MI-1953] Disable button on API request

* [MI-1953] Correct loading state

* [MI-1953] Review fixes

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [MI-1950] Add feature to preview work items (#7)

* [MI-1953] Add create task modal

* [MI-1953] Run fmt

* [MI-1950] Add feature to preview work items

* [MI-1950] Self review fix

* [MI-1953] Correct validations

* [MI-1950] Self review fix

* [MI-1953] Send new work item link in DM

* [MI-1950] Add a comment

* [MI-1950] Review fixes 1

* [MI-1950] Review fix

* [MI-1953] Correct error handling and reusable components

* [MI-1950] Update variable names

* [MI-1953] Correct operator in modal footer

* [MI-1953] Disable button on API request

* [MI-1953] Correct loading state

* [MI-1950] Using slack attachment to show preview

* [MI-1950] Correct comments

* [MI-1950]: Sync

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [MI-1979]: Created project list RHS view and related components (#8)

* [MI-1953] Add create task modal

* [MI-1953] Run fmt

* [MI-1950] Add feature to preview work items

* [MI-1950] Self review fix

* [MI-1953] Correct validations

* [MI-1950] Self review fix

* [MI-1953] Send new work item link in DM

* [MI-1950] Add a comment

* [MI-1979]: Created project list RHS view and realted components

* [MI-1979]: Fixed lints

* [MI-1979]: Review fixes

* [MI-1979]: Review fixes

* [MI-1979]: Removed unused code

Co-authored-by: ayusht2810 <ayush.thakur@joshtechnologygroup.com>
Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [MI-1983]: Create subscription details with related components and ad… (#9)

* [MI-1953] Add create task modal

* [MI-1953] Run fmt

* [MI-1950] Add feature to preview work items

* [MI-1950] Self review fix

* [MI-1953] Correct validations

* [MI-1950] Self review fix

* [MI-1953] Send new work item link in DM

* [MI-1950] Add a comment

* [MI-1979]: Created project list RHS view and realted components

* [MI-1979]: Fixed lints

* [MI-1983]: Create subscription details with related components and add redux logic to navigate.

* [MI-1983]: Changed hover state

* [MI-1983]: Review fixes

Co-authored-by: ayusht2810 <ayush.thakur@joshtechnologygroup.com>
Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [MI-1974] Add modal to link a project (#11)

* [MI-1953] Add create task modal

* [MI-1953] Run fmt

* [MI-1953] Correct validations

* [MI-1953] Send new work item link in DM

* [MI-1974] Add feature to link a project

* [MI-1953] Correct error handling and reusable components

* [MI-1953] Correct operator in modal footer

* [MI-1974] Refactor KV store

* [MI-1953] Disable button on API request

* [MI-1974] Run fmt and correct loading

* [MI-1974] Add error field in modal

* [MI-1974] Review fixes

* [MI-1974] Add function to check if project is already linked

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [MI-1989] Add middleware to check oAuth (#12)

* [MI-1953] Add create task modal

* [MI-1953] Run fmt

* [MI-1953] Correct validations

* [MI-1953] Send new work item link in DM

* [MI-1953] Correct error handling and reusable components

* [MI-1953] Correct operator in modal footer

* [MI-1953] Disable button on API request

* [MI-1989] Add middleware to check oAuth

* [MI-1989] Correct function call

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [MI-1993] Correct failing CI (#13)

* [MI-1953] Add create task modal

* [MI-1953] Run fmt

* [MI-1953] Correct validations

* [MI-1953] Send new work item link in DM

* [MI-1953] Correct error handling and reusable components

* [MI-1953] Correct operator in modal footer

* [MI-1953] Disable button on API request

* [MI-1953] Correct loading state

* [MI-1993] Correct ci

* [MI-1993] Correct if else chain

* [MI-1993] Correct make test

* [MI-1993] Correct error handling

* [MI-1993]: Review fixes

* [MI-1993]: Review fixes

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

Co-authored-by: ayusht2810 <ayush.thakur@joshtechnologygroup.com>
Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
Co-authored-by: ayusht2810 <100013900+ayusht2810@users.noreply.github.com>
@avas27JTG
[MI-1986]: Create plugin API to fetch linked projects list (#27)
ec1a1af 
* [MI-1986]: Create plugin API to fetch linked projects list

* [MI-1986]: Review fix

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
@avas27JTG
[MI-1987]: Integrated project list UI (#28)
8d21f7e 
* [MI-1986]: Create plugin API to fetch linked projects list

* [MI-1987]: Integrated project list UI

* [MI-1987]: Review fixes

* [MI-1987]: Review fix

* [MI-1987]: Review fixes

* [MI-2001]: Create plugin API to unlink project and integration (#29)

* [MI-2001]: [MI-2001]: Create plugin API to unlink project and integrate the UI

* [MI-2001]: Review fixes

* [MI-2002]: Review fixes

* [MI-2001]: Review fixes

* [MI-2001]: Review fixes

* [MI-2001]: Review fix

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
@avas27JTG
[MI-2002]: Created plugin API to fetch user details and UI integratio… (
fc74ee8 
#30)

* [MI-1986]: Create plugin API to fetch linked projects list

* [MI-1987]: Integrated project list UI

* [MI-1987]: Review fixes

* [MI-2001]: [MI-2001]: Create plugin API to unlink project and integrate the UI

* [MI-2001]: Review fixes

* [MI-2002]: Created plugin API to fetch user details and UI integration with other changes

* [MI-2002]: Review fixes

* [MI-2002]: Updated API paths

* [MI-1987]: Review fix

* [MI-1987]: Review fixes

* [MI-2001]: Review fixes

* [MI-2001]: Review fixes

* [MI-2002]: Review fixes

* [MI-2002]: Review fix

* [MI-2002]: Review fixes

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
@avas27JTG
[MI-2049]: Added websocket support to detect user connection details … (
c87e47b 
#31)

* [MI-1986]: Create plugin API to fetch linked projects list

* [MI-1987]: Integrated project list UI

* [MI-1987]: Review fixes

* [MI-2001]: [MI-2001]: Create plugin API to unlink project and integrate the UI

* [MI-2001]: Review fixes

* [MI-2002]: Created plugin API to fetch user details and UI integration with other changes

* [MI-2002]: Review fixes

* [MI-2002]: Updated API paths

* [MI-2049]: Added websocket support to detect user connection details and a centralised check for root modals

* [MI-1987]: Review fix

* [MI-1987]: Review fixes

* [MI-2001]: Review fixes

* [MI-2001]: Review fixes

* [MI-2002]: Review fixes

* [MI-2049]: Review fixes

* [MI-2049]: Fixed merge change

* [MI-2049]: Refactored code

* [MI-2049]: Review fix

* [MI-2049]: Review fix

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
@avas27JTG
[MI-2035]: Integrated unlinking project from details page (#33)
023ebcb 
* [MI-1986]: Create plugin API to fetch linked projects list

* [MI-1987]: Integrated project list UI

* [MI-1987]: Review fixes

* [MI-2001]: [MI-2001]: Create plugin API to unlink project and integrate the UI

* [MI-2001]: Review fixes

* [MI-2002]: Created plugin API to fetch user details and UI integration with other changes

* [MI-2002]: Updated API paths

* [MI-2049]: Added websocket support to detect user connection details and a centralised check for root modals

* [MI-2035]: Integrated unlinking project from details page

* [MI-2035]: Review fix

* [MI-2035]: Review fix

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
@avas27JTG
[MI-1939]: Added refresh token logic (#34)
4f4d04f 
* [MI-1986]: Create plugin API to fetch linked projects list

* [MI-1987]: Integrated project list UI

* [MI-1987]: Review fixes

* [MI-2001]: [MI-2001]: Create plugin API to unlink project and integrate the UI

* [MI-2001]: Review fixes

* [MI-2002]: Created plugin API to fetch user details and UI integration with other changes

* [MI-2002]: Updated API paths

* [MI-2049]: Added websocket support to detect user connection details and a centralised check for root modals

* [MI-2035]: Integrated unlinking project from details page

* [MI-1939]: Added refresh token logic

* [MI-1939]: Fixed statusCode

* [MI-1939]: Review fixes

* [MI-1939]: Added check for user's oAuth

* [MI-1939]: Added buffer

* [MI-1939]: Used epoch time

* [MI-1939]: Review fix

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
@avas27JTG
[MI-2056]: Fixed create task flow and added user connection check on … (
171e87f 
#40)

* [MI-1986]: Create plugin API to fetch linked projects list

* [MI-1987]: Integrated project list UI

* [MI-1987]: Review fixes

* [MI-2001]: [MI-2001]: Create plugin API to unlink project and integrate the UI

* [MI-2001]: Review fixes

* [MI-2002]: Created plugin API to fetch user details and UI integration with other changes

* [MI-2002]: Updated API paths

* [MI-2049]: Added websocket support to detect user connection details and a centralised check for root modals

* [MI-2035]: Integrated unlinking project from details page

* [MI-1939]: Added refresh token logic

* [MI-1939]: Fixed statusCode

* [MI-2056]: Fixed create task flow and added user connection check on reload

* [MI-2056]: Review fix

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
@avas27JTG @ayusht2810
[MI-2061]: Refactoring and optimisations around Forms, RTK query, and…
e63723d 
… types and constants management (#45)

* [MI-1986]: Create plugin API to fetch linked projects list

* [MI-1987]: Integrated project list UI

* [MI-1987]: Review fixes

* [MI-2001]: [MI-2001]: Create plugin API to unlink project and integrate the UI

* [MI-2001]: Review fixes

* [MI-2002]: Created plugin API to fetch user details and UI integration with other changes

* [MI-2002]: Updated API paths

* [MI-2049]: Added websocket support to detect user connection details and a centralised check for root modals

* [MI-2010]: API to create subscriptions

* [MI-2010] Fix lint errors

* [MI-2035]: Integrated unlinking project from details page

* [MI-1939]: Added refresh token logic

* [MI-2009] API to get list of subscriptions

* [MI-2011] Add API to listen notifications

* [MI-2023] API to delete subscriptions

* [MI-2023] Remove print statement

* [MI-1939]: Fixed statusCode

* [MI-2029] Add feature to create subscription from modal

* [MI-2030] Add filter to fetch subscriptions related to project

* [MI-2056]: Fixed create task flow and added user connection check on reload

* [MI-2029_1] Update subscription modal

* [MI-2057] Integrate subscription list page

* Remove nolint comment

* [MI-2060]: Refactor code for release and make required changes

* [MI-2061]: Refactor code base and Explore and implement RTK error handling.

* [MI-2061]: Added logic to handle error/success for multiple API calls at a time

* [MI-2061]: Review fix

* [MI-2061]: lint fixes

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
Co-authored-by: ayusht2810 <ayush.thakur@joshtechnologygroup.com>
@avas27JTG @ayusht2810
[MI-2085]: No projects linked handling on modals and refactor create-… (
c7a920b 
#54)

* [MI-1986]: Create plugin API to fetch linked projects list

* [MI-1987]: Integrated project list UI

* [MI-1987]: Review fixes

* [MI-2001]: [MI-2001]: Create plugin API to unlink project and integrate the UI

* [MI-2001]: Review fixes

* [MI-2002]: Created plugin API to fetch user details and UI integration with other changes

* [MI-2002]: Updated API paths

* [MI-2049]: Added websocket support to detect user connection details and a centralised check for root modals

* [MI-2010]: API to create subscriptions

* [MI-2010] Fix lint errors

* [MI-2035]: Integrated unlinking project from details page

* [MI-1939]: Added refresh token logic

* [MI-2009] API to get list of subscriptions

* [MI-2011] Add API to listen notifications

* [MI-2023] API to delete subscriptions

* [MI-2023] Remove print statement

* [MI-1939]: Fixed statusCode

* [MI-2029] Add feature to create subscription from modal

* [MI-2030] Add filter to fetch subscriptions related to project

* [MI-2056]: Fixed create task flow and added user connection check on reload

* [MI-2029_1] Update subscription modal

* [MI-2057] Integrate subscription list page

* [MI-1939]: Review fixes

* [MI-1939]: Added check for user's oAuth

* [MI-1939]: Added buffer

* Remove nolint comment

* [MI-2060]: Refactor code for release and make required changes

* [MI-1939]: Used epoch time

* [MI-2061]: Refactor code base and Explore and implement RTK error handling.

* [MI-2061]: Added logic to handle error/success for multiple API calls at a time

* [MI-2071]: Auto select drop down values on clicking subscription button

* [MI-2085]: No projects linked handling on modals and refactor create-task-modal

* [MI-2090]: Updated UI from Figma

* [MI-2085]: Review fixes

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
Co-authored-by: ayusht2810 <ayush.thakur@joshtechnologygroup.com>
@ayusht2810 @avas27JTG
[MI-2010]: API to create subscriptions (#32)
03423a7 
* [MI-1986]: Create plugin API to fetch linked projects list

* [MI-1987]: Integrated project list UI

* [MI-1987]: Review fixes

* [MI-2001]: [MI-2001]: Create plugin API to unlink project and integrate the UI

* [MI-2001]: Review fixes

* [MI-2002]: Created plugin API to fetch user details and UI integration with other changes

* [MI-2002]: Updated API paths

* [MI-2049]: Added websocket support to detect user connection details and a centralised check for root modals

* [MI-2010]: API to create subscriptions

* [MI-2010] Fix lint errors

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
@ayusht2810 @avas27JTG
[MI-2009] API to get list of subscriptions (#35)
bffcb47 
* [MI-1986]: Create plugin API to fetch linked projects list

* [MI-1987]: Integrated project list UI

* [MI-1987]: Review fixes

* [MI-2001]: [MI-2001]: Create plugin API to unlink project and integrate the UI

* [MI-2001]: Review fixes

* [MI-2002]: Created plugin API to fetch user details and UI integration with other changes

* [MI-2002]: Review fixes

* [MI-2002]: Updated API paths

* [MI-2049]: Added websocket support to detect user connection details and a centralised check for root modals

* [MI-2010]: API to create subscriptions

* [MI-2010] Fix lint errors

* [MI-2009] API to get list of subscriptions

* [MI-1987]: Review fix

* [MI-1987]: Review fixes

* [MI-2001]: Review fixes

* [MI-2001]: Review fixes

* [MI-2002]: Review fixes

* [MI-2049]: Review fixes

* [MI-2049]: Fixed merge change

* [MI-2049]: Refactored code

* [MI-2010] Review fixes

* [MI-2010] Correct messages

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
@avas27JTG
[MI-2011] Add API to listen notifications (#65)
649b03f 
Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
@avas27JTG
[MI-2023] API to delete subscriptions (#66)
d0dc044 
Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
@avas27JTG
[MI-2029] Add feature to create subscription from modal (#67)
ddbdfa8 
Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
@avas27JTG
[MI-2030] Add filter to fetch subscriptions related to project (#68)
c593bbb 
Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
@avas27JTG
[MI-2057] Integrate subscription list page (#69)
c91a782 
Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
@ayusht2810
[MI-1994] Add interface for the store
738cf4d
@ayusht2810
Merge pull request #44 from Brightscout/MI-1994
415dc9f 
[MI-1994] Add interface for the store
@ayusht2810
[MI-2072] Add testcases for configuration
a9da9d2
@ayusht2810
[MI-2072] Review fixes
d128a2d
@ayusht2810
Merge pull request #47 from Brightscout/MI-2072
44c0b7d 
[MI-2072] Add testcases for configuration
@ayusht2810
[MI-2073] Add test cases for API
d1f900e
@ayusht2810
[MI-2073] Correct ci
72310cc
@ayusht2810
[MI-2073] Review fix
ad531d3
raghavaggarwal2308 and others added 3 commits December 19, 2022 19:30
@raghavaggarwal2308
Bugs fixes and enhancements (#131)
64e83ed 
* [MI-2436] Enhancement: Close any open modal in case user is disconnect from from their azure account in another tab

* [MI-2436] Enhancements: Make the first eventType as default value in subscription modal

* [MI-2439] Enhancements:
1. Update the UI of Boards subscription notifications
2. Change the position of filter popover
3. Change the position of error message on subscription modal
4. Decrease the margin on "Add new subscription" button in RHS
5. Change the link color(Project name on subscription card) in dark theme on MM version 5.37.9

* [MI-2439] Bug fix: Infinite scroll not working in RHS

* [MI-2439] Enhancement and review fixes
1. Displayed the help text when user enters an invalid command
2. Trimmed the comment message in board subscription notification

* [MI-2439] Review fixes

* [MI-2439] Review fix: removed commented code

* [MI-2436] Review fixes
@raghavaggarwal2308
[MI-2428] Enhancement: Change the flow to list subscription: Check fo… (
a6073ba 
#129)

* [MI-2428] Enhancement: Change the flow to list subscription: Check for user id in case or user subscriptions and for project linked in cases of others subscriptions

* [MI-2428] Review fixes
@spirosoik
Migrate from CircleCI to Github actions (#134)
285f6a3 
We can use across all the repositories of plugins and apps
the same reusable workflow which give us the ability to change only one file instead
of multiple and apart from this the ability to use different versions as we prefer.

Ticket: https://mattermost.atlassian.net/browse/CLD-4816
@hanzei hanzei requested a review from srkgupta January 24, 2023 15:19
@mickmister mickmister mentioned this pull request Jan 31, 2023
Closed
srkgupta
srkgupta suggested changes Feb 1, 2023
View reviewed changes
Copy link

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some vulnerabilities were observed and have been reported privately. Please check the JIRA ticket for more details.

@hanzei hanzei linked an issue Feb 15, 2023 that may be closed by this pull request
Release v2.2.2 #126
Closed
3 tasks
@hanzei hanzei mentioned this pull request Feb 15, 2023
Closed
1 task
@hanzei hanzei self-assigned this Feb 15, 2023
@avas27JTG @raghavaggarwal2308 @ayusht2810
[Feature]: Pipelines(phase-3) (#133)
2d2f0ab 
* [MI-2304] Pipeline subscription
1. Updated API to support creating pipeline subscriptions.
2. Updated the UI for subscription modal to display pipeline event types.
3. Updated the UI of subscription card for for displaying pipeline subscriptions.

* [MI-2315] Added slash command to add/list pipeline subscriptions

* [MI-2304] Fixed casing of event type description

* [MI-2321] Created notification post for "Release Created" and "Build Created" event type

* [MI-2321] Added notification post for "Release Abandoned", "Release deployment started" and "Release deployment completed"

* [MI-2321] Added notification post for "Run stage state changed" and "Run state changed" event type

* [MI-2321] Refactored code

* [MI-2321] Removed commented code

* [MI-2321] Removed unused struct

* [MI-2321] Fixed bug: Pull reqest commented event notification not working

* [MI-2339][server]: Added support to show pipeline build link preview.

* [MI-2339][server]: Added mock method for pipeline build

* [MI-2321] Fixed author icon css on notification post

* [MI-2339][server]: Updated error message

* [MI-2343][server+webapp]: Added support to show pipeline release link preview.

* [MI-2304] Review fixes

* [MI-2315] Review fixes

* [MI-2304] Review fixes

* [MI-2345][server+webapp]: Added feature for user to Approve/Reject a pipeline job request from requested user via MM post.

* [MI-2339][server][review_fix]: Minor refactoring

* [MI-2345][server]: Added mock method for UpdatePipelineApprovalRequest

* [MI-2345][server]: Fixed variable name for failing CI

* [MI-2350][server]: Add feature to update status of an already approved/rejected Pipeline release request.

* [MI-2350][server]: Changed variable names to prevent shadow declarations

* [MI-2304] Review fixes

* [MI-2315] Review fixes
1. Created map for displayEventTypes

* [MI-2321] Review fixes

* [MI-2339][server][review_fix]: Added debug logs and changed casings

* [MI-2343][server][review_fix]: Minor refactoring

* [MI-2304] Review fixes
1. Updated screenshots in docs

* [MI-2345][server][review_fix]: Minor refactoring

* [MI-2321] Review fixes

* [MI-2339][server]: Changed pipeline icon name

* [MI-2419][server]: Added support to approve/reject run stage pipeline events.

* [MI-2450] Added testcases and Makefile command to generate mocks
1. TestGetSubscriptionFIlterPossibleValues
2. TestCheckIfUserIsProjectAdmin
3. TestGetBuildDetails
4. TestPostBuildDetailsPreview
5. TestHandleDeleteAllSubscriptions
6. TestHandleGetSubscriptionFilterPossibleValues

* [MI-2450] Added testcases for command.go

* [MI-2450] Delete cover.out file

* [MI-2450] Added some more testcases for command.go

* [MI-2450] Removed cover.out file

* [MI-2456] Added testcases for handleSubscriptionNotification

* [MI-2461] Added testcases for release link preview

* [MI-2450] Self review fix

* [MI-2339][server]: Added support to show pipeline build link preview. (#104)

* [MI-2339][server]: Added support to show pipeline build link preview.

* [MI-2339][server]: Added mock method for pipeline build

* [MI-2339][server]: Updated error message

* [MI-2339][server][review_fix]: Minor refactoring

* [MI-2339][server][review_fix]: Added debug logs and changed casings

* [MI-2339][server]: Changed pipeline icon name

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
Co-authored-by: raghavaggarwal2308 <raghav.aggarwal@brightscout.com>

* [MI-2345][server][review_fix]: Changed place of path variable

* [MI-2350][server][review_fix]: Changed spelling

* [MI-2463] Added testcases for pipeline job request

* [MI-2466] Added testcases for run stage job request feature

* [MI-2463] Added testcases for client.go

* [MI-2466] Updated varible names

* [MI-2467] Updated documentation for pipeline features

* [MI-2462] Moved files in assets to public folder

* [MI-2474] Added comment modal for approving/rejecting pipeline requests

* [MI-2341][webapp+server] Added filters for "Build" and "Release" events (#107)

* [MI-2258]: [server]: Create plugin API to request Azure DevOps and fetch repository list for a project

* [MI-2258][server][review_fix][CI_fix]: review fixes and added mock method.

* [MI-2279][webapp]: Created UI and integrated repository filter for Repos

* [MI-2279][webapp]: Fixed util

* [MI-2279][webapp]: Enhanced UX

* [MI-2262][server]: Created plugin API to request branches for a repo.

* [MI-2262][server]: Added mocked client method

* WIP

* [MI-2284][server+webapp]: Made server changes to add filters as unique identifier and Created UI and integrated target-branch filter support.

* [server+webapp]: Differentiated payload for service-type and Created chip UI for displaying filters on subscription cards.

* [MI-2288][server+webapp]: Changed struct type for publisher inputs

* [MI-2288][server+webapp]: Modified projectID field name

* [MI-2288][webapp]: Added tolltip on chip

* [MI-2288][webapp]: Fixed import order

* [MI-2294][server]: Created plugin API to fetch possible values for subscription filters.

* [MI-2294][server]: Added mocked client function

* [MI-2294][server]: Fixed golint error

* [MI-2314][server+webapp]: Made changes in plugin API for returning filter values and integrate UI subscripton filter flow with API.

* merge changes synced

* [MI-2314][server+Webapp]: Implemented conditional filters for Repos and Area Path for Boards.

* [MI-2294][server][review_fix]: Minor refactoring

* [MI-2294][server][review_fix]: Reverted extra line removal

* [MI-2294][server][review_fix]: used constants and added server log

* [MI-2294][server]: Removed extra mock methods

* [MI-2314][webapp]: Refactoring

* [MI-2314][webapp]: Refactoring

* [MI-2314][MI-2287] Fixed failing testcases

* [MI-2314][webapp]: Exported constant variables

* [MI-2339][server]: Added support to show pipeline build link preview.

* [MI-2339][server]: Added mock method for pipeline build

* [MI-2339][server]: Updated error message

* [MI-2341][webapp+server] Added filters for "Build" and "Release" events
1. Added "Release Pipeline", "Approval Status", "Approval Type", "Stage Name" and "Status" for release events.
2. Added "Build Pipeline" and "Build Status" for build events.
3. Updated the API to get filter values for above events.

* [MI-2341] Changed name of struct field 'ReleaseDefinitionID : ReleasePipeline'

* [MI-2339][server][review_fix]: Minor refactoring

* [MI-2341] Review fixes

* [MI-2339][server][review_fix]: Added debug logs and changed casings

* [MI-2341] Review fix

* [MI-2339][server]: Changed pipeline icon name

* [MI-2341] Review fixes

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [MI-2476] Enhancements:
a. Remove the white background color from the icon on the notification post
b. Remove unused code in ExecuteCommand function in command.go

* [MI-2476] Updated help command for pipelines

* [MI-2360] Updated APIs to create/delete subscriptions and subscription card for "Build" and "Release" events (#110)

* [MI-2258]: [server]: Create plugin API to request Azure DevOps and fetch repository list for a project

* [MI-2258][server][review_fix][CI_fix]: review fixes and added mock method.

* [MI-2279][webapp]: Created UI and integrated repository filter for Repos

* [MI-2279][webapp]: Fixed util

* [MI-2279][webapp]: Enhanced UX

* [MI-2262][server]: Created plugin API to request branches for a repo.

* [MI-2262][server]: Added mocked client method

* WIP

* [MI-2284][server+webapp]: Made server changes to add filters as unique identifier and Created UI and integrated target-branch filter support.

* [server+webapp]: Differentiated payload for service-type and Created chip UI for displaying filters on subscription cards.

* [MI-2288][server+webapp]: Changed struct type for publisher inputs

* [MI-2288][server+webapp]: Modified projectID field name

* [MI-2288][webapp]: Added tolltip on chip

* [MI-2288][webapp]: Fixed import order

* [MI-2294][server]: Created plugin API to fetch possible values for subscription filters.

* [MI-2294][server]: Added mocked client function

* [MI-2294][server]: Fixed golint error

* [MI-2314][server+webapp]: Made changes in plugin API for returning filter values and integrate UI subscripton filter flow with API.

* merge changes synced

* [MI-2314][server+Webapp]: Implemented conditional filters for Repos and Area Path for Boards.

* [MI-2294][server][review_fix]: Minor refactoring

* [MI-2294][server][review_fix]: Reverted extra line removal

* [MI-2294][server][review_fix]: used constants and added server log

* [MI-2294][server]: Removed extra mock methods

* [MI-2314][webapp]: Refactoring

* [MI-2314][webapp]: Refactoring

* [MI-2314][MI-2287] Fixed failing testcases

* [MI-2314][webapp]: Exported constant variables

* [MI-2339][server]: Added support to show pipeline build link preview.

* [MI-2339][server]: Added mock method for pipeline build

* [MI-2339][server]: Updated error message

* [MI-2341][webapp+server] Added filters for "Build" and "Release" events
1. Added "Release Pipeline", "Approval Status", "Approval Type", "Stage Name" and "Status" for release events.
2. Added "Build Pipeline" and "Build Status" for build events.
3. Updated the API to get filter values for above events.

* [MI-2341] Changed name of struct field 'ReleaseDefinitionID : ReleasePipeline'

* [MI-2339][server][review_fix]: Minor refactoring

* [MI-2360] Updated "CreateSubscription" API and subscription card according to pipeline filters

* [MI-2360] Fixed failing testcases

* [MI-2360] Removed redundant code

* [MI-2360] Removed unused code and updated mock_client

* [MI-2341] Review fixes

* [MI-2339][server][review_fix]: Added debug logs and changed casings

* [MI-2341] Review fix

* [MI-2360] Minor fix

* [MI-2339][server]: Changed pipeline icon name

* [MI_2360] Changed name of struct fields

* [MI-2341] Review fixes

* [MI-2360] Generated MD5 hash for subscription key

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [MI-2474] Changed modal title

* [MI-2470] Add dropdown for AreaPath field in create task modal

* [MI-2345][server+webapp]: Added feature for user to Approve/Reject a pipeline job request from requested user via MM post. (#109)

* [MI-2345][server+webapp]: Added feature for user to Approve/Reject a pipeline job request from requested user via MM post.

* [MI-2345][server]: Added mock method for UpdatePipelineApprovalRequest

* [MI-2345][server]: Fixed variable name for failing CI

* [MI-2345][server][review_fix]: Minor refactoring

* [MI-2345][server][review_fix]: Changed place of path variable

* [MI-2345][server][review_fix]: Minor refactoring

* [MI-2345] Fix lint error

* [MI-2350][server]: Added a feature to update the status of an already approved/rejected Pipeline release request. (#111)

* [MI-2350][server]: Add feature to update status of an already approved/rejected Pipeline release request.

* [MI-2350][server]: Changed variable names to prevent shadow declarations

* [MI-2350][server][review_fix]: Changed spelling

* [MI-2350][server][review_fix]: Minor refactoring

* [MI-2350][server][review_fix]: Changed variable name

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
Co-authored-by: raghavaggarwal2308 <raghav.aggarwal@brightscout.com>

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
Co-authored-by: raghavaggarwal2308 <raghav.aggarwal@brightscout.com>

* [MI-2343][server+webapp]: Added support to show pipeline release link preview. (#105)

* [MI-2339][server]: Added support to show pipeline build link preview.

* [MI-2339][server]: Added mock method for pipeline build

* [MI-2339][server]: Updated error message

* [MI-2343][server+webapp]: Added support to show pipeline release link preview.

* [MI-2339][server][review_fix]: Minor refactoring

* [MI-2339][server][review_fix]: Added debug logs and changed casings

* [MI-2343][server][review_fix]: Minor refactoring

* [MI-2339][server]: Changed pipeline icon name

* [MI-2343] Review fix

* [MI-2343][server][review_fix]: Minor refactoring

* [MI-2343] Fix lint errors

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
Co-authored-by: raghavaggarwal2308 <raghav.aggarwal@brightscout.com>

* [MI-2359] Added filters in subscription modal for "Run" events (#118)

* [MI-2258]: [server]: Create plugin API to request Azure DevOps and fetch repository list for a project

* [MI-2258][server][review_fix][CI_fix]: review fixes and added mock method.

* [MI-2279][webapp]: Created UI and integrated repository filter for Repos

* [MI-2279][webapp]: Fixed util

* [MI-2279][webapp]: Enhanced UX

* [MI-2262][server]: Created plugin API to request branches for a repo.

* [MI-2262][server]: Added mocked client method

* WIP

* [MI-2284][server+webapp]: Made server changes to add filters as unique identifier and Created UI and integrated target-branch filter support.

* [server+webapp]: Differentiated payload for service-type and Created chip UI for displaying filters on subscription cards.

* [MI-2288][server+webapp]: Changed struct type for publisher inputs

* [MI-2288][server+webapp]: Modified projectID field name

* [MI-2288][webapp]: Added tolltip on chip

* [MI-2288][webapp]: Fixed import order

* [MI-2294][server]: Created plugin API to fetch possible values for subscription filters.

* [MI-2294][server]: Added mocked client function

* [MI-2294][server]: Fixed golint error

* [MI-2314][server+webapp]: Made changes in plugin API for returning filter values and integrate UI subscripton filter flow with API.

* merge changes synced

* [MI-2314][server+Webapp]: Implemented conditional filters for Repos and Area Path for Boards.

* [MI-2294][server][review_fix]: Minor refactoring

* [MI-2294][server][review_fix]: Reverted extra line removal

* [MI-2294][server][review_fix]: used constants and added server log

* [MI-2294][server]: Removed extra mock methods

* [MI-2314][webapp]: Refactoring

* [MI-2314][webapp]: Refactoring

* [MI-2314][MI-2287] Fixed failing testcases

* [MI-2314][webapp]: Exported constant variables

* [MI-2339][server]: Added support to show pipeline build link preview.

* [MI-2339][server]: Added mock method for pipeline build

* [MI-2339][server]: Updated error message

* [MI-2341][webapp+server] Added filters for "Build" and "Release" events
1. Added "Release Pipeline", "Approval Status", "Approval Type", "Stage Name" and "Status" for release events.
2. Added "Build Pipeline" and "Build Status" for build events.
3. Updated the API to get filter values for above events.

* [MI-2341] Changed name of struct field 'ReleaseDefinitionID : ReleasePipeline'

* [MI-2339][server][review_fix]: Minor refactoring

* [MI-2360] Updated "CreateSubscription" API and subscription card according to pipeline filters

* [MI-2360] Fixed failing testcases

* [MI-2360] Removed redundant code

* [MI-2360] Removed unused code and updated mock_client

* [MI-2341] Review fixes

* [MI-2359] Added filters in subscription modal for "Run" events

* [MI-2339][server][review_fix]: Added debug logs and changed casings

* [MI-2341] Review fix

* [MI-2360] Minor fix

* [MI-2339][server]: Changed pipeline icon name

* [MI_2360] Changed name of struct fields

* [MI-2359] Review fix

* [MI-2359] Fix CI

* [MI-2359] Reset values of resultId and stageId when value of state and pipeline if changed respectively

* [MI-2341] Review fixes

* [MI-2360] Generated MD5 hash for subscription key

* [MI-2361] Updated API to create/delete "Run" event subscriptions with… (#120)

* [MI-2361] Updated API to create/delete "Run" event subscriptions with filters

* [MI-2361] Review fixes

* [MI-2359] Review fixes

* [MI-2410] Updated subscription card to display run event filters and filter popover for pipelines (#123)

* [MI-2361] Updated API to create/delete "Run" event subscriptions with filters

* [MI-2410] Updated subscription card to display run event filters

* [MI-2410] Updated the filter popover for pipelines

* [MI-2361] Review fixes

* [MI-2410] Review fixes

* [MI-2410] Review fix

* [MI-2410] Review fix

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [MI-2467] Review fixes

* [MI-2419][server]: Added support to approve/reject run stage pipeline events. (#3)

* [MI-2345][server+webapp]: Added feature for user to Approve/Reject a pipeline job request from requested user via MM post.

* [MI-2345][server]: Added mock method for UpdatePipelineApprovalRequest

* [MI-2345][server]: Fixed variable name for failing CI

* [MI-2350][server]: Add feature to update status of an already approved/rejected Pipeline release request.

* [MI-2350][server]: Changed variable names to prevent shadow declarations

* [MI-2345][server][review_fix]: Minor refactoring

* [MI-2419][server]: Added support to approve/reject run stage pipeline events.

* [MI-2419][server][review_fix]: Minor refactoring and error handling

* [MI-2419][server][review_fix]: Minor refactoring

* [MI-2419][server]: Added loader message post for release requests

* [MI-2447][server]: Created slack attachment for pipelines release/run approval completion. (#5)

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
Co-authored-by: raghavaggarwal2308 <raghav.aggarwal@brightscout.com>

* [MI-2467] Review fix

Co-authored-by: Abhishek Verma <72438220+avas27JTG@users.noreply.github.com>

* [MI-2495] Removed unused code

* [MI-2495] Minor bug fixes

* [MI-2495] Reset unlink confirmation modal error state on hide.

* [Fix]: Fixed organization name for Pipelines (#132)

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [MI-2495] Code refactor

* [MI-2495] Bump plugin version to v3.0.0

* [MI-2495] Review fix

* [MI-2476] Review fix

Co-authored-by: Ayush Thakur <100013900+ayusht2810@users.noreply.github.com>

* [MI-2462] Review fix
1. Created assets folder in public folder

* [MI-2462] Changed plugin version on plugin.go

* [MI-2450] Fix testcases

* [MI-2450] Review fixes

* [MI-2456] Review fixes

* [MI-2461] Review fixes

* [MI-2461] Removed unused image

* Fixed lint error

* [MI-2463] Removed unused code

* [MI-2463] Fix testcases

* [MI-2466] Changed name of testcases

* [MI-2462] Fix errors

* [MI-2476] Fix invalid command constant

* [MI-2450] Review fixes

* [MI-2461] Review fixes

* [MI-2463] Review fixes

* [MI-2466] Review fixes

* [MI-2461] Review fixes

* [MI-2474] Review fixes

* [MI-2470] Review fixes

* [MI-2450] Review fixes

* [MI-2474] Review fixes

* [MI-2461] Review fixes

* [MI-2470] Review fix

Co-authored-by: Abhishek Verma <72438220+avas27JTG@users.noreply.github.com>

* [MI-2524] Fix and add testcases on branch MI-2474

* [MI-2524] Review fixes

* [MI-2524] Review fixes

* Bump plugin verstion to v3.1.0

* [MI-2504][server+webapp]: Generated manifest files and Changed "Hide" to "Close" on filter popover. (#17) (#21)

* [MI-2504][webapp]: Changed Hide to Close on filter popover

* [MI-2504][server]: Generated manifest files

* [MI-2504][server]: Updated version in manifest

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [Fix]: Fixed Circle CI

* [Fix]: Fixed manifest file

* [MI-2511] Created constants for common mocks

* [MI-2511] Review fixes

* [MI-2511] Review fix

* [MI-2611]: Fixed modals not opening on multiple clients in case of cloud servers (#25)

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [MI-2505]: Added logic to protect subscriptions notification webhook API and fixed Boards update subscription. (#22)

* [MI-2505][server]: Added logic to protect subscriptions notification webhook API and fixed Boards update subscription.

* [MI-2505][MI-2518] Fix failing testcases

* [MI-2505]:Added webhook secret encoding and review fixes

* [MI-2505]:Added webhook secret encryption

* [MI-2505]: Fixed CI

* [MI-2505]: Reverted change of auth scopes

* [MI-2505]: Fixed CI

* [MI-2505][MI-2603] Fixed testcases

* [MI-2505]: Used constant for path

* [MI-2505]: Refinded message

* [MI-2505]: Minor review fixes

* [MI-2505][MI-2603] Review fix

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
Co-authored-by: raghavaggarwal2308 <raghav.aggarwal@brightscout.com>

* [MI-2613]: Fixed resetting error message on Link modal, showing descr… (#26)

* [MI-2611]: Fixed modals not opening on multiple clients in case of cloud servers

* [MI-2613]: Fixed resetting error message on Link modal, showing descriptive error messages on UI and handling modals if account is not connected

* [MI-2613]: Fixed channel validation for DMs

* [MI-2613]: Added checks for filter API calls and user friendly error message

* [MI-2613]: Added logic to check if a subscription is not found on the Azure DevOps portal then delete it from the Mattermost's KV store

* [MI-2613]: Review fixes

* [MI-2613]: Review fixes

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [MI-2621]: Created font icons for subscription card and changed subscription titles to default color. (#27)

* [MI-2611]: Fixed modals not opening on multiple clients in case of cloud servers

* [MI-2613]: Fixed resetting error message on Link modal, showing descriptive error messages on UI and handling modals if account is not connected

* [MI-2613]: Fixed channel validation for DMs

* [MI-2613]: Added checks for filter API calls and user friendly error message

* [MI-2613]: Added logic to check if a subscription is not found on the Azure DevOps portal then delete it from the Mattermost's KV store

* [MI-2621]: Created font icons for subscription card and changed subscription titles to default color.

* [MI-2621]: Fixed test cases

* [MI-2621]: Fixed test cases

* [MI-2621]: Refactoring

* [MI-2621]: Added tooltip on project list card

* [MI-2621]: Fixed test cases

* [MI-2621]: Review fix

* [MI-2651]: Changed texts for work-item, added workitem in boards command, changed plugin name (#28)

* [MI-2651]: Changed texts for work-item, added workitem in boards command, changed plugin name

* [MI-2651]: Changed texts

* [MI-2651]: Made anyone as default arg for subscription list

* [MI-2651]: Added azd prefix for modal classes

* [MI-2651]: Added CSS util classes

* [MI-2651]: Fixed test cases

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [Review fix]: Removed unused files

* [MI-2669]: Added some key-values in plugin.json file and created separate functions for custom error components (#30)

* Added some key-values in plugin.json file and created separate functions for custom error components

* [MI-2669]: Added block lines

---------

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [MI-2672]: Removed consumerInput form subscription response, added validation to check channel access (#29)

* [MI-2672]: Removed consumerInput form subscription response, added validation to check channel access

* [MI-2672]: Fixed lint

* [MI-2672]: Fixed lint

* [MI-2672]: Added check for DM and groups with minor refactoring

* [MI-2672]: Review fixes

* [MI-2672]: Changed variable

* [MI-2672]: Fixed test case

---------

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [Fix]: Updated manifest file

* [MI-2669]: Made changes for subscriptionID to be used as key for KV-s… (#33)

* [MI-2669]: Made changes for subscriptionID to be used as key for KV-store, sorted subscriptions on basis of createdAt, users cannot see subscriptions of not participating channels

* [MI-2669]: Modified comment

---------

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [MI-2669_1]: Added a top level CSS class as a unique selector (#31)

* [MI-2669_1]: Added a top level CSS class as a unique selector

* [MI-2669]: Added top level class selector for components and review fixes

---------

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [MI-2669]: Created a hook for intercepting redux changes and moved the central login into it, formatted code (#32)

* [MI-2669]: Created a hook for intercepting redux changes and moved the central login into it, formatted code

* [MI-2669]: Modified comment

* [MI-2669]: Review fixes

---------

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [Refactor]: Removed unused util

* [MI-2669]: Created hook to fetch and load filters (#34)

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [Fix]: Moved subscriptionID field at the top in struct

* [MI-2748]: Implemented 1:1 mapping between MM user and Azure DevOps user for oAuth. (#35)

* [MI-2748]: Implemented 1:1 mapping between MM user and Azure DevOps user for oAuth.

* [MI-2748]: Added 1 test case and http response code

* [MI-2748]: Fixed condition

* [MI-2748]: Fixed token refresh logic

* [MI-2748]: Fixed CI

* [MI-2748]: Fixed CI

* [MI-2748]: Review fixes

* [MI-2748]: Fixed CI

* [MI-2748]: Review fixes

* [MI-2748]: Review fixes

---------

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [MI-2750]: Implemented fetching channel list on webapp and removes from plugin's server. (#36)

* [MI-2750]: Implemented fetching channel list on webapp and remove from plugin's server.

* [MI-2750]: Review fixes

* [MI-2750]: Changed comment message

---------

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [MI-2765]: Used @mattermost/client for making webapp calls to MM server (#37)

* [MI-2765]: Used @mattermost/client for making webapp calls to MM server

* [MI-2765]: Review fix

* [MI-2765]: Review fix

* [MI-2765]: Removed Mattermost API call RTK service

* [MI-2765]: Fixed CI

---------

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

---------

Co-authored-by: raghavaggarwal2308 <raghav.aggarwal@brightscout.com>
Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
Co-authored-by: Ayush Thakur <100013900+ayusht2810@users.noreply.github.com>
mickmister
mickmister reviewed Feb 27, 2023
View reviewed changes
server/plugin/client.go
Comment on lines +521 to +525
errResp := ErrorResponse{}
if err = json.Unmarshal(responseData, &errResp); err != nil {
return responseData, http.StatusInternalServerError, errors.WithMessagef(err, "status: %s", resp.Status)
}
return responseData, resp.StatusCode, fmt.Errorf("errorMessage %s", errResp.Message)
Copy link
Contributor

@mickmister mickmister Feb 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this type:

type ErrorResponse struct {
	Message string `json:"message"`
}

As long as the response is valid JSON data, and it doesn't contain a message field that has a type other than string, this if block won't ever run. In other words, message is not necessarily defined when the marshal error does not occur. I'm thinking we should include the response code here since we potentially don't have an error message to use in this case.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bringing this up because there was an OAuth error @DHaussermann ran into when there was a configuration error for the app on Azure's side. The error message was blank so it read as: errorMessage with no message afterwards.

avas27JTG and others added 7 commits March 21, 2023 21:26
@avas27JTG @raghavaggarwal2308
[MM-51250]: Added max limit for reading responses (#147)
51e31f9 
Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
Co-authored-by: raghavaggarwal2308 <raghav.aggarwal@brightscout.com>
@avas27JTG @raghavaggarwal2308
[MM-51253][MM-51275]: Added check for full name and refactored error …
c9399d6 
…logs. (#148)

* [MI-2504][server+webapp]: Generated manifest files and Changed "Hide" to "Close" on filter popover. (#17) (#21)

* [MI-2504][webapp]: Changed Hide to Close on filter popover

* [MI-2504][server]: Generated manifest files

* [MI-2504][server]: Updated version in manifest

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [MI-2505]: Added logic to protect subscriptions notification webhook API and fixed Boards update subscription. (#22)

* [MI-2505][server]: Added logic to protect subscriptions notification webhook API and fixed Boards update subscription.

* [MI-2505][MI-2518] Fix failing testcases

* [MI-2505]:Added webhook secret encoding and review fixes

* [MI-2505]:Added webhook secret encryption

* [MI-2505]: Fixed CI

* [MI-2505]: Reverted change of auth scopes

* [MI-2505]: Fixed CI

* [MI-2505][MI-2603] Fixed testcases

* [MI-2505]: Used constant for path

* [MI-2505]: Refinded message

* [MI-2505]: Minor review fixes

* [MI-2505][MI-2603] Review fix

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
Co-authored-by: raghavaggarwal2308 <raghav.aggarwal@brightscout.com>

* [Fix]: Updated plugin version in manifest file

* [MM-51253]: Add check for showing user's fullname on subscription details

* [MM-51253]: Modified test case

* [MM-51275]: modified flow

* [MM-51253]: Review fix

* [MM-51253]: Added check for user id

* [MI-2858]: Modified test cases

---------

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
Co-authored-by: raghavaggarwal2308 <raghav.aggarwal@brightscout.com>
@avas27JTG @raghavaggarwal2308
[MM-51247][MM-51248]: Added validations for path inputs and fixed typ…
f499afd 
…o. (#149)

* [MI-2504][server+webapp]: Generated manifest files and Changed "Hide" to "Close" on filter popover. (#17) (#21)

* [MI-2504][webapp]: Changed Hide to Close on filter popover

* [MI-2504][server]: Generated manifest files

* [MI-2504][server]: Updated version in manifest

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [MI-2505]: Added logic to protect subscriptions notification webhook API and fixed Boards update subscription. (#22)

* [MI-2505][server]: Added logic to protect subscriptions notification webhook API and fixed Boards update subscription.

* [MI-2505][MI-2518] Fix failing testcases

* [MI-2505]:Added webhook secret encoding and review fixes

* [MI-2505]:Added webhook secret encryption

* [MI-2505]: Fixed CI

* [MI-2505]: Reverted change of auth scopes

* [MI-2505]: Fixed CI

* [MI-2505][MI-2603] Fixed testcases

* [MI-2505]: Used constant for path

* [MI-2505]: Refinded message

* [MI-2505]: Minor review fixes

* [MI-2505][MI-2603] Review fix

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
Co-authored-by: raghavaggarwal2308 <raghav.aggarwal@brightscout.com>

* [Fix]: Updated plugin version in manifest file

* [MM-51247]: Added check for URL

* [MM-51248]: Review fix

* [MM-51247]: Used path.Clean function for url paths

* [MI-51247]: Added util method to sanitize url path and test case for it

* [MI-51247]: Fixed lint

* [MI-51247]: Added handling for encoded URL path for traversal

* [MI-51247]: Added logic to check combination of dots in string

* [MM-51247]: Added validation for URL path inputs

* [MM-51247]: Added check for char '\'

* [MM-51247]: Added missing checks

---------

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
Co-authored-by: raghavaggarwal2308 <raghav.aggarwal@brightscout.com>
@avas27JTG @raghavaggarwal2308
[MI-51272]: Refactored and removed unused code. (#150)
b866a70 
* [MI-2504][server+webapp]: Generated manifest files and Changed "Hide" to "Close" on filter popover. (#17) (#21)

* [MI-2504][webapp]: Changed Hide to Close on filter popover

* [MI-2504][server]: Generated manifest files

* [MI-2504][server]: Updated version in manifest

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [MI-2505]: Added logic to protect subscriptions notification webhook API and fixed Boards update subscription. (#22)

* [MI-2505][server]: Added logic to protect subscriptions notification webhook API and fixed Boards update subscription.

* [MI-2505][MI-2518] Fix failing testcases

* [MI-2505]:Added webhook secret encoding and review fixes

* [MI-2505]:Added webhook secret encryption

* [MI-2505]: Fixed CI

* [MI-2505]: Reverted change of auth scopes

* [MI-2505]: Fixed CI

* [MI-2505][MI-2603] Fixed testcases

* [MI-2505]: Used constant for path

* [MI-2505]: Refinded message

* [MI-2505]: Minor review fixes

* [MI-2505][MI-2603] Review fix

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
Co-authored-by: raghavaggarwal2308 <raghav.aggarwal@brightscout.com>

* [Fix]: Updated plugin version in manifest file

* [MI-51272]: Removed unused code

* [MI-51272]: Handled non base64 chars for webhooksecret

* [MI-51272]: escaped webhook secret query param chars

* [MI-51272]: Changed function name

* [MI-51247]: Used  directly for webhook secret

---------

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
Co-authored-by: raghavaggarwal2308 <raghav.aggarwal@brightscout.com>
@avas27JTG @raghavaggarwal2308 @ayusht2810
[MI-2820]: Modified API endpoint to require a project to be provided (#…
4f8e0b0 
…144)

* [MI-2304] Pipeline subscription
1. Updated API to support creating pipeline subscriptions.
2. Updated the UI for subscription modal to display pipeline event types.
3. Updated the UI of subscription card for for displaying pipeline subscriptions.

* [MI-2315] Added slash command to add/list pipeline subscriptions

* [MI-2304] Fixed casing of event type description

* [MI-2321] Created notification post for "Release Created" and "Build Created" event type

* [MI-2321] Added notification post for "Release Abandoned", "Release deployment started" and "Release deployment completed"

* [MI-2321] Added notification post for "Run stage state changed" and "Run state changed" event type

* [MI-2321] Refactored code

* [MI-2321] Removed commented code

* [MI-2321] Removed unused struct

* [MI-2321] Fixed bug: Pull reqest commented event notification not working

* [MI-2339][server]: Added support to show pipeline build link preview.

* [MI-2339][server]: Added mock method for pipeline build

* [MI-2321] Fixed author icon css on notification post

* [MI-2339][server]: Updated error message

* [MI-2343][server+webapp]: Added support to show pipeline release link preview.

* [MI-2304] Review fixes

* [MI-2315] Review fixes

* [MI-2304] Review fixes

* [MI-2345][server+webapp]: Added feature for user to Approve/Reject a pipeline job request from requested user via MM post.

* [MI-2339][server][review_fix]: Minor refactoring

* [MI-2345][server]: Added mock method for UpdatePipelineApprovalRequest

* [MI-2345][server]: Fixed variable name for failing CI

* [MI-2350][server]: Add feature to update status of an already approved/rejected Pipeline release request.

* [MI-2350][server]: Changed variable names to prevent shadow declarations

* [MI-2304] Review fixes

* [MI-2315] Review fixes
1. Created map for displayEventTypes

* [MI-2321] Review fixes

* [MI-2339][server][review_fix]: Added debug logs and changed casings

* [MI-2343][server][review_fix]: Minor refactoring

* [MI-2304] Review fixes
1. Updated screenshots in docs

* [MI-2345][server][review_fix]: Minor refactoring

* [MI-2321] Review fixes

* [MI-2339][server]: Changed pipeline icon name

* [MI-2419][server]: Added support to approve/reject run stage pipeline events.

* [MI-2450] Added testcases and Makefile command to generate mocks
1. TestGetSubscriptionFIlterPossibleValues
2. TestCheckIfUserIsProjectAdmin
3. TestGetBuildDetails
4. TestPostBuildDetailsPreview
5. TestHandleDeleteAllSubscriptions
6. TestHandleGetSubscriptionFilterPossibleValues

* [MI-2450] Added testcases for command.go

* [MI-2450] Delete cover.out file

* [MI-2450] Added some more testcases for command.go

* [MI-2450] Removed cover.out file

* [MI-2456] Added testcases for handleSubscriptionNotification

* [MI-2461] Added testcases for release link preview

* [MI-2450] Self review fix

* [MI-2339][server]: Added support to show pipeline build link preview. (#104)

* [MI-2339][server]: Added support to show pipeline build link preview.

* [MI-2339][server]: Added mock method for pipeline build

* [MI-2339][server]: Updated error message

* [MI-2339][server][review_fix]: Minor refactoring

* [MI-2339][server][review_fix]: Added debug logs and changed casings

* [MI-2339][server]: Changed pipeline icon name

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
Co-authored-by: raghavaggarwal2308 <raghav.aggarwal@brightscout.com>

* [MI-2345][server][review_fix]: Changed place of path variable

* [MI-2350][server][review_fix]: Changed spelling

* [MI-2463] Added testcases for pipeline job request

* [MI-2466] Added testcases for run stage job request feature

* [MI-2463] Added testcases for client.go

* [MI-2466] Updated varible names

* [MI-2467] Updated documentation for pipeline features

* [MI-2462] Moved files in assets to public folder

* [MI-2474] Added comment modal for approving/rejecting pipeline requests

* [MI-2341][webapp+server] Added filters for "Build" and "Release" events (#107)

* [MI-2258]: [server]: Create plugin API to request Azure DevOps and fetch repository list for a project

* [MI-2258][server][review_fix][CI_fix]: review fixes and added mock method.

* [MI-2279][webapp]: Created UI and integrated repository filter for Repos

* [MI-2279][webapp]: Fixed util

* [MI-2279][webapp]: Enhanced UX

* [MI-2262][server]: Created plugin API to request branches for a repo.

* [MI-2262][server]: Added mocked client method

* WIP

* [MI-2284][server+webapp]: Made server changes to add filters as unique identifier and Created UI and integrated target-branch filter support.

* [server+webapp]: Differentiated payload for service-type and Created chip UI for displaying filters on subscription cards.

* [MI-2288][server+webapp]: Changed struct type for publisher inputs

* [MI-2288][server+webapp]: Modified projectID field name

* [MI-2288][webapp]: Added tolltip on chip

* [MI-2288][webapp]: Fixed import order

* [MI-2294][server]: Created plugin API to fetch possible values for subscription filters.

* [MI-2294][server]: Added mocked client function

* [MI-2294][server]: Fixed golint error

* [MI-2314][server+webapp]: Made changes in plugin API for returning filter values and integrate UI subscripton filter flow with API.

* merge changes synced

* [MI-2314][server+Webapp]: Implemented conditional filters for Repos and Area Path for Boards.

* [MI-2294][server][review_fix]: Minor refactoring

* [MI-2294][server][review_fix]: Reverted extra line removal

* [MI-2294][server][review_fix]: used constants and added server log

* [MI-2294][server]: Removed extra mock methods

* [MI-2314][webapp]: Refactoring

* [MI-2314][webapp]: Refactoring

* [MI-2314][MI-2287] Fixed failing testcases

* [MI-2314][webapp]: Exported constant variables

* [MI-2339][server]: Added support to show pipeline build link preview.

* [MI-2339][server]: Added mock method for pipeline build

* [MI-2339][server]: Updated error message

* [MI-2341][webapp+server] Added filters for "Build" and "Release" events
1. Added "Release Pipeline", "Approval Status", "Approval Type", "Stage Name" and "Status" for release events.
2. Added "Build Pipeline" and "Build Status" for build events.
3. Updated the API to get filter values for above events.

* [MI-2341] Changed name of struct field 'ReleaseDefinitionID : ReleasePipeline'

* [MI-2339][server][review_fix]: Minor refactoring

* [MI-2341] Review fixes

* [MI-2339][server][review_fix]: Added debug logs and changed casings

* [MI-2341] Review fix

* [MI-2339][server]: Changed pipeline icon name

* [MI-2341] Review fixes

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [MI-2476] Enhancements:
a. Remove the white background color from the icon on the notification post
b. Remove unused code in ExecuteCommand function in command.go

* [MI-2476] Updated help command for pipelines

* [MI-2360] Updated APIs to create/delete subscriptions and subscription card for "Build" and "Release" events (#110)

* [MI-2258]: [server]: Create plugin API to request Azure DevOps and fetch repository list for a project

* [MI-2258][server][review_fix][CI_fix]: review fixes and added mock method.

* [MI-2279][webapp]: Created UI and integrated repository filter for Repos

* [MI-2279][webapp]: Fixed util

* [MI-2279][webapp]: Enhanced UX

* [MI-2262][server]: Created plugin API to request branches for a repo.

* [MI-2262][server]: Added mocked client method

* WIP

* [MI-2284][server+webapp]: Made server changes to add filters as unique identifier and Created UI and integrated target-branch filter support.

* [server+webapp]: Differentiated payload for service-type and Created chip UI for displaying filters on subscription cards.

* [MI-2288][server+webapp]: Changed struct type for publisher inputs

* [MI-2288][server+webapp]: Modified projectID field name

* [MI-2288][webapp]: Added tolltip on chip

* [MI-2288][webapp]: Fixed import order

* [MI-2294][server]: Created plugin API to fetch possible values for subscription filters.

* [MI-2294][server]: Added mocked client function

* [MI-2294][server]: Fixed golint error

* [MI-2314][server+webapp]: Made changes in plugin API for returning filter values and integrate UI subscripton filter flow with API.

* merge changes synced

* [MI-2314][server+Webapp]: Implemented conditional filters for Repos and Area Path for Boards.

* [MI-2294][server][review_fix]: Minor refactoring

* [MI-2294][server][review_fix]: Reverted extra line removal

* [MI-2294][server][review_fix]: used constants and added server log

* [MI-2294][server]: Removed extra mock methods

* [MI-2314][webapp]: Refactoring

* [MI-2314][webapp]: Refactoring

* [MI-2314][MI-2287] Fixed failing testcases

* [MI-2314][webapp]: Exported constant variables

* [MI-2339][server]: Added support to show pipeline build link preview.

* [MI-2339][server]: Added mock method for pipeline build

* [MI-2339][server]: Updated error message

* [MI-2341][webapp+server] Added filters for "Build" and "Release" events
1. Added "Release Pipeline", "Approval Status", "Approval Type", "Stage Name" and "Status" for release events.
2. Added "Build Pipeline" and "Build Status" for build events.
3. Updated the API to get filter values for above events.

* [MI-2341] Changed name of struct field 'ReleaseDefinitionID : ReleasePipeline'

* [MI-2339][server][review_fix]: Minor refactoring

* [MI-2360] Updated "CreateSubscription" API and subscription card according to pipeline filters

* [MI-2360] Fixed failing testcases

* [MI-2360] Removed redundant code

* [MI-2360] Removed unused code and updated mock_client

* [MI-2341] Review fixes

* [MI-2339][server][review_fix]: Added debug logs and changed casings

* [MI-2341] Review fix

* [MI-2360] Minor fix

* [MI-2339][server]: Changed pipeline icon name

* [MI_2360] Changed name of struct fields

* [MI-2341] Review fixes

* [MI-2360] Generated MD5 hash for subscription key

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [MI-2474] Changed modal title

* [MI-2470] Add dropdown for AreaPath field in create task modal

* [MI-2345][server+webapp]: Added feature for user to Approve/Reject a pipeline job request from requested user via MM post. (#109)

* [MI-2345][server+webapp]: Added feature for user to Approve/Reject a pipeline job request from requested user via MM post.

* [MI-2345][server]: Added mock method for UpdatePipelineApprovalRequest

* [MI-2345][server]: Fixed variable name for failing CI

* [MI-2345][server][review_fix]: Minor refactoring

* [MI-2345][server][review_fix]: Changed place of path variable

* [MI-2345][server][review_fix]: Minor refactoring

* [MI-2345] Fix lint error

* [MI-2350][server]: Added a feature to update the status of an already approved/rejected Pipeline release request. (#111)

* [MI-2350][server]: Add feature to update status of an already approved/rejected Pipeline release request.

* [MI-2350][server]: Changed variable names to prevent shadow declarations

* [MI-2350][server][review_fix]: Changed spelling

* [MI-2350][server][review_fix]: Minor refactoring

* [MI-2350][server][review_fix]: Changed variable name

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
Co-authored-by: raghavaggarwal2308 <raghav.aggarwal@brightscout.com>

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
Co-authored-by: raghavaggarwal2308 <raghav.aggarwal@brightscout.com>

* [MI-2343][server+webapp]: Added support to show pipeline release link preview. (#105)

* [MI-2339][server]: Added support to show pipeline build link preview.

* [MI-2339][server]: Added mock method for pipeline build

* [MI-2339][server]: Updated error message

* [MI-2343][server+webapp]: Added support to show pipeline release link preview.

* [MI-2339][server][review_fix]: Minor refactoring

* [MI-2339][server][review_fix]: Added debug logs and changed casings

* [MI-2343][server][review_fix]: Minor refactoring

* [MI-2339][server]: Changed pipeline icon name

* [MI-2343] Review fix

* [MI-2343][server][review_fix]: Minor refactoring

* [MI-2343] Fix lint errors

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
Co-authored-by: raghavaggarwal2308 <raghav.aggarwal@brightscout.com>

* [MI-2359] Added filters in subscription modal for "Run" events (#118)

* [MI-2258]: [server]: Create plugin API to request Azure DevOps and fetch repository list for a project

* [MI-2258][server][review_fix][CI_fix]: review fixes and added mock method.

* [MI-2279][webapp]: Created UI and integrated repository filter for Repos

* [MI-2279][webapp]: Fixed util

* [MI-2279][webapp]: Enhanced UX

* [MI-2262][server]: Created plugin API to request branches for a repo.

* [MI-2262][server]: Added mocked client method

* WIP

* [MI-2284][server+webapp]: Made server changes to add filters as unique identifier and Created UI and integrated target-branch filter support.

* [server+webapp]: Differentiated payload for service-type and Created chip UI for displaying filters on subscription cards.

* [MI-2288][server+webapp]: Changed struct type for publisher inputs

* [MI-2288][server+webapp]: Modified projectID field name

* [MI-2288][webapp]: Added tolltip on chip

* [MI-2288][webapp]: Fixed import order

* [MI-2294][server]: Created plugin API to fetch possible values for subscription filters.

* [MI-2294][server]: Added mocked client function

* [MI-2294][server]: Fixed golint error

* [MI-2314][server+webapp]: Made changes in plugin API for returning filter values and integrate UI subscripton filter flow with API.

* merge changes synced

* [MI-2314][server+Webapp]: Implemented conditional filters for Repos and Area Path for Boards.

* [MI-2294][server][review_fix]: Minor refactoring

* [MI-2294][server][review_fix]: Reverted extra line removal

* [MI-2294][server][review_fix]: used constants and added server log

* [MI-2294][server]: Removed extra mock methods

* [MI-2314][webapp]: Refactoring

* [MI-2314][webapp]: Refactoring

* [MI-2314][MI-2287] Fixed failing testcases

* [MI-2314][webapp]: Exported constant variables

* [MI-2339][server]: Added support to show pipeline build link preview.

* [MI-2339][server]: Added mock method for pipeline build

* [MI-2339][server]: Updated error message

* [MI-2341][webapp+server] Added filters for "Build" and "Release" events
1. Added "Release Pipeline", "Approval Status", "Approval Type", "Stage Name" and "Status" for release events.
2. Added "Build Pipeline" and "Build Status" for build events.
3. Updated the API to get filter values for above events.

* [MI-2341] Changed name of struct field 'ReleaseDefinitionID : ReleasePipeline'

* [MI-2339][server][review_fix]: Minor refactoring

* [MI-2360] Updated "CreateSubscription" API and subscription card according to pipeline filters

* [MI-2360] Fixed failing testcases

* [MI-2360] Removed redundant code

* [MI-2360] Removed unused code and updated mock_client

* [MI-2341] Review fixes

* [MI-2359] Added filters in subscription modal for "Run" events

* [MI-2339][server][review_fix]: Added debug logs and changed casings

* [MI-2341] Review fix

* [MI-2360] Minor fix

* [MI-2339][server]: Changed pipeline icon name

* [MI_2360] Changed name of struct fields

* [MI-2359] Review fix

* [MI-2359] Fix CI

* [MI-2359] Reset values of resultId and stageId when value of state and pipeline if changed respectively

* [MI-2341] Review fixes

* [MI-2360] Generated MD5 hash for subscription key

* [MI-2361] Updated API to create/delete "Run" event subscriptions with… (#120)

* [MI-2361] Updated API to create/delete "Run" event subscriptions with filters

* [MI-2361] Review fixes

* [MI-2359] Review fixes

* [MI-2410] Updated subscription card to display run event filters and filter popover for pipelines (#123)

* [MI-2361] Updated API to create/delete "Run" event subscriptions with filters

* [MI-2410] Updated subscription card to display run event filters

* [MI-2410] Updated the filter popover for pipelines

* [MI-2361] Review fixes

* [MI-2410] Review fixes

* [MI-2410] Review fix

* [MI-2410] Review fix

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [MI-2467] Review fixes

* [MI-2419][server]: Added support to approve/reject run stage pipeline events. (#3)

* [MI-2345][server+webapp]: Added feature for user to Approve/Reject a pipeline job request from requested user via MM post.

* [MI-2345][server]: Added mock method for UpdatePipelineApprovalRequest

* [MI-2345][server]: Fixed variable name for failing CI

* [MI-2350][server]: Add feature to update status of an already approved/rejected Pipeline release request.

* [MI-2350][server]: Changed variable names to prevent shadow declarations

* [MI-2345][server][review_fix]: Minor refactoring

* [MI-2419][server]: Added support to approve/reject run stage pipeline events.

* [MI-2419][server][review_fix]: Minor refactoring and error handling

* [MI-2419][server][review_fix]: Minor refactoring

* [MI-2419][server]: Added loader message post for release requests

* [MI-2447][server]: Created slack attachment for pipelines release/run approval completion. (#5)

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
Co-authored-by: raghavaggarwal2308 <raghav.aggarwal@brightscout.com>

* [MI-2467] Review fix

Co-authored-by: Abhishek Verma <72438220+avas27JTG@users.noreply.github.com>

* [MI-2495] Removed unused code

* [MI-2495] Minor bug fixes

* [MI-2495] Reset unlink confirmation modal error state on hide.

* [Fix]: Fixed organization name for Pipelines (#132)

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [MI-2495] Code refactor

* [MI-2495] Bump plugin version to v3.0.0

* [MI-2495] Review fix

* [MI-2476] Review fix

Co-authored-by: Ayush Thakur <100013900+ayusht2810@users.noreply.github.com>

* [MI-2462] Review fix
1. Created assets folder in public folder

* [MI-2462] Changed plugin version on plugin.go

* [MI-2450] Fix testcases

* [MI-2450] Review fixes

* [MI-2456] Review fixes

* [MI-2461] Review fixes

* [MI-2461] Removed unused image

* Fixed lint error

* [MI-2463] Removed unused code

* [MI-2463] Fix testcases

* [MI-2466] Changed name of testcases

* [MI-2462] Fix errors

* [MI-2476] Fix invalid command constant

* [MI-2450] Review fixes

* [MI-2461] Review fixes

* [MI-2463] Review fixes

* [MI-2466] Review fixes

* [MI-2461] Review fixes

* [MI-2474] Review fixes

* [MI-2470] Review fixes

* [MI-2450] Review fixes

* [MI-2474] Review fixes

* [MI-2461] Review fixes

* [MI-2470] Review fix

Co-authored-by: Abhishek Verma <72438220+avas27JTG@users.noreply.github.com>

* [MI-2524] Fix and add testcases on branch MI-2474

* [MI-2524] Review fixes

* [MI-2524] Review fixes

* Bump plugin verstion to v3.1.0

* [MI-2504][server+webapp]: Generated manifest files and Changed "Hide" to "Close" on filter popover. (#17) (#21)

* [MI-2504][webapp]: Changed Hide to Close on filter popover

* [MI-2504][server]: Generated manifest files

* [MI-2504][server]: Updated version in manifest

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [Fix]: Fixed Circle CI

* [Fix]: Fixed manifest file

* [MI-2511] Created constants for common mocks

* [MI-2511] Review fixes

* [MI-2511] Review fix

* [MI-2611]: Fixed modals not opening on multiple clients in case of cloud servers (#25)

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [MI-2505]: Added logic to protect subscriptions notification webhook API and fixed Boards update subscription. (#22)

* [MI-2505][server]: Added logic to protect subscriptions notification webhook API and fixed Boards update subscription.

* [MI-2505][MI-2518] Fix failing testcases

* [MI-2505]:Added webhook secret encoding and review fixes

* [MI-2505]:Added webhook secret encryption

* [MI-2505]: Fixed CI

* [MI-2505]: Reverted change of auth scopes

* [MI-2505]: Fixed CI

* [MI-2505][MI-2603] Fixed testcases

* [MI-2505]: Used constant for path

* [MI-2505]: Refinded message

* [MI-2505]: Minor review fixes

* [MI-2505][MI-2603] Review fix

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
Co-authored-by: raghavaggarwal2308 <raghav.aggarwal@brightscout.com>

* [MI-2613]: Fixed resetting error message on Link modal, showing descr… (#26)

* [MI-2611]: Fixed modals not opening on multiple clients in case of cloud servers

* [MI-2613]: Fixed resetting error message on Link modal, showing descriptive error messages on UI and handling modals if account is not connected

* [MI-2613]: Fixed channel validation for DMs

* [MI-2613]: Added checks for filter API calls and user friendly error message

* [MI-2613]: Added logic to check if a subscription is not found on the Azure DevOps portal then delete it from the Mattermost's KV store

* [MI-2613]: Review fixes

* [MI-2613]: Review fixes

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [MI-2621]: Created font icons for subscription card and changed subscription titles to default color. (#27)

* [MI-2611]: Fixed modals not opening on multiple clients in case of cloud servers

* [MI-2613]: Fixed resetting error message on Link modal, showing descriptive error messages on UI and handling modals if account is not connected

* [MI-2613]: Fixed channel validation for DMs

* [MI-2613]: Added checks for filter API calls and user friendly error message

* [MI-2613]: Added logic to check if a subscription is not found on the Azure DevOps portal then delete it from the Mattermost's KV store

* [MI-2621]: Created font icons for subscription card and changed subscription titles to default color.

* [MI-2621]: Fixed test cases

* [MI-2621]: Fixed test cases

* [MI-2621]: Refactoring

* [MI-2621]: Added tooltip on project list card

* [MI-2621]: Fixed test cases

* [MI-2621]: Review fix

* [MI-2651]: Changed texts for work-item, added workitem in boards command, changed plugin name (#28)

* [MI-2651]: Changed texts for work-item, added workitem in boards command, changed plugin name

* [MI-2651]: Changed texts

* [MI-2651]: Made anyone as default arg for subscription list

* [MI-2651]: Added azd prefix for modal classes

* [MI-2651]: Added CSS util classes

* [MI-2651]: Fixed test cases

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [Review fix]: Removed unused files

* [MI-2669]: Added some key-values in plugin.json file and created separate functions for custom error components (#30)

* Added some key-values in plugin.json file and created separate functions for custom error components

* [MI-2669]: Added block lines

---------

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [MI-2672]: Removed consumerInput form subscription response, added validation to check channel access (#29)

* [MI-2672]: Removed consumerInput form subscription response, added validation to check channel access

* [MI-2672]: Fixed lint

* [MI-2672]: Fixed lint

* [MI-2672]: Added check for DM and groups with minor refactoring

* [MI-2672]: Review fixes

* [MI-2672]: Changed variable

* [MI-2672]: Fixed test case

---------

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [Fix]: Updated manifest file

* [MI-2669]: Made changes for subscriptionID to be used as key for KV-s… (#33)

* [MI-2669]: Made changes for subscriptionID to be used as key for KV-store, sorted subscriptions on basis of createdAt, users cannot see subscriptions of not participating channels

* [MI-2669]: Modified comment

---------

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [MI-2669_1]: Added a top level CSS class as a unique selector (#31)

* [MI-2669_1]: Added a top level CSS class as a unique selector

* [MI-2669]: Added top level class selector for components and review fixes

---------

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [MI-2669]: Created a hook for intercepting redux changes and moved the central login into it, formatted code (#32)

* [MI-2669]: Created a hook for intercepting redux changes and moved the central login into it, formatted code

* [MI-2669]: Modified comment

* [MI-2669]: Review fixes

---------

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [Refactor]: Removed unused util

* [MI-2669]: Created hook to fetch and load filters (#34)

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [Fix]: Moved subscriptionID field at the top in struct

* [MI-2748]: Implemented 1:1 mapping between MM user and Azure DevOps user for oAuth. (#35)

* [MI-2748]: Implemented 1:1 mapping between MM user and Azure DevOps user for oAuth.

* [MI-2748]: Added 1 test case and http response code

* [MI-2748]: Fixed condition

* [MI-2748]: Fixed token refresh logic

* [MI-2748]: Fixed CI

* [MI-2748]: Fixed CI

* [MI-2748]: Review fixes

* [MI-2748]: Fixed CI

* [MI-2748]: Review fixes

* [MI-2748]: Review fixes

---------

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [MI-2750]: Implemented fetching channel list on webapp and removes from plugin's server. (#36)

* [MI-2750]: Implemented fetching channel list on webapp and remove from plugin's server.

* [MI-2750]: Review fixes

* [MI-2750]: Changed comment message

---------

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [MI-2765]: Used @mattermost/client for making webapp calls to MM server (#37)

* [MI-2765]: Used @mattermost/client for making webapp calls to MM server

* [MI-2765]: Review fix

* [MI-2765]: Review fix

* [MI-2765]: Removed Mattermost API call RTK service

* [MI-2765]: Fixed CI

---------

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [MI-2820]: Modified API endpoint to require a project to be provided

* [MI-2820]: Removed extra line

* [MI-2820]: Review fixes

* [MI-2820]: Added LogWarn and refactored code

---------

Co-authored-by: raghavaggarwal2308 <raghav.aggarwal@brightscout.com>
Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
Co-authored-by: Ayush Thakur <100013900+ayusht2810@users.noreply.github.com>
@hanzei
Fix regex for tags trigger in CI/CD (#151)
54b09d8
@avas27JTG @raghavaggarwal2308
[MM-51404]: Added logic to generate unique webhook secret for subscri…
788729d 
…ptions (#152)

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
Co-authored-by: raghavaggarwal2308 <raghav.aggarwal@brightscout.com>
@mickmister mickmister mentioned this pull request Apr 4, 2023
Merged
@hanzei hanzei removed this from the v2.2.2 milestone Apr 6, 2023
manojmalik20 and others added 3 commits April 12, 2023 08:39
@manojmalik20
[MI-2561] Fixed the issue of new Oauth tab not closing automatically …
c6f41cc 
…in some browsers (#24) (#135)
@mickmister
Release v3.2.0 (#153)
d3dcd43 
* Release v3.2.0

* Update plugin.json

* make apply

* remove duplicate legacy `make apply` target

* re-add make apply target
@avas27JTG @raghavaggarwal2308
[Fix]: Fixed github issue #154 of adding whitespace on toggle button (#…
a583ee2 
…156)

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
Co-authored-by: raghavaggarwal2308 <raghav.aggarwal@brightscout.com>
@hanzei
Copy link
Contributor Author

hanzei commented Apr 18, 2023

Closing as #153 has been merged.

@hanzei hanzei closed this Apr 18, 2023
@hanzei hanzei removed their assignment Apr 18, 2023
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester 3: Security Review Review requested from Security Team labels Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mickmister mickmister mickmister left review comments

@srkgupta srkgupta srkgupta requested changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release v2.2.2
9 participants
@hanzei @codecov-commenter @srkgupta @mickmister @avas27JTG @ayusht2810 @raghavaggarwal2308 @spirosoik @manojmalik20