Compare "Phase 3" with base branch #141

mickmister · 2023-01-17T18:13:02Z

Summary

Includes changes from #133 and master

Ticket Link

* [MI-2235][Server]: Added admin constraints on slash commands * [MI-2235][Server]: Added switch case * [MI-2225][server][Review fix]: Added return message for error Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

Co-authored-by: Abhishek Verma <72438220+avas27JTG@users.noreply.github.com>

[MI-2231] Updated UI of subscription card to display service type and added author name in notification post

…re-devops into MI-2216

…ssage

… made required changes on the server (#85) * [MI-2199]: Made changes on server to add constraints on project/channel visibility on subscription cards. * [MI-2199]: Review fixes: minor formatting * [MI-2199]: Fixed test case * [MI-2199]: Fixed test case * [MI-2199] Fixed failing testcases * [MI-2199] Fixed failing testcases * [MI-2199]: Review fix: minor refactoring * [MI-2225]: Webapp: Created filter component * [MI-2225]: [Server+Webapp]: Create and integrate filter component and make required changes on the server * [MI-2225][Webapp]: Formatted comment * [MI-2225]: Fixed test case * [MI-2225][server+webapp][Review fixes]: Refactored code * [MI-2239][server+webapp][review-fix]: Refactored code * [MI-2225][server][review_fix]: grouped vars Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com> Co-authored-by: raghavaggarwal2308 <raghav.aggarwal@brightscout.com>

…re-devops into MI-2216

[MI-2216] Pull request link preview and updated UI for task link preview

Bump plugin version to v2.0.0

* [MI-2177][Documentation]: Updated readme files * [MI-2177][doc][review_fix]: updated sentences * [MI-2177][doc][review_fix]: updated readme. * [MI-2177][doc][review_fix]: Fixed spelling mistake Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

* [Server]: Written unit test cases for utils * [MI-2239][server][Review fix]: Optimised * [MI-2239][MI-2287] Review fixes 1. Added testutil folder 2. Added testcases for "ParseSubscriptionsToCommandResponse" * [MI-2239][MI-2287] Fixed failing CI * [MI-2239][MI-2287] Review fixes Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com> Co-authored-by: raghavaggarwal2308 <raghav.aggarwal@brightscout.com>

…ch repository list for a project. (#92) * [MI-2258]: [server]: Create plugin API to request Azure DevOps and fetch repository list for a project * [MI-2258][server][review_fix][CI_fix]: review fixes and added mock method. * [MI-2258][server][review_fix]: Minor refactoring * [MI-2258][MI-2287] Added testcases for "GetGitRepositories" and "handleGetGitRepositories" * [MI-2258][MI-2287] Self review fixes * [MI-2258][MI-2287] Review fixes 1. created "setupTestPlugin" function. * [MI-2258][server][review_fix]: Minor refactoring * [MI-2279][webapp]: Created UI and integrated repository filter for Repos (#93) * [MI-2279][webapp]: Created UI and integrated repository filter for Repos * [MI-2279][webapp]: Fixed util * [MI-2279][webapp]: Enhanced UX * [MI-2279][webapp][review_fix]: Minor refactoring Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com> Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com> Co-authored-by: raghavaggarwal2308 <raghav.aggarwal@brightscout.com>

…#94) * [MI-2258]: [server]: Create plugin API to request Azure DevOps and fetch repository list for a project * [MI-2258][server][review_fix][CI_fix]: review fixes and added mock method. * [MI-2279][webapp]: Created UI and integrated repository filter for Repos * [MI-2279][webapp]: Fixed util * [MI-2279][webapp]: Enhanced UX * [MI-2262][server]: Created plugin API to request branches for a repo. * [MI-2262][server]: Added mocked client method * [MI-2262][server][review_fix]: Added check for repo name. * [MI-2262][MI-2287] Added testcases for "HandleGetGitRepositoryBranches" and "GetGitRepositoryBranches" * [MI-2262][server][review_fix]: Minor refactoring * [MI-2262][MI-2287] Review fixes 1. Checked response in "TestHandleGetGitRepositoryBranches". 2. Created "setupMockPlugin" function. * [MI-2262][MI-2287] Review fixes * [MI-2284][server+webapp]: Made server changes to add filters as unique identifier and Created UI and integrated target-branch filter support. (#95) * WIP * [MI-2284][server+webapp]: Made server changes to add filters as unique identifier and Created UI and integrated target-branch filter support. * [MI-2284][MI-2287] Fixed failing testcases * [MI-2284][webapp][review_fix]: Fixed typo * [MI-2284][server]: Added comment * [MI-2284][webapp]: Fixed spelling * [MI-2288][server+webapp]: Differentiated payload for service-type and Created chip UI for displaying filters on subscription cards. (#97) * [server+webapp]: Differentiated payload for service-type and Created chip UI for displaying filters on subscription cards. * [MI-2288][server+webapp]: Changed struct type for publisher inputs * [MI-2288][server+webapp]: Modified projectID field name * [MI-2288][webapp]: Added tolltip on chip * [MI-2288][webapp]: Fixed import order Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com> Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com> Co-authored-by: raghavaggarwal2308 <raghav.aggarwal@brightscout.com> Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com> Co-authored-by: raghavaggarwal2308 <raghav.aggarwal@brightscout.com>

Co-authored-by: Abhishek Verma <72438220+avas27JTG@users.noreply.github.com>

Bump plugin version to v2.1.0

1. Updated API to support creating pipeline subscriptions. 2. Updated the UI for subscription modal to display pipeline event types. 3. Updated the UI of subscription card for for displaying pipeline subscriptions.

…ure-devops into MI-2315

…Created" event type

…eployment started" and "Release deployment completed"

…Run state changed" event type

avas27JTG · 2023-01-24T07:07:44Z

Awesome work on this project tada

I have some questions/comments for discussion, and two blocking concerns.

Any frontend styles should be nested under a class name specific to the plugin, such as .azuredevops-plugin

The way we are storing subscriptions poses a few issues to me. I've mentioned the concerns here #141 (comment)

Thanks, @mickmister
We are going through the review comments and will make the required changes and discussions on comments.

DHaussermann · 2023-01-30T17:01:37Z

@mickmister and @avas27JTG Can this merge so we have a v3.x release in our org?

DHaussermann · 2023-01-30T17:13:55Z

Some light testing will be needed once security issues are resolved but from a QA perspective - I don't know of anything blocking this.
(For some reason, I'm not able to add reviews in this repo.)

mickmister · 2023-01-30T21:34:57Z

FYI we actually want to merge #133. This PR is sort of a mock PR for a full review. It contains all changes, including any existing and pending changes to phase 3.

…rate functions for custom error components (#30) * Added some key-values in plugin.json file and created separate functions for custom error components * [MI-2669]: Added block lines --------- Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

avas27JTG · 2023-01-31T13:33:45Z

FYI we actually want to merge #133. This PR is sort of a mock PR for a full review. It contains all changes, including any existing and pending changes to phase 3.

@mickmister Please let us know if you want us to merge and trigger a release for #133 PR

mickmister · 2023-01-31T18:29:24Z

@DHaussermann @avas27JTG We should keep the master branch as stable as possible, and since there is still active work being done on the subscriptions feature, 2/5 we should keep #133 open.

We've made the decision that the first version shipped is to include phase 3. This PR I'm commenting on is essentially a replacement of the "main" review PR #128. cc @srkgupta

mickmister · 2023-01-31T18:31:15Z

@avas27JTG FYI the main item I'm blocking on atm is to use unique IDs for subscriptions instead of hashing its contents for the KV store key #141 (comment)

…lidation to check channel access (#29) * [MI-2672]: Removed consumerInput form subscription response, added validation to check channel access * [MI-2672]: Fixed lint * [MI-2672]: Fixed lint * [MI-2672]: Added check for DM and groups with minor refactoring * [MI-2672]: Review fixes * [MI-2672]: Changed variable * [MI-2672]: Fixed test case --------- Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

#33) * [MI-2669]: Made changes for subscriptionID to be used as key for KV-store, sorted subscriptions on basis of createdAt, users cannot see subscriptions of not participating channels * [MI-2669]: Modified comment --------- Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

avas27JTG · 2023-02-06T10:28:21Z

@avas27JTG FYI the main item I'm blocking on atm is to use unique IDs for subscriptions instead of hashing its contents for the KV store key #141 (comment)

@mickmister we have fixed this here

* [MI-2669_1]: Added a top level CSS class as a unique selector * [MI-2669]: Added top level class selector for components and review fixes --------- Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

server/store/subscriptions.go

…e central login into it, formatted code (#32) * [MI-2669]: Created a hook for intercepting redux changes and moved the central login into it, formatted code * [MI-2669]: Modified comment * [MI-2669]: Review fixes --------- Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

mickmister

LGTM

…ser for oAuth. (#35) * [MI-2748]: Implemented 1:1 mapping between MM user and Azure DevOps user for oAuth. * [MI-2748]: Added 1 test case and http response code * [MI-2748]: Fixed condition * [MI-2748]: Fixed token refresh logic * [MI-2748]: Fixed CI * [MI-2748]: Fixed CI * [MI-2748]: Review fixes * [MI-2748]: Fixed CI * [MI-2748]: Review fixes * [MI-2748]: Review fixes --------- Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

…om plugin's server. (#36) * [MI-2750]: Implemented fetching channel list on webapp and remove from plugin's server. * [MI-2750]: Review fixes * [MI-2750]: Changed comment message --------- Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

webapp/src/pluginConstants/apiService.ts

…er (#37) * [MI-2765]: Used @mattermost/client for making webapp calls to MM server * [MI-2765]: Review fix * [MI-2765]: Review fix * [MI-2765]: Removed Mattermost API call RTK service * [MI-2765]: Fixed CI --------- Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

mickmister · 2023-02-21T20:52:31Z

/update-branch

raghavaggarwal2308 and others added 30 commits October 11, 2022 16:03

[MI-2216] Review fixes

500e860

[MI-2216] Added author name in preview header

f9710ad

[MI-2216] Review fixes

48e6e2d

[MI-2231] Review fixes

0154339

Update comment in webapp/src/styles/_components.scss

0d97587

Co-authored-by: Abhishek Verma <72438220+avas27JTG@users.noreply.github.com>

[MI-2216] Review fixes

2bcc9d9

Merge pull request #87 from Brightscout/MI-2231

dd8a84e

[MI-2231] Updated UI of subscription card to display service type and added author name in notification post

Merge branch 'master' of github.com:Brightscout/mattermost-plugin-azu…

452f977

…re-devops into MI-2216

[MI-2216] Fixed a minor bug in regex expression to check link in a me…

0d080c6

…ssage

Merge branch 'master' of github.com:Brightscout/mattermost-plugin-azu…

65ddbf2

…re-devops into MI-2216

Merge pull request #84 from Brightscout/MI-2216

0e8c9e6

[MI-2216] Pull request link preview and updated UI for task link preview

Bump plugin version to v2.0.0

44d1f79

Merge pull request #91 from Brightscout/release-2.0.0

4c615c2

Bump plugin version to v2.0.0

Bump plugin version to v2.1.0

45c220a

Update plugin.json

9e65c78

Co-authored-by: Abhishek Verma <72438220+avas27JTG@users.noreply.github.com>

Merge pull request #99 from Brightscout/release-2.1.0

49ec0a7

Bump plugin version to v2.1.0

[MI-2304] Pipeline subscription

85a669a

1. Updated API to support creating pipeline subscriptions. 2. Updated the UI for subscription modal to display pipeline event types. 3. Updated the UI of subscription card for for displaying pipeline subscriptions.

[MI-2315] Added slash command to add/list pipeline subscriptions

21c0365

[MI-2304] Fixed casing of event type description

1f0947e

Merge branch 'MI-2304' of github.com:Brightscout/mattermost-plugin-az…

b73575d

…ure-devops into MI-2315

[MI-2321] Created notification post for "Release Created" and "Build …

b201a3d

…Created" event type

[MI-2321] Added notification post for "Release Abandoned", "Release d…

0798808

…eployment started" and "Release deployment completed"

[MI-2321] Added notification post for "Run stage state changed" and "…

b2dd84f

…Run state changed" event type

[MI-2321] Refactored code

a46984f

hanzei added the 2: Dev Review Requires review by a core committer label Jan 24, 2023

[Review fix]: Removed unused files

968391b

hanzei added the Do Not Merge Should not be merged until this label is removed label Jan 31, 2023

avas27JTG and others added 3 commits February 1, 2023 18:09

[Fix]: Updated manifest file

d22a81d

avas27JTG mentioned this pull request Feb 6, 2023

[MI-2669]: Created a hook for intercepting redux changes and moved the central login into it, formatted code Brightscout/mattermost-plugin-azure-devops#32

Merged

[MI-2669_1]: Added a top level CSS class as a unique selector (#31)

61e8f38

* [MI-2669_1]: Added a top level CSS class as a unique selector * [MI-2669]: Added top level class selector for components and review fixes --------- Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

mickmister commented Feb 6, 2023

View reviewed changes

server/store/subscriptions.go Outdated Show resolved Hide resolved

avas27JTG and others added 4 commits February 7, 2023 12:27

[Refactor]: Removed unused util

8c5b806

[MI-2669]: Created hook to fetch and load filters (#34)

1e0fc5f

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>

[Fix]: Moved subscriptionID field at the top in struct

6d00878

mickmister commented Feb 8, 2023

View reviewed changes

avas27JTG and others added 2 commits February 10, 2023 15:50

mickmister commented Feb 13, 2023

View reviewed changes

webapp/src/pluginConstants/apiService.ts Outdated Show resolved Hide resolved

hanzei closed this Feb 26, 2023

hanzei removed the 2: Dev Review Requires review by a core committer label Feb 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Compare "Phase 3" with base branch #141

Compare "Phase 3" with base branch #141

mickmister commented Jan 17, 2023 •

edited

Loading

avas27JTG commented Jan 24, 2023

DHaussermann commented Jan 30, 2023

DHaussermann commented Jan 30, 2023

mickmister commented Jan 30, 2023

avas27JTG commented Jan 31, 2023

mickmister commented Jan 31, 2023

mickmister commented Jan 31, 2023

avas27JTG commented Feb 6, 2023 •

edited

Loading

mickmister left a comment

mickmister commented Feb 21, 2023

Compare "Phase 3" with base branch #141

Compare "Phase 3" with base branch #141

Conversation

mickmister commented Jan 17, 2023 • edited Loading

Summary

Ticket Link

avas27JTG commented Jan 24, 2023

DHaussermann commented Jan 30, 2023

DHaussermann commented Jan 30, 2023

mickmister commented Jan 30, 2023

avas27JTG commented Jan 31, 2023

mickmister commented Jan 31, 2023

mickmister commented Jan 31, 2023

avas27JTG commented Feb 6, 2023 • edited Loading

mickmister left a comment

Choose a reason for hiding this comment

mickmister commented Feb 21, 2023

mickmister commented Jan 17, 2023 •

edited

Loading

avas27JTG commented Feb 6, 2023 •

edited

Loading