Skip to content

Commit

Permalink
[MM-54028] Add custom label to help fetching logs (#37)
Browse files Browse the repository at this point in the history
* Bump min recorder version

* Add app label to job/pods to help fetching logs
  • Loading branch information
streamer45 authored Aug 11, 2023
1 parent 00a5750 commit 42a709b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
2 changes: 1 addition & 1 deletion public/job/job.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const (
TypeRecording Type = "recording"
)

const minSupportedRecorderVersion = "0.4.0"
const minSupportedRecorderVersion = "0.4.1"

// We currently support two formats, semantic version tag or image hash (sha256).
// TODO: Consider deprecating tag version and switch to hash only.
Expand Down
4 changes: 4 additions & 0 deletions service/kubernetes/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,8 @@ func (s *JobService) CreateJob(cfg job.Config, onStopCb job.StopCb) (job.Job, er
Labels: map[string]string{
// Using a custom label to easily watch the job.
"job_name": jobName,
// app label helps with fetching logs.
"app": "mattermost-calls-offloader",
},
},
Spec: batchv1.JobSpec{
Expand All @@ -180,6 +182,8 @@ func (s *JobService) CreateJob(cfg job.Config, onStopCb job.StopCb) (job.Job, er
Labels: map[string]string{
// Using a custom label to easily retrieve the pod later on.
"job_name": jobName,
// app label helps with fetching logs.
"app": "mattermost-calls-offloader",
},
},
Spec: corev1.PodSpec{
Expand Down

0 comments on commit 42a709b

Please sign in to comment.