[MM-53555] Support defining image registry through configuration #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamer45
added
2: Dev Review
jupenur
approved these changes
Jan 4, 2024
| } | ||
|
|
||
| recorderRunnerREs := []*regexp.Regexp{ | ||
| regexp.MustCompile(fmt.Sprintf(`^%s/%s:v((?:0|[1-9]\d*)\.(?:0|[1-9]\d*)\.(?:0|[1-9]\d*))$`, registry, RecordingJobPrefix)), |
There was a problem hiding this comment.
Probably don't want to use MustCompile now that there's user input in there?
There was a problem hiding this comment.
I mean, if they want to crash the service they can do it. The compilation applies only to the input coming from the offloader service config setting (or environment variable) itself. I felt the convenience was enough to justify the tradeoff but can be changed of course.
cpoile
approved these changes
Jan 8, 2024
cpoile
added
3: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR adds a new config setting to control the image registry to be used during validation of job runners coming from the plugin side. This is useful in case of air gapped environments that may not be able to fetch from the default (public) Mattermost docker registry but would like to use a local registry instead.
Ticket Link
https://mattermost.atlassian.net/browse/MM-53555