Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-53555] Implement env override for job service image registry #607

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

streamer45
Copy link
Collaborator

Summary

We introduce a new MM_CALLS_JOB_SERVICE_IMAGE_REGISTRY override to control the image registry to be used to define job runners. This is needed in case something other than the default public registry (mattermost) is configured on the calls-offloader side (see related PR).

Related PR

mattermost/calls-offloader#50

Ticket Link

https://mattermost.atlassian.net/browse/MM-53555

@streamer45 streamer45 added 2: Dev Review Requires review by a core committer 3: Security Review labels Jan 3, 2024
@streamer45 streamer45 added this to the v0.23.0 / MM 9.5 milestone Jan 3, 2024
@streamer45 streamer45 self-assigned this Jan 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (d7caacc) 9.33% compared to head (a93631b) 9.32%.

Files Patch % Lines
server/job_service.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #607      +/-   ##
========================================
- Coverage   9.33%   9.32%   -0.01%     
========================================
  Files         26      26              
  Lines       5294    5299       +5     
========================================
  Hits         494     494              
- Misses      4748    4753       +5     
  Partials      52      52              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@streamer45 streamer45 added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Jan 8, 2024
@streamer45 streamer45 merged commit 56e1d9b into main Jan 24, 2024
6 checks passed
@streamer45 streamer45 deleted the MM-53555 branch January 24, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants