Changed wording of error page #254
Conversation
razzeee
force-pushed
the
improve-error-wording
branch
from
3edf879 to
33b673f
Compare
|
Looks better. "What does the user need to check?" would be more helpful than error details. FYI, I found a issue that |
|
Sorry, ment to say that about the link, but somehow forgot. :) |
|
Looks much better, thanks @razzeee for your work here! Propose queuing the proposal in UX Design channel where the Mattermost team can offer their feedback. |
|
This is what the ux team came up with. As I'm on war with CSS I'm pretty sure I will fail at centering everything, but let's see. |
razzeee
force-pushed
the
improve-error-wording
branch
2 times, most recently
from
a4963e9 to
8305d61
Compare
|
|
|
Really nice work here, thanks @razzeee! I'll check with the platform team if they have time to help out with CSS. @asaadmahmood is fantastic with it, so he might be able to do tweaks pretty quickly. |
razzeee
force-pushed
the
improve-error-wording
branch
from
8305d61 to
2475671
Compare
|
@asaadmahmood did some look and feel changes, so we're now at this:
|
|
Looks great to me. Big thanks @razzeee and @asaadmahmood! We're really improving the UX standard with v1.4, which is awesome. @yuya-oc: @asaadmahmood worked on this on his Mac, and this works on Windows. Do you think further testing is needed? |
| <hr /> | ||
| <p>We're having trouble connecting to Mattermost. If refreshing this page (Ctrl+R or Command+R) does not work please verify that:</p> | ||
| <br /> | ||
| <p> |
There was a problem hiding this comment.
The console shows index.js:1812 Warning: validateDOMNesting(...): <ul> cannot appear as a descendant of <p>. In my setting, which has three teams and the third is incorrect URL, I could not click the second tab while showing the third tab. Is this related?
|
The styling looks fine. Probably this is not related to OS excepting fonts, so I think we need just one tester for next testing. |
razzeee
force-pushed
the
improve-error-wording
branch
2 times, most recently
from
c53df34 to
56cdecf
Compare
| <ListGroupItem>Is the server alive?</ListGroupItem> | ||
| <ListGroupItem>Is the URL correct?</ListGroupItem> | ||
| </ListGroup> | ||
| <div style={ errorPage.tableStyle }> |
There was a problem hiding this comment.
By removing these two <div>, tabs properly works while showing the error page. So you might need to adjust the vertical position with other ways.
razzeee
force-pushed
the
improve-error-wording
branch
from
56cdecf to
c8dd114
Compare
|
Should be fixed now |
razzeee
force-pushed
the
improve-error-wording
branch
from
c8dd114 to
b294a44
Compare
|
The tabs work properly on Windows 10 and OS X. @razzeee Just curious, what was the point in the last push? |
|
@yuya-oc |
|
I see. Thanks! |
Just an idea how it could look, some graphics would also be nice. So please let's get some feedback, as I'm not really an ui guy.