Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix desktop notifications not working when the window is minimized from inactive state #545

Merged
merged 2 commits into from
Jun 6, 2017

Conversation

yuya-oc
Copy link
Contributor

@yuya-oc yuya-oc commented Jun 5, 2017

Blur webview when the main window loses its focus.

Before submitting, please confirm you've

Please provide the following information:

Summary
Fix desktop notifications not working when the window is minimized from inactive state.

Explicitly blur webview when the window loses focus. Tested on Windows 10 and server v3.8.

Issue link
#522

Test Cases

  1. Select any channel for this test (We call it "channel A" for simplicity)
  2. Make the app window inactive (ex. by clicking on the other window)
  3. Click on the "minimize" button on the title bar of Mattermost window.
  4. Send a message to the channel A from the other account.
  5. Desktop notifications should appear.

Additional Notes
https://circleci.com/gh/yuya-oc/desktop/271#artifacts

Blur webview when the main window loses its focus.
@yuya-oc yuya-oc added this to the v3.8.0 milestone Jun 5, 2017
@jasonblais
Copy link
Contributor

jasonblais commented Jun 5, 2017

Tested on windows 10, pre-release, works as expected. Thanks @yuya-oc 🎉

@yuya-oc
Copy link
Contributor Author

yuya-oc commented Jun 6, 2017

Thanks @jasonblais !

@yuya-oc yuya-oc merged commit 77e5a7d into mattermost:master Jun 6, 2017
@yuya-oc yuya-oc deleted the blur-webview-on-deactivation branch June 6, 2017 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants