Remove focus after cancelling modal #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MusikPolice
approved these changes
Oct 2, 2017
yuya-oc
suggested changes
Oct 2, 2017
| this.props.onTeamRemove(); | ||
| } | ||
| handleTeamEditing() { | ||
| document.activeElement.blur(); |
There was a problem hiding this comment.
In the team list, TeamList.jsx controls modals. So I think it should call document.activeElement.blur().
| @@ -9,9 +9,11 @@ class TeamListItem extends React.Component { | |||
| } | |||
|
|
|||
| handleTeamRemove() { | |||
| document.activeElement.blur(); | |||
There was a problem hiding this comment.
In the team list, TeamList.jsx controls modals. So I think it should call document.activeElement.blur().
|
Thanks @wvds, the behavior looks good! For better code, would you review my comments? |
|
@jasonblais @yuya-oc I've made the changes to the pull request :-) |
yuya-oc
approved these changes
Oct 7, 2017
|
Thanks @wvds!! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #446
Before submitting, please confirm you've
npm run lint:jsfor proper code formattingPlease provide the following information:
Summary
After closing the modal the focus of the clicked link will be removed
Issue link
#446