Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update community-plugin-marketplace.md #747

Closed
wants to merge 9 commits into from

Conversation

justinegeffen
Copy link
Contributor

Removed double line breaks, changes high-availability to High Availability.

Removed double line breaks, changes high-availability to High Availability.
@justinegeffen justinegeffen added the 1: Dev Review Requires review by a core commiter label Dec 18, 2020
@github-actions
Copy link

Newest code from justinegeffen has been published to preview environment

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 1: Dev Review Requires review by a core commiter labels Jan 14, 2021
@github-actions
Copy link

Newest code from hanzei has been published to preview environment

@github-actions
Copy link

Newest code from hanzei has been published to preview environment

Added documentation requirements and updated the header formatting for consistency (sentence case).
@justinegeffen justinegeffen added 1: Dev Review Requires review by a core commiter 1: PM Review Requires review by a product manager and removed 4: Reviews Complete All reviewers have approved the pull request labels Jan 18, 2021
@github-actions
Copy link

Newest code from justinegeffen has been published to preview environment

Copy link
Contributor

@jasonblais jasonblais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One non-blocking proposal

@jasonblais jasonblais removed the 1: PM Review Requires review by a product manager label Jan 18, 2021
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heads up that the changes here will need to get propagated to https://github.com/mattermost/mattermost-marketplace/blob/master/.github/ISSUE_TEMPLATE/add_plugin.md. @justinegeffen is that something you can do after this PR is merged?

* Configuration steps
* Usage
* Link or email address for help/support
2. The `plugin.json` file should include formatting consistent with the System Console UI. For assistance with this, you can visit the [Documentation channel](https://community.mattermost.com/core/channels/documentation) for assistance.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any docs about the style guidelines that we can link?

Comment on lines 41 to 46
1. The plugin must include a `README.md` file with:
* Requirements
* Installation steps
* Configuration steps
* Usage
* Link or email address for help/support
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With these items in place does that mean item 4. at "Product requirements" is not longer needed? Should we combine those?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I'll combine them.

Comment on lines 41 to 46
1. The plugin must include a `README.md` file with:
* Requirements
* Installation steps
* Configuration steps
* Usage
* Link or email address for help/support
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the support link just be the github issues page? If so, what is the difference to item 3 on "Product requirements"?

Co-authored-by: Jason Blais <13119842+jasonblais@users.noreply.github.com>
@github-actions
Copy link

Newest code from justinegeffen has been published to preview environment

@hanzei hanzei added the Work in Progress Not yet ready for review label Jul 2, 2021
@github-actions
Copy link

github-actions bot commented Aug 2, 2021

Newest code from justinegeffen has been published to preview environment for Git SHA 71c259d

@justinegeffen justinegeffen removed the Work in Progress Not yet ready for review label Sep 2, 2021
justinegeffen added a commit that referenced this pull request Sep 2, 2021
Replaced content with content from #747.
@hanzei hanzei removed the 1: Dev Review Requires review by a core commiter label Sep 3, 2021
@hanzei hanzei deleted the justinegeffen-patch-4 branch September 3, 2021 06:18
justinegeffen added a commit that referenced this pull request Sep 15, 2021
* Update community-plugin-marketplace.md

Replaced content with content from #747.

* Update site/content/integrate/plugins/community-plugin-marketplace.md

* Update community-plugin-marketplace.md

* Update site/content/integrate/plugins/community-plugin-marketplace.md

* Update site/content/integrate/plugins/community-plugin-marketplace.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants