-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update community-plugin-marketplace.md #747
Conversation
Removed double line breaks, changes high-availability to High Availability.
Newest code from justinegeffen has been published to preview environment |
Newest code from hanzei has been published to preview environment |
Newest code from hanzei has been published to preview environment |
Added documentation requirements and updated the header formatting for consistency (sentence case).
Newest code from justinegeffen has been published to preview environment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One non-blocking proposal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heads up that the changes here will need to get propagated to https://github.com/mattermost/mattermost-marketplace/blob/master/.github/ISSUE_TEMPLATE/add_plugin.md. @justinegeffen is that something you can do after this PR is merged?
* Configuration steps | ||
* Usage | ||
* Link or email address for help/support | ||
2. The `plugin.json` file should include formatting consistent with the System Console UI. For assistance with this, you can visit the [Documentation channel](https://community.mattermost.com/core/channels/documentation) for assistance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any docs about the style guidelines that we can link?
1. The plugin must include a `README.md` file with: | ||
* Requirements | ||
* Installation steps | ||
* Configuration steps | ||
* Usage | ||
* Link or email address for help/support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With these items in place does that mean item 4. at "Product requirements" is not longer needed? Should we combine those?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. I'll combine them.
1. The plugin must include a `README.md` file with: | ||
* Requirements | ||
* Installation steps | ||
* Configuration steps | ||
* Usage | ||
* Link or email address for help/support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the support link just be the github issues page? If so, what is the difference to item 3 on "Product requirements"?
Co-authored-by: Jason Blais <13119842+jasonblais@users.noreply.github.com>
Newest code from justinegeffen has been published to preview environment |
Newest code from justinegeffen has been published to preview environment for Git SHA 71c259d |
Replaced content with content from #747.
* Update community-plugin-marketplace.md Replaced content with content from #747. * Update site/content/integrate/plugins/community-plugin-marketplace.md * Update community-plugin-marketplace.md * Update site/content/integrate/plugins/community-plugin-marketplace.md * Update site/content/integrate/plugins/community-plugin-marketplace.md
Removed double line breaks, changes high-availability to High Availability.